From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-02-iad.dyndns.com (mxout-051-iad.mailhop.org [216.146.32.51]) by lists.bufferbloat.net (Postfix) with ESMTP id 0B80A2E03C0 for ; Wed, 9 Mar 2011 08:46:56 -0800 (PST) Received: from scan-02-iad.mailhop.org (scan-02-iad.local [10.150.0.207]) by mail-02-iad.dyndns.com (Postfix) with ESMTP id 4A031836702 for ; Wed, 9 Mar 2011 16:46:57 +0000 (UTC) X-Spam-Score: 0.0 () X-Mail-Handler: MailHop by DynDNS X-Originating-IP: 78.46.109.217 Received: from sipsolutions.net (he.sipsolutions.net [78.46.109.217]) by mail-02-iad.dyndns.com (Postfix) with ESMTP id E11B1836592 for ; Wed, 9 Mar 2011 16:46:56 +0000 (UTC) Received: by sipsolutions.net with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.74) (envelope-from ) id 1PxMXC-0003tI-SM; Wed, 09 Mar 2011 17:46:50 +0100 Subject: Re: [PATCH 1/3] wireless: add support for ethtool_ops->{get,set}_ringparam From: Johannes Berg To: "John W. Linville" In-Reply-To: <1299687684-19638-1-git-send-email-linville@tuxdriver.com> References: <1299687684-19638-1-git-send-email-linville@tuxdriver.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 09 Mar 2011 17:46:51 +0100 Message-ID: <1299689211.23764.0.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Cc: bloat-devel@lists.bufferbloat.net, me@bobcopeland.com, linux-wireless@vger.kernel.org, mickflemm@gmail.com X-BeenThere: bloat-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Developers working on AQM, device drivers, and networking stacks" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2011 16:46:57 -0000 On Wed, 2011-03-09 at 11:21 -0500, John W. Linville wrote: > Signed-off-by: John W. Linville > --- > include/net/cfg80211.h | 4 ++++ > net/wireless/ethtool.c | 33 +++++++++++++++++++++++++++++++++ > 2 files changed, 37 insertions(+), 0 deletions(-) > > diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h > index 1ac5786..25f546f 100644 > --- a/include/net/cfg80211.h > +++ b/include/net/cfg80211.h > @@ -1364,6 +1364,10 @@ struct cfg80211_ops { > > int (*set_antenna)(struct wiphy *wiphy, u32 tx_ant, u32 rx_ant); > int (*get_antenna)(struct wiphy *wiphy, u32 *tx_ant, u32 *rx_ant); > + > + int (*set_ringparam)(struct wiphy *wiphy, u32 tx, u32 rx); > + void (*get_ringparam)(struct wiphy *wiphy, > + u32 *tx, u32 *tx_max, u32 *rx, u32 *rx_max); Can you add docs here and in mac80211 please? johannes