General list for discussing Bufferbloat
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dave Taht <dave.taht@gmail.com>
Cc: bloat <bloat@lists.bufferbloat.net>
Subject: Re: [Bloat] Notes about hacking on AQMs
Date: Wed, 08 Jun 2011 16:57:12 +0200	[thread overview]
Message-ID: <1307545032.3057.45.camel@edumazet-laptop> (raw)
In-Reply-To: <BANLkTi=3yi4Wtu4+qsmf=YbPL4fZKf_gQQ@mail.gmail.com>

Le mercredi 08 juin 2011 à 08:04 -0600, Dave Taht a écrit :
> It looks like adding ECN to the other qdiscs would be good, and
> transparent to the upper layers, but a 10 minute glance at HTB seems
> to make it a non-trivial exercise. But that's me. I would certainly
> like to see ECN asserted more often than it is. Thoughts?

Just add to your HTB some RED qdisc ? You have a framework to build
whatever is needed. Dont try to use a "single magic thing that will
solve all my problems". This reminds me the ESFQ attempt : Patrick
prefered to plug an external classifier in SFQ, instead of adding
specialized code in each possible Qdisc.


I had the idea to add ECN to SFQ (my favorite qdisc for proxies dealing
only with tcp flows) in the past, with a global config (shared for all
flows : remember SFQ means Fair Queuing ;) )

At queueing time :

- we compute the flow (internal default SFQ classifier, or external user
provided one)
- We queue the packet into its slot X (kind of pfifo)
- If queue limit is reached, take a packet from the biggest slot Y, do a
head drop. Return Congestion Notification to caller if the chosen slot
is the slot X (X == Y)

Adding ECN/RED here could be done with very litle added cost :

Adding kind of RED on each slot, instead of a regular pfifo, and
probabilist mark/drop packet at enqueue time if :
- Current slot length is above the RED lower threshold
- Or average residency time in slot above a threshold

And doing full drop if :
- Current slot length is above RED upper limit
- Current elapsed time of head packet above upper time limit.

I like the time being the feedback instead of queue length (hard to
tune, especially if bandwidth is unknown)

You would say for example : 
	min_time = 3 ms 
	max_time = 30 ms
	probability = 0.05
	limit_time = 100 ms




  reply	other threads:[~2011-06-08 14:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08 12:12 Dave Taht
2011-06-08 12:56 ` Eric Dumazet
2011-06-08 13:32   ` Dave Taht
2011-06-08 14:04     ` Dave Taht
2011-06-08 14:57       ` Eric Dumazet [this message]
2011-06-08 15:20         ` Dave Taht
2011-06-08 15:21           ` Dave Taht
2011-06-23 22:38           ` Juliusz Chroboczek
2011-06-23 22:47             ` Dave Taht
2011-06-08 15:27         ` Jesper Dangaard Brouer
2011-06-08 15:45           ` Eric Dumazet
2011-06-08 15:51             ` Dave Taht
2011-06-08 16:41               ` Eric Dumazet
2011-06-08 16:52                 ` Dave Taht
2011-06-08 17:50                   ` Stephen Hemminger
2011-06-08 23:06           ` Thomas Graf
2011-06-09 17:18             ` Jesper Dangaard Brouer
2011-06-09 16:04   ` Jesper Dangaard Brouer
2011-06-09 16:14     ` Eric Dumazet
2011-06-09 17:20       ` Jesper Dangaard Brouer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/bloat.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307545032.3057.45.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=bloat@lists.bufferbloat.net \
    --cc=dave.taht@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox