From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Steinar H. Gunderson" <sgunderson@bigfoot.com>
Cc: bloat@lists.bufferbloat.net
Subject: Re: [Bloat] a flood of Bufferbloat-related papers
Date: Tue, 11 Oct 2011 14:13:54 +0200 [thread overview]
Message-ID: <1318335234.2538.9.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> (raw)
In-Reply-To: <20111011115816.GA24956@uio.no>
Le mardi 11 octobre 2011 à 13:58 +0200, Steinar H. Gunderson a écrit :
> On Tue, Oct 11, 2011 at 12:27:17PM +0200, David Täht wrote:
> > On my list already would be "an analysis of the effects of broken sack
> > processing on linux 2.4.24-3.1", of which I *think* I've captured
> > multiple examples of in the raw traces I've been collecting for
> > months... (so if anyone is interested in the raw data, I can provide)
>
> Do you have any more information? The only thing I could find online was that
> there were SACK issues that were supposed to be fixed by 2.6.16; nothing
> about a fix in 3.1 or post-3.1.
>
Of course, instead of discussing all linux stuff privately, it would be
good to discuss with linux network maintainers.
Or is the goal is to provide nice papers only ?
commit f779b2d60ab95c17f1e025778ed0df3ec2f05d75
Author: Zheng Yan <zheng.z.yan@intel.com>
Date: Sun Sep 18 22:37:34 2011 -0400
tcp: fix validation of D-SACK
D-SACK is allowed to reside below snd_una. But the corresponding check
in tcp_is_sackblock_valid() is the exact opposite. It looks like a typo.
Signed-off-by: Zheng Yan <zheng.z.yan@intel.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index ea0d218..21fab3e 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -1124,7 +1124,7 @@ static int tcp_is_sackblock_valid(struct tcp_sock *tp, int is_dsack,
return 0;
/* ...Then it's D-SACK, and must reside below snd_una completely */
- if (!after(end_seq, tp->snd_una))
+ if (after(end_seq, tp->snd_una))
return 0;
if (!before(start_seq, tp->undo_marker))
next prev parent reply other threads:[~2011-10-11 12:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 10:27 David Täht
2011-10-11 11:58 ` Steinar H. Gunderson
2011-10-11 12:13 ` Eric Dumazet [this message]
2011-10-11 12:18 ` Eric Dumazet
2011-10-11 13:09 ` [Bloat] the observed sack oddity David Täht
2011-10-11 13:11 ` David Täht
2011-10-11 13:33 ` Eric Dumazet
2011-10-11 13:51 ` David Täht
2011-10-11 15:25 ` Justin McCann
2011-10-11 15:37 ` Justin McCann
2011-10-13 18:23 ` Jan Ceuleers
2011-10-13 18:27 ` Eric Dumazet
2011-10-11 12:40 ` [Bloat] a flood of Bufferbloat-related papers David Täht
2011-10-11 12:17 ` David Täht
2011-10-12 7:49 ` Lawrence Stewart
2011-10-12 8:03 ` David Täht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/bloat.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318335234.2538.9.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC \
--to=eric.dumazet@gmail.com \
--cc=bloat@lists.bufferbloat.net \
--cc=sgunderson@bigfoot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox