From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f43.google.com (mail-bk0-f43.google.com [209.85.214.43]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id A68FD2006AA for ; Thu, 10 May 2012 02:27:27 -0700 (PDT) Received: by bkty5 with SMTP id y5so2307494bkt.16 for ; Thu, 10 May 2012 02:27:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; bh=q5CGZEoBhFBSBhPiTfodzCgSAMNexYSoDB+D66rcBik=; b=RAVRqjPX1U6SG9cEPN6Uh8Q++yO1qrXe0uVYcZJ/LaCVWptG+IuaVW2r2hQk67wvey 5UhUU/Ct42BOsy1mzFLXHYIWIGsnlkr70pt39tPO5t8hV6PoI2FuW1WgL0zYNKyiPxVG S2CYv2oBNuqNwvQbP5DZg6zyUJumL0E5apHecUGZc+6jlYwvwSmHgrEY8180nO32B5Q/ ZbZSjpXtqiBW/a8N2SVVk3CyDFRdNWXqmpc3Nwce45nqLwzfum7Dvg05XePMJdwYYNWb T8JTQCVshw4VCAXw7Oh/Ju0nu4lgkRMu2ikc42PX+F1fuOpwc+MMrscn7GUsQBYJcfD1 3BgA== Received: by 10.204.153.15 with SMTP id i15mr1520999bkw.74.1336642045347; Thu, 10 May 2012 02:27:25 -0700 (PDT) Received: from [172.28.91.135] ([74.125.122.49]) by mx.google.com with ESMTPS id 9sm10377806bku.9.2012.05.10.02.27.23 (version=SSLv3 cipher=OTHER); Thu, 10 May 2012 02:27:24 -0700 (PDT) From: Eric Dumazet To: "Steinar H. Gunderson" In-Reply-To: <20120510091943.GC8131@uio.no> References: <4FA9FDC0.9010600@superduper.net> <44673AC5-4320-4C19-9788-87A63C47549D@cisco.com> <4FAAE5F0.2030404@freedesktop.org> <1336607919.12504.119.camel@edumazet-glaptop> <20120510000854.GB8131@uio.no> <1336608991.12504.123.camel@edumazet-glaptop> <20120510091943.GC8131@uio.no> Content-Type: text/plain; charset="UTF-8" Date: Thu, 10 May 2012 11:27:22 +0200 Message-ID: <1336642042.12504.148.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Cc: bloat@lists.bufferbloat.net Subject: Re: [Bloat] [Codel] The challenge X-BeenThere: bloat@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: General list for discussing Bufferbloat List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2012 09:27:28 -0000 On Thu, 2012-05-10 at 11:19 +0200, Steinar H. Gunderson wrote: > On Thu, May 10, 2012 at 02:16:31AM +0200, Eric Dumazet wrote: > > Starting from kernel 2.6.13 Hybla has been included in the official > > Linux kernel. However, this implementation, based on the "module" Linux > > technology, does not include the last two Hybla components: Hoe's > > channel bandwidth estimate and packet spacing. Their addition is > > mandatory to fully benefit from Hybla performance improvement. To this > > end, it is enough to patch the official kernel with the MultiTCP > > package, downloadable from the downloads section. > > That explains it, indeed. Their latest patch is for 3.0.0, which is maybe > recent enough that I can try to coax it in next time I compile my kernel :-) > > /* Steinar */ Unfortunately patchs seems in a bad shape... random examples : +void __tcp_pacing_reset_timer(struct sock *sk) +{ + struct tcp_sock *tp = tcp_sk(sk); + __u32 timeout = jiffies + tp->pacing.delta; + + if (!mod_timer(&tp->pacing.timer, timeout)) + sock_hold(sk); +} +EXPORT_SYMBOL(__tcp_pacing_reset_timer); + timeout should be an "unsigned long" -static void tcp_conservative_spur_to_response(struct tcp_sock *tp) +static void tcp_conservative_spur_to_response(struct sock *sk) { + struct tcp_sock *tp = tcp_sk(sk); tp->snd_cwnd = min(tp->snd_cwnd, tp->snd_ssthresh); tp->snd_cwnd_cnt = 0; tp->bytes_acked = 0; TCP_ECN_queue_cwr(tp); - tcp_moderate_cwnd(tp); + tcp_moderate_cwnd(sk, tp); } There is no point passing both sk and tp to a function, since tcp_sk(sk) is a nop.