From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eric.dumazet@gmail.com>
Received: from mail-pb0-x235.google.com (mail-pb0-x235.google.com
	[IPv6:2607:f8b0:400e:c01::235])
	(using TLSv1 with cipher RC4-SHA (128/128 bits))
	(Client CN "smtp.gmail.com",
	Issuer "Google Internet Authority" (verified OK))
	by huchra.bufferbloat.net (Postfix) with ESMTPS id C145B2021A8
	for <bloat@lists.bufferbloat.net>; Thu, 30 May 2013 07:39:13 -0700 (PDT)
Received: by mail-pb0-f53.google.com with SMTP id un4so461167pbc.26
	for <bloat@lists.bufferbloat.net>; Thu, 30 May 2013 07:39:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:subject:from:to:cc:date:in-reply-to:references
	:content-type:x-mailer:content-transfer-encoding:mime-version;
	bh=4iTcehjzFYawltALi/ObwEP3+vy1LciaP3irRRtL5zM=;
	b=ZwBJ5seLtqigEjNVCbTAV/THvWprqhuQ8RzwPvdoOvKPv+hHRqIeQWGIAK3qMklFKf
	dACG/uDNrQVC4tGo84emWQDo58KunbojMf+E3OZzBUIPyETplhAxygleSSxAju8YhME3
	+tG2p+6OaQn7wVDv7QqgDZH37w6jP3VexdmV3rRcqNdtYX+xH7CAXZ4YnJXZKBT/NlEk
	RI7GyTn3xOI+ODynAVx/wumiqKWslADF9DD1ZGZNBODxbZrbcm5tWIJKBk0puOJ4PtTh
	JA5vtE/n4dRJ2iEzHUQz9c5yJDHj0E13YUUTEHg9XkoR+9L0PP8h0WIL/6MzCxEjyI8L
	djew==
X-Received: by 10.66.145.2 with SMTP id sq2mr8732486pab.2.1369924752952;
	Thu, 30 May 2013 07:39:12 -0700 (PDT)
Received: from [172.29.167.118] ([172.29.167.118])
	by mx.google.com with ESMTPSA id
	tq8sm42249391pbc.30.2013.05.30.07.39.11 for <multiple recipients>
	(version=SSLv3 cipher=RC4-SHA bits=128/128);
	Thu, 30 May 2013 07:39:12 -0700 (PDT)
Message-ID: <1369924750.5109.91.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jesper Dangaard Brouer <jbrouer@redhat.com>
Date: Thu, 30 May 2013 07:39:10 -0700
In-Reply-To: <20130530095117.503eeee7@redhat.com>
References: <20130529151330.22c5c89e@redhat.com>
	<1369842724.5109.44.camel@edumazet-glaptop>
	<20130530095117.503eeee7@redhat.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Cc: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@toke.dk>,
	Mike Frysinger <vapier@gentoo.org>, Jiri Benc <jbenc@redhat.com>,
	Jiri Pirko <jpirko@redhat.com>, netdev@vger.kernel.org,
	bloat@lists.bufferbloat.net, Patrick McHardy <kaber@trash.net>,
	Steven Barth <cyrus@openwrt.org>, David Miller <davem@redhat.com>,
	Jussi Kivilinna <jussi.kivilinna@mbnet.fi>,
	Felix Fietkau <nbd@nbd.name>, Michal Soltys <soltys@ziu.info>
Subject: Re: [Bloat] tc linklayer ADSL calc broken after commit 56b765b79
 (htb: improved accuracy at high rates)
X-BeenThere: bloat@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: General list for discussing Bufferbloat <bloat.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/bloat>,
	<mailto:bloat-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/bloat>
List-Post: <mailto:bloat@lists.bufferbloat.net>
List-Help: <mailto:bloat-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/bloat>,
	<mailto:bloat-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Thu, 30 May 2013 14:39:14 -0000

On Thu, 2013-05-30 at 09:51 +0200, Jesper Dangaard Brouer wrote:
> On Wed, 29 May 2013 08:52:04 -0700
> Eric Dumazet <eric.dumazet@gmail.com> wrote:

> > I am not sure it will solve the ATM logic (with the 5 bytes overhead
> > per 48 bytes cell)
> 
> Are you talking about, that for GSO frames we are not adding a encap
> overhead to each "sub" skb.

This part is now done properly in qdisc_pkt_len_init() since linux-3.9


No I was really mentioning the DIV_ROUND_UP(pkt_len,48)*53 thing