From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-x22c.google.com (mail-pb0-x22c.google.com [IPv6:2607:f8b0:400e:c01::22c]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 9898F21F1BE for ; Tue, 4 Jun 2013 09:02:10 -0700 (PDT) Received: by mail-pb0-f44.google.com with SMTP id wz12so449222pbc.3 for ; Tue, 04 Jun 2013 09:02:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-type:x-mailer:content-transfer-encoding:mime-version; bh=8qPjWHSATsQv41Hf/wIEBo0ZYi0HTFLmMN7KYR8sHH0=; b=0Jx21KHNtDuWk4CzoldAu3VtqDvkB0XnAgyUp9eS8DQQnFxgUTBmW4aXad7v7DBLfN iy7l0E+6A5iGrw1hX/7kYep79lH6eNoBm5bjesiJ+Ert50o9gqDSRdg0WjW/xBZOBgBO z/2S6DgQAXyzmL9j/wtzby0J5R557CsSlpbKoA5+rXGO9l+Y4xFYcylbrf3wu6Fkl8zz zESyggIUtGg7XK61ctYcEcJk4+AVlg+JYd2/vnBxxSf9VCUxujTYFjjS90wzvZHYOmG4 jWQKV/HuHd8LM61r4LJPLLzmrRC7tPiGQG9FudE0Efy5eZ3tcIqcShjLPbBI8/69KSBk ACsQ== X-Received: by 10.68.0.66 with SMTP id 2mr29393338pbc.15.1370361730201; Tue, 04 Jun 2013 09:02:10 -0700 (PDT) Received: from [172.26.49.73] ([172.26.49.73]) by mx.google.com with ESMTPSA id ve6sm27174417pbc.21.2013.06.04.09.02.07 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Tue, 04 Jun 2013 09:02:09 -0700 (PDT) Message-ID: <1370361727.24311.215.camel@edumazet-glaptop> From: Eric Dumazet To: Jesper Dangaard Brouer Date: Tue, 04 Jun 2013 09:02:07 -0700 In-Reply-To: <1370361306.24311.214.camel@edumazet-glaptop> References: <20130529151330.22c5c89e@redhat.com> <20130604141342.00c8eb9f@redhat.com> <1370359133.24311.208.camel@edumazet-glaptop> <1370361306.24311.214.camel@edumazet-glaptop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Cc: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , Mike Frysinger , Jiri Pirko , netdev@vger.kernel.org, Jiri Benc , Patrick McHardy , Steven Barth , bloat@lists.bufferbloat.net, David Miller , Jussi Kivilinna , Felix Fietkau , Michal Soltys Subject: Re: [Bloat] Bad shaping at low rates, after commit 56b765b79 (htb: improved accuracy at high rates) X-BeenThere: bloat@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: General list for discussing Bufferbloat List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jun 2013 16:02:10 -0000 On Tue, 2013-06-04 at 08:55 -0700, Eric Dumazet wrote: > On Tue, 2013-06-04 at 08:18 -0700, Eric Dumazet wrote: > > > I have a good idea of what's going on for htb at low rates, I am testing > > a fix, thanks for the report ! > > > > Yes, we need to convert whole thing to use ns units, instead > of a mix of 64ns and 1ns units. > > Please test the following patch : Oh well, it works only on 64bit arches. I'll send a more complete patch, but thats the idea