From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-x231.google.com (mail-ob0-x231.google.com [IPv6:2607:f8b0:4003:c01::231]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 913B221F1AD for ; Tue, 4 Jun 2013 13:50:35 -0700 (PDT) Received: by mail-ob0-f177.google.com with SMTP id ta17so1284785obb.36 for ; Tue, 04 Jun 2013 13:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-type:x-mailer:content-transfer-encoding:mime-version; bh=M7pbRB944r37ESddT5p0I8ojuLtRCNLIEDzen2IkdVY=; b=qiQCTG4ZMxkk1gHsfF+p6dKHd9/C4Wh+fearyNe2XLCN5FM8aElIYwTvtAtiHT42bc ynA1ib9wexNIzLrD9TNP3v1vVXZ7QvYymQFKIXGMjXqfXiAdQwpvKueuqRiJGzcN1auH g718JTtXHPm7I5W/96rAaNaHRrt2Oo2rIHN72WLwUwNKuo40IfFT45aMRAXg1Y33cQEY x0Iw/6Ee6Evdr7TqYZHUfSGFZ6+ktuHuM9l9V66q00ZaeZlvCTOM31S0bBcSNbkmFZkD X2jRTYxVGdhr16St4uJw/SLY0GrUVKjo4M53gtJFFo9DRylCl2SVtRCuzKZFkJFGU3HO yBPA== X-Received: by 10.60.174.111 with SMTP id br15mr4666864oec.130.1370379034804; Tue, 04 Jun 2013 13:50:34 -0700 (PDT) Received: from ?IPv6:2620:0:1000:3304:24dc:da34:eed0:64b6? ([2620:0:1000:3304:24dc:da34:eed0:64b6]) by mx.google.com with ESMTPSA id jt1sm51489635oeb.5.2013.06.04.13.50.32 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Tue, 04 Jun 2013 13:50:33 -0700 (PDT) Message-ID: <1370379031.24311.226.camel@edumazet-glaptop> From: Eric Dumazet To: Jesper Dangaard Brouer Date: Tue, 04 Jun 2013 13:50:31 -0700 In-Reply-To: <20130604222135.67eedab8@redhat.com> References: <20130529151330.22c5c89e@redhat.com> <20130604141342.00c8eb9f@redhat.com> <1370359133.24311.208.camel@edumazet-glaptop> <1370361306.24311.214.camel@edumazet-glaptop> <1370361727.24311.215.camel@edumazet-glaptop> <1370365908.24311.222.camel@edumazet-glaptop> <20130604222135.67eedab8@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Cc: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , Mike Frysinger , Jiri Pirko , netdev@vger.kernel.org, bloat@lists.bufferbloat.net, Jiri Benc , Patrick McHardy , Steven Barth , David Miller , Jussi Kivilinna , Felix Fietkau , Michal Soltys Subject: Re: [Bloat] [PATCH] net_sched: htb: do not mix 1ns and 64ns time units X-BeenThere: bloat@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: General list for discussing Bufferbloat List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jun 2013 20:50:35 -0000 On Tue, 2013-06-04 at 22:21 +0200, Jesper Dangaard Brouer wrote: > But how is this 64-bit usage going to affect performance for smaller > ARM/MIPS based home routers, where shaping at these low rates is more > relevant? (I'm just asking because I don't know, and just test this > on a 24-CPU machine). Well, by definition shaping at low rates is mostly using the timer infra, and its already 64bit. You'll hardly spend time in HTB. Note that psched_time_t is already 64bit wide. Only psched_tdiff_t is 'unsigned long', and the change I made in this patch will not change performance even on 32bit hosts.