From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <shemminger@vyatta.com>
Received: from mail.vyatta.com (mail.vyatta.com [76.74.103.46])
	by huchra.bufferbloat.net (Postfix) with ESMTP id 9DAD520036C;
	Thu,  8 Dec 2011 09:21:33 -0800 (PST)
Received: from localhost (localhost.localdomain [127.0.0.1])
	by mail.vyatta.com (Postfix) with ESMTP id 19F7E141001A;
	Thu,  8 Dec 2011 09:21:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at tahiti.vyatta.com
Received: from mail.vyatta.com ([127.0.0.1])
	by localhost (mail.vyatta.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 7EacqWL8LZIV; Thu,  8 Dec 2011 09:21:32 -0800 (PST)
Received: from nehalam.linuxnetplumber.net
	(static-50-53-80-93.bvtn.or.frontiernet.net [50.53.80.93])
	by mail.vyatta.com (Postfix) with ESMTPSA id EE9C6141000B;
	Thu,  8 Dec 2011 09:21:31 -0800 (PST)
Date: Thu, 8 Dec 2011 09:21:30 -0800
From: Stephen Hemminger <shemminger@vyatta.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Message-ID: <20111208092130.656c39ff@nehalam.linuxnetplumber.net>
In-Reply-To: <1323360363.2521.30.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
References: <CAA93jw7kQYONQiAozatRmdRRJeK0GB9eNDWtRZ3AL+OVKn0OpA@mail.gmail.com>
	<1323082774.2670.40.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
	<1323360363.2521.30.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Organization: Vyatta
X-Mailer: Claws Mail 3.7.10 (GTK+ 2.24.8; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: bloat-devel <bloat-devel@lists.bufferbloat.net>, netdev@vger.kernel.org,
	linux-wireless <linux-wireless@vger.kernel.org>,
	bloat <bloat@lists.bufferbloat.net>, David Miller <davem@davemloft.net>
Subject: Re: [Bloat] [PATCH net-next] sch_red: Adaptative RED AQM
X-BeenThere: bloat@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: General list for discussing Bufferbloat <bloat.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/bloat>,
	<mailto:bloat-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/bloat>
List-Post: <mailto:bloat@lists.bufferbloat.net>
List-Help: <mailto:bloat-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/bloat>,
	<mailto:bloat-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Thu, 08 Dec 2011 17:21:33 -0000

On Thu, 08 Dec 2011 17:06:03 +0100
Eric Dumazet <eric.dumazet@gmail.com> wrote:

> Changes against our RED implementation are :
> 
> max_p is no longer a negative power of two (1/(2^Plog)), but a Q0.32
> fixed point number, to allow full range described in Adatative paper.
> 
> To deliver a random number, we now use a reciprocal divide (thats really
> a multiply), but this operation is done once per marked/droped packet
> when in RED_BETWEEN_TRESH window, so added cost (compared to previous
> AND operation) is near zero.
> 
> dump operation gives current max_p value in a new TCA_RED_MAX_P
> attribute.
> 
> Example on a 10Mbit link :
> 
> tc qdisc add dev $DEV parent 1:1 handle 10: est 1sec 8sec red \
>    limit 400000 min 30000 max 90000 avpkt 1000 \
>    burst 55 ecn adaptative bandwidth 10Mbit
> 
> # tc -s -d qdisc show dev eth3
> ...
> qdisc red 10: parent 1:1 limit 400000b min 30000b max 90000b ecn
> adaptative ewma 5 max_p=0.113335 Scell_log 15
>  Sent 50414282 bytes 34504 pkt (dropped 35, overlimits 1392 requeues 0) 
>  rate 9749Kbit 831pps backlog 72056b 16p requeues 0 
>   marked 1357 early 35 pdrop 0 other 0
> 
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Is this backward compatible for users that don't specify
an adaptive parameter.