From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by huchra.bufferbloat.net (Postfix) with ESMTP id 984DC21F0BD for ; Thu, 30 May 2013 08:56:15 -0700 (PDT) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4UFu8Tc018636 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 30 May 2013 11:56:08 -0400 Received: from localhost (ovpn-116-55.ams2.redhat.com [10.36.116.55]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4UFu19I003404; Thu, 30 May 2013 11:56:02 -0400 Date: Thu, 30 May 2013 17:55:59 +0200 From: Jesper Dangaard Brouer To: Eric Dumazet Message-ID: <20130530175559.7cbb6851@redhat.com> In-Reply-To: <1369924750.5109.91.camel@edumazet-glaptop> References: <20130529151330.22c5c89e@redhat.com> <1369842724.5109.44.camel@edumazet-glaptop> <20130530095117.503eeee7@redhat.com> <1369924750.5109.91.camel@edumazet-glaptop> Organization: Red Hat Inc. Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Cc: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= , Mike Frysinger , Jiri Benc , Jiri Pirko , netdev@vger.kernel.org, bloat@lists.bufferbloat.net, Patrick McHardy , Steven Barth , David Miller , Jussi Kivilinna , Felix Fietkau , Michal Soltys Subject: Re: [Bloat] tc linklayer ADSL calc broken after commit 56b765b79 (htb: improved accuracy at high rates) X-BeenThere: bloat@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: General list for discussing Bufferbloat List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 May 2013 15:56:15 -0000 On Thu, 30 May 2013 07:39:10 -0700 Eric Dumazet wrote: > On Thu, 2013-05-30 at 09:51 +0200, Jesper Dangaard Brouer wrote: > > On Wed, 29 May 2013 08:52:04 -0700 > > Eric Dumazet wrote: > > > > I am not sure it will solve the ATM logic (with the 5 bytes > > > overhead per 48 bytes cell) > > > > Are you talking about, that for GSO frames we are not adding a encap > > overhead to each "sub" skb. > > This part is now done properly in qdisc_pkt_len_init() since linux-3.9 Thanks for the pointer, but qdisc_pkt_len_init() only adds the EthMAC+IP+TCP header size for each GSO segment (stored in qdisc_skb_cb(skb)->pkt_len). It is still missing the AAL5 encapsulation overhead per GSO segment. Besides I can see that __qdisc_calculate_pkt_len() "forgets" this information and overwrites qdisc_skb_cb(skb)->pkt_len (iif a stab is defined on the qdisc). -- Best regards, Jesper Dangaard Brouer MSc.CS, Sr. Network Kernel Developer at Red Hat Author of http://www.iptv-analyzer.org LinkedIn: http://www.linkedin.com/in/brouer