From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: toke@toke.dk, vapier@gentoo.org, jpirko@redhat.com,
netdev@vger.kernel.org, bloat@lists.bufferbloat.net,
jbenc@redhat.com, kaber@trash.net, cyrus@openwrt.org,
jussi.kivilinna@mbnet.fi, nbd@nbd.name, soltys@ziu.info
Subject: Re: [Bloat] [PATCH] net_sched: htb: do not mix 1ns and 64ns time units
Date: Tue, 04 Jun 2013 17:44:39 -0700 (PDT) [thread overview]
Message-ID: <20130604.174439.327058035432515764.davem@davemloft.net> (raw)
In-Reply-To: <1370365908.24311.222.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 04 Jun 2013 10:11:48 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> commit 56b765b79 ("htb: improved accuracy at high rates") added another
> regression for low rates, because it mixes 1ns and 64ns time units.
>
> So the maximum delay (mbuffer) was not 60 second, but 937 ms.
>
> Lets convert all time fields to 1ns as 64bit arches are becoming the
> norm.
>
> Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable, thanks.
next prev parent reply other threads:[~2013-06-05 0:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 13:13 [Bloat] tc linklayer ADSL calc broken after commit 56b765b79 (htb: improved accuracy at high rates) Jesper Dangaard Brouer
2013-05-29 15:52 ` Eric Dumazet
2013-05-29 22:50 ` Stephen Hemminger
2013-05-29 23:18 ` Eric Dumazet
2013-05-30 9:15 ` Jesper Dangaard Brouer
2013-05-30 9:52 ` Steinar H. Gunderson
2013-05-30 0:34 ` Dave Taht
2013-05-30 8:09 ` Jesper Dangaard Brouer
2013-05-30 7:51 ` Jesper Dangaard Brouer
2013-05-30 14:39 ` Eric Dumazet
2013-05-30 15:55 ` Jesper Dangaard Brouer
2013-06-02 21:15 ` Eric Dumazet
2013-06-04 12:13 ` [Bloat] Bad shaping at low rates, " Jesper Dangaard Brouer
2013-06-04 15:18 ` Eric Dumazet
2013-06-04 15:55 ` Eric Dumazet
2013-06-04 16:02 ` Eric Dumazet
2013-06-04 17:11 ` [Bloat] [PATCH] net_sched: htb: do not mix 1ns and 64ns time units Eric Dumazet
2013-06-04 20:21 ` Jesper Dangaard Brouer
2013-06-04 20:26 ` Dave Taht
2013-06-04 21:02 ` Eric Dumazet
2013-06-04 20:50 ` Eric Dumazet
2013-06-05 0:44 ` David Miller [this message]
2013-06-06 13:55 ` [Bloat] RFC: Proposed fix for tc linklayer calc broken after commit 56b765b79 (htb: improved accuracy at high rates) Jesper Dangaard Brouer
2013-06-06 14:28 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/bloat.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604.174439.327058035432515764.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bloat@lists.bufferbloat.net \
--cc=cyrus@openwrt.org \
--cc=eric.dumazet@gmail.com \
--cc=jbenc@redhat.com \
--cc=jpirko@redhat.com \
--cc=jussi.kivilinna@mbnet.fi \
--cc=kaber@trash.net \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=soltys@ziu.info \
--cc=toke@toke.dk \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox