From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <davem@davemloft.net>
Received: from shards.monkeyblade.net (unknown
	[IPv6:2001:4f8:3:36:211:85ff:fe63:a549])
	by huchra.bufferbloat.net (Postfix) with ESMTP id 9709621F1B5
	for <bloat@lists.bufferbloat.net>; Tue,  4 Jun 2013 17:44:40 -0700 (PDT)
Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net
	[74.93.104.98]) (Authenticated sender: davem-davemloft)
	by shards.monkeyblade.net (Postfix) with ESMTPSA id 66220584336;
	Tue,  4 Jun 2013 17:44:39 -0700 (PDT)
Date: Tue, 04 Jun 2013 17:44:39 -0700 (PDT)
Message-Id: <20130604.174439.327058035432515764.davem@davemloft.net>
To: eric.dumazet@gmail.com
From: David Miller <davem@davemloft.net>
In-Reply-To: <1370365908.24311.222.camel@edumazet-glaptop>
References: <1370361306.24311.214.camel@edumazet-glaptop>
	<1370361727.24311.215.camel@edumazet-glaptop>
	<1370365908.24311.222.camel@edumazet-glaptop>
X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: toke@toke.dk, vapier@gentoo.org, jpirko@redhat.com, netdev@vger.kernel.org,
	bloat@lists.bufferbloat.net, jbenc@redhat.com, kaber@trash.net,
	cyrus@openwrt.org, jussi.kivilinna@mbnet.fi, nbd@nbd.name, soltys@ziu.info
Subject: Re: [Bloat] [PATCH] net_sched: htb: do not mix 1ns and 64ns time
	units
X-BeenThere: bloat@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: General list for discussing Bufferbloat <bloat.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/bloat>,
	<mailto:bloat-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/bloat>
List-Post: <mailto:bloat@lists.bufferbloat.net>
List-Help: <mailto:bloat-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/bloat>,
	<mailto:bloat-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Wed, 05 Jun 2013 00:44:40 -0000

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 04 Jun 2013 10:11:48 -0700

> From: Eric Dumazet <edumazet@google.com>
> 
> commit 56b765b79 ("htb: improved accuracy at high rates") added another
> regression for low rates, because it mixes 1ns and 64ns time units.
> 
> So the maximum delay (mbuffer) was not 60 second, but 937 ms.
> 
> Lets convert all time fields to 1ns as 64bit arches are becoming the
> norm.
> 
> Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied and queued up for -stable, thanks.