* [Bloat] ECN support for PIE AQM in Linux @ 2013-08-14 14:05 Naeem Khademi 2013-08-14 18:27 ` [Bloat] [iccrg] " Vijay Subramanian 0 siblings, 1 reply; 6+ messages in thread From: Naeem Khademi @ 2013-08-14 14:05 UTC (permalink / raw) To: aqm, iccrg, bloat [-- Attachment #1: Type: text/plain, Size: 404 bytes --] Hi The already-existing PIE Linux code maintained at ftp://ftpeng.cisco.com/pie/ does not support ECN. Studying the interaction of ECN and AQM algos is probably of interest of some of us. I have added ECN support to PIE Linux code and have given it some basic sanity tests. The modified code is available at http://heim.ifi.uio.no/naeemk/research/PIE/ I would appreciate any feedback. Regards, Naeem [-- Attachment #2: Type: text/html, Size: 729 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Bloat] [iccrg] ECN support for PIE AQM in Linux 2013-08-14 14:05 [Bloat] ECN support for PIE AQM in Linux Naeem Khademi @ 2013-08-14 18:27 ` Vijay Subramanian 2013-08-14 21:17 ` Naeem Khademi 0 siblings, 1 reply; 6+ messages in thread From: Vijay Subramanian @ 2013-08-14 18:27 UTC (permalink / raw) To: Naeem Khademi; +Cc: iccrg, aqm, bloat [-- Attachment #1: Type: text/plain, Size: 985 bytes --] Naeem, Thanks for testing and the contribution! We have ECN support in our current code-under-development thanks to earlier help from Dave Taht but I will merge your changes as appropriate and submit it back for review. I will take a look at your code soon. Do you also have any test results which you can share? Thanks again, Vijay On 14 August 2013 07:05, Naeem Khademi <naeem.khademi@gmail.com> wrote: > Hi > > The already-existing PIE Linux code maintained at > ftp://ftpeng.cisco.com/pie/ does not support ECN. Studying the > interaction of ECN and AQM algos is probably of interest of some of us. I > have added ECN support to PIE Linux code and have given it some basic > sanity tests. > > The modified code is available at > http://heim.ifi.uio.no/naeemk/research/PIE/ > > I would appreciate any feedback. > > Regards, > Naeem > > > > _______________________________________________ > iccrg mailing list > iccrg@irtf.org > https://www.irtf.org/mailman/listinfo/iccrg > > [-- Attachment #2: Type: text/html, Size: 1781 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Bloat] [iccrg] ECN support for PIE AQM in Linux 2013-08-14 18:27 ` [Bloat] [iccrg] " Vijay Subramanian @ 2013-08-14 21:17 ` Naeem Khademi 2013-08-15 0:41 ` Dave Taht 0 siblings, 1 reply; 6+ messages in thread From: Naeem Khademi @ 2013-08-14 21:17 UTC (permalink / raw) To: Vijay Subramanian; +Cc: iccrg, aqm, bloat Hi Vijay This code implements basic ECN capability for PIE meaning that it would CE-mark packets that would be early-dropped otherwise. I have sanity-checked the code (e.g. successful ECN marking and receiver/sender reaction). We're now in process of conducting larger set of experiments with PIE w/wo ECN that will eventually be published as we move forward. Cheers, Naeem On Wed, Aug 14, 2013 at 8:27 PM, Vijay Subramanian <subramanian.vijay@gmail.com> wrote: > Naeem, > > Thanks for testing and the contribution! We have ECN support in our current > code-under-development thanks to earlier help from Dave Taht but I will > merge your changes as appropriate and > submit it back for review. > > I will take a look at your code soon. Do you also have any test results > which you can share? > > Thanks again, > Vijay > > > On 14 August 2013 07:05, Naeem Khademi <naeem.khademi@gmail.com> wrote: >> >> Hi >> >> The already-existing PIE Linux code maintained at >> ftp://ftpeng.cisco.com/pie/ does not support ECN. Studying the interaction >> of ECN and AQM algos is probably of interest of some of us. I have added ECN >> support to PIE Linux code and have given it some basic sanity tests. >> >> The modified code is available at >> http://heim.ifi.uio.no/naeemk/research/PIE/ >> >> I would appreciate any feedback. >> >> Regards, >> Naeem >> >> >> >> _______________________________________________ >> iccrg mailing list >> iccrg@irtf.org >> https://www.irtf.org/mailman/listinfo/iccrg >> > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Bloat] [iccrg] ECN support for PIE AQM in Linux 2013-08-14 21:17 ` Naeem Khademi @ 2013-08-15 0:41 ` Dave Taht 2013-08-15 1:25 ` [Bloat] [aqm] " Eggert, Lars 2013-08-15 5:05 ` [Bloat] " Vijay Subramanian 0 siblings, 2 replies; 6+ messages in thread From: Dave Taht @ 2013-08-15 0:41 UTC (permalink / raw) To: Naeem Khademi; +Cc: iccrg, aqm, bloat [-- Attachment #1: Type: text/plain, Size: 3456 bytes --] The pie patches that I was using until recently are here: http://snapon.lab.bufferbloat.net/~cero2/deb/patches/ Stephen hemminger and I cleaned up the original pie drop according to KernelStyle in multiple ways. There is a rounding error problem in setting the target value (we'd recomended they switch to ktime rather than jiffies) that I either added or was in there in the first place.... and we fixed a couple generic bugs... In addition to adding ecn support, we also added congestion notification to (a la the linux red and fq_codel algorithms) to provide lossless feedback into the host tcp stack. (this is, incidentally, 1 line of code) This optimization made it possible to do comparisons on host <-> host tests between these qdiscs, with no router in-between. Syntactically the iproute2 patches could use identical syntax for time based values as the codel iproute2 patches. Haven't got around to that. (not my job, really, to improve cisco's code) Now, I only now - today! - just noticed that the new pie code at cisco's site seems *substantially* different from the older pie code the above was based on, in that it no longer has an optimization for not dropping smaller packets. (bytemode) This is going to invalidate most previous benchmarks of pie that I know of, including all of mine, and most, if not all, of cablelabs'. Sigh. I will try to refresh my patches and update the lab over the next week or so. On Wed, Aug 14, 2013 at 2:17 PM, Naeem Khademi <naeem.khademi@gmail.com>wrote: > Hi Vijay > > This code implements basic ECN capability for PIE meaning that it > would CE-mark packets that would be early-dropped otherwise. I have > sanity-checked the code (e.g. successful ECN marking and > receiver/sender reaction). We're now in process of conducting larger > set of experiments with PIE w/wo ECN that will eventually be published > as we move forward. > > Cheers, > Naeem > > On Wed, Aug 14, 2013 at 8:27 PM, Vijay Subramanian > <subramanian.vijay@gmail.com> wrote: > > Naeem, > > > > Thanks for testing and the contribution! We have ECN support in our > current > > code-under-development thanks to earlier help from Dave Taht but I will > > merge your changes as appropriate and > > submit it back for review. > > > > I will take a look at your code soon. Do you also have any test results > > which you can share? > > > > Thanks again, > > Vijay > > > > > > On 14 August 2013 07:05, Naeem Khademi <naeem.khademi@gmail.com> wrote: > >> > >> Hi > >> > >> The already-existing PIE Linux code maintained at > >> ftp://ftpeng.cisco.com/pie/ does not support ECN. Studying the > interaction > >> of ECN and AQM algos is probably of interest of some of us. I have > added ECN > >> support to PIE Linux code and have given it some basic sanity tests. > >> > >> The modified code is available at > >> http://heim.ifi.uio.no/naeemk/research/PIE/ > >> > >> I would appreciate any feedback. > >> > >> Regards, > >> Naeem > >> > >> > >> > >> _______________________________________________ > >> iccrg mailing list > >> iccrg@irtf.org > >> https://www.irtf.org/mailman/listinfo/iccrg > >> > > > _______________________________________________ > iccrg mailing list > iccrg@irtf.org > https://www.irtf.org/mailman/listinfo/iccrg > -- Dave Täht Fixing bufferbloat with cerowrt: http://www.teklibre.com/cerowrt/subscribe.html [-- Attachment #2: Type: text/html, Size: 4862 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Bloat] [aqm] [iccrg] ECN support for PIE AQM in Linux 2013-08-15 0:41 ` Dave Taht @ 2013-08-15 1:25 ` Eggert, Lars 2013-08-15 5:05 ` [Bloat] " Vijay Subramanian 1 sibling, 0 replies; 6+ messages in thread From: Eggert, Lars @ 2013-08-15 1:25 UTC (permalink / raw) To: Dave Taht; +Cc: bloat, iccrg, aqm [-- Attachment #1: Type: text/plain, Size: 374 bytes --] On Aug 15, 2013, at 8:41, Dave Taht <dave.taht@gmail.com> wrote: > Now, I only now - today! - just noticed that the new pie code at cisco's > site seems *substantially* different from the older pie code the above was > based on I guess the lesson is that these code drops need version numbers, and we need to REPORT the versions whenever we present results. Lars [-- Attachment #2: Message signed with OpenPGP using GPGMail --] [-- Type: application/pgp-signature, Size: 313 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Bloat] [iccrg] ECN support for PIE AQM in Linux 2013-08-15 0:41 ` Dave Taht 2013-08-15 1:25 ` [Bloat] [aqm] " Eggert, Lars @ 2013-08-15 5:05 ` Vijay Subramanian 1 sibling, 0 replies; 6+ messages in thread From: Vijay Subramanian @ 2013-08-15 5:05 UTC (permalink / raw) To: Dave Taht; +Cc: iccrg, bloat, aqm [-- Attachment #1: Type: text/plain, Size: 1064 bytes --] On 14 August 2013 17:41, Dave Taht <dave.taht@gmail.com> wrote: > The pie patches that I was using until recently are here: > > http://snapon.lab.bufferbloat.net/~cero2/deb/patches/ > > Stephen hemminger and I cleaned up the original pie drop according to > KernelStyle in multiple ways. There is a rounding error problem in setting > the target value > (we'd recomended they switch to ktime rather than jiffies) that I either > added or was in there in the first place.... and we fixed a couple generic > bugs... > > > Dave, Thanks to you and Stephen for this cleanup. I have these changes in my queue. I had also promised Stephen that I would upstream the code to the linux networking list for review and inclusion and this is what I intend to do in the coming days. The idea was that once bufferbloat community has vetted the algorithm, we can make the needed implementation and style changes for kernel submission. I believe it is now time to submit it to the netdev list. i will merge the collective feedback received so far and send it out. Thanks, Vijay [-- Attachment #2: Type: text/html, Size: 1637 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-15 5:05 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-08-14 14:05 [Bloat] ECN support for PIE AQM in Linux Naeem Khademi 2013-08-14 18:27 ` [Bloat] [iccrg] " Vijay Subramanian 2013-08-14 21:17 ` Naeem Khademi 2013-08-15 0:41 ` Dave Taht 2013-08-15 1:25 ` [Bloat] [aqm] " Eggert, Lars 2013-08-15 5:05 ` [Bloat] " Vijay Subramanian
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox