From: "David Täht" <dave.taht@gmail.com>
To: bloat@lists.bufferbloat.net, sgunderson@bigfoot.com
Subject: Re: [Bloat] a flood of Bufferbloat-related papers
Date: Tue, 11 Oct 2011 14:17:01 +0200 [thread overview]
Message-ID: <4E9433BD.3000102@gmail.com> (raw)
In-Reply-To: <20111011115816.GA24956@uio.no>
[-- Attachment #1.1: Type: text/plain, Size: 1295 bytes --]
On Tue, Oct 11, 2011 at 12:27:17PM +0200, David Täht wrote:
> > On my list already would be "an analysis of the effects of broken sack
> > processing on linux 2.4.24-3.1", of which I *think* I've captured
> > multiple examples of in the raw traces I've been collecting for
> > months... (so if anyone is interested in the raw data, I can provide)
Do you have any more information? The only thing I could find online was that
there were SACK issues that were supposed to be fixed by 2.6.16; nothing
about a fix in 3.1 or post-3.1.
This was a typo on my part - 2.6.24-3.1, not 2.4
The specific commit that concerned me was this one. I had seen multiple
cases of odd behavior (basically tcp sacking like crazy until the cwr
collapses or a tcp reset) that I *think* this fix explains.
commit f779b2d60ab95c17f1e025778ed0df3ec2f05d75
Author: Zheng Yan <zheng.z.yan@intel.com>
Date: Sun Sep 18 22:37:34 2011 -0400
tcp: fix validation of D-SACK
D-SACK is allowed to reside below snd_una. But the corresponding check
in tcp_is_sackblock_valid() is the exact opposite. It looks like a typo.
Signed-off-by: Zheng Yan <zheng.z.yan@intel.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
--
Dave Täht
[-- Attachment #1.2: Type: text/html, Size: 2502 bytes --]
[-- Attachment #2: dave_taht.vcf --]
[-- Type: text/x-vcard, Size: 214 bytes --]
begin:vcard
fn;quoted-printable:Dave T=C3=A4ht
n;quoted-printable:T=C3=A4ht;Dave
email;internet:dave.taht@gmail.com
tel;home:1-239-829-5608
tel;cell:0638645374
x-mozilla-html:FALSE
version:2.1
end:vcard
next prev parent reply other threads:[~2011-10-11 12:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 10:27 David Täht
2011-10-11 11:58 ` Steinar H. Gunderson
2011-10-11 12:13 ` Eric Dumazet
2011-10-11 12:18 ` Eric Dumazet
2011-10-11 13:09 ` [Bloat] the observed sack oddity David Täht
2011-10-11 13:11 ` David Täht
2011-10-11 13:33 ` Eric Dumazet
2011-10-11 13:51 ` David Täht
2011-10-11 15:25 ` Justin McCann
2011-10-11 15:37 ` Justin McCann
2011-10-13 18:23 ` Jan Ceuleers
2011-10-13 18:27 ` Eric Dumazet
2011-10-11 12:40 ` [Bloat] a flood of Bufferbloat-related papers David Täht
2011-10-11 12:17 ` David Täht [this message]
2011-10-12 7:49 ` Lawrence Stewart
2011-10-12 8:03 ` David Täht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/bloat.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9433BD.3000102@gmail.com \
--to=dave.taht@gmail.com \
--cc=bloat@lists.bufferbloat.net \
--cc=sgunderson@bigfoot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox