From: Eric Dumazet <eric.dumazet@gmail.com>
To: bloat@lists.bufferbloat.net
Subject: Re: [Bloat] lwn.net's tcp small queues vs wifi aggregation solved
Date: Thu, 21 Jun 2018 05:55:45 -0700 [thread overview]
Message-ID: <838b212e-7a8c-6139-1306-9e60bfda926b@gmail.com> (raw)
In-Reply-To: <8736xgsdcp.fsf@toke.dk>
On 06/21/2018 02:22 AM, Toke Høiland-Jørgensen wrote:
> Dave Taht <dave.taht@gmail.com> writes:
>
>> Nice war story. I'm glad this last problem with the fq_codel wifi code
>> is solved
>
> This wasn't specific to the fq_codel wifi code, but hit all WiFi devices
> that were running TCP on the local stack. Which would be mostly laptops,
> I guess...
Yes.
Also switching TCP stack to always GSO has been a major gain for wifi in my tests.
(TSQ budget is based on sk_wmem_alloc, tracking truesize of skbs, and not having
GSO is considerably inflating the truesize/payload ratio)
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0a6b2a1dc2a2105f178255fe495eb914b09cb37a
tcp: switch to GSO being always on
I expect SACK compression to also give a nice boost to wifi.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5d9f4262b7ea41ca9981cc790e37cca6e37c789e
tcp: add SACK compression
Lastly I am working on adding ACK compression in TCP stack itself.
next prev parent reply other threads:[~2018-06-21 12:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 4:58 Dave Taht
2018-06-21 9:22 ` Toke Høiland-Jørgensen
2018-06-21 12:55 ` Eric Dumazet [this message]
2018-06-21 15:18 ` Dave Taht
2018-06-21 15:31 ` Caleb Cushing
2018-06-21 15:46 ` Stephen Hemminger
2018-06-21 17:41 ` Caleb Cushing
2018-06-21 15:50 ` Dave Taht
2018-06-21 16:29 ` David Collier-Brown
2018-06-21 16:54 ` Jonathan Morton
2018-06-21 16:43 ` Kathleen Nichols
2018-06-21 19:17 ` Dave Taht
2018-06-21 19:41 ` Sebastian Moeller
2018-06-21 19:51 ` Toke Høiland-Jørgensen
2018-06-21 19:54 ` Dave Taht
2018-06-21 20:11 ` Sebastian Moeller
2018-06-22 14:01 ` Kathleen Nichols
2018-06-22 14:12 ` Jonathan Morton
2018-06-22 14:49 ` Michael Richardson
2018-06-22 15:02 ` Jonathan Morton
2018-06-22 21:55 ` Michael Richardson
2018-06-25 10:38 ` Toke Høiland-Jørgensen
2018-06-25 23:54 ` Jim Gettys
2018-06-26 0:07 ` Jonathan Morton
2018-06-26 0:21 ` David Lang
2018-06-26 0:36 ` Simon Barber
2018-06-26 0:44 ` Jonathan Morton
2018-06-26 0:52 ` Jim Gettys
2018-06-26 0:56 ` David Lang
2018-06-26 11:16 ` Toke Høiland-Jørgensen
2018-06-26 1:27 ` Dave Taht
2018-06-26 3:30 ` Simon Barber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/bloat.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838b212e-7a8c-6139-1306-9e60bfda926b@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=bloat@lists.bufferbloat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox