From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-x244.google.com (mail-pl0-x244.google.com [IPv6:2607:f8b0:400e:c01::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id CDFC33B2A4 for ; Thu, 21 Jun 2018 08:55:48 -0400 (EDT) Received: by mail-pl0-x244.google.com with SMTP id 30-v6so1645619pld.13 for ; Thu, 21 Jun 2018 05:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=UJoes0EszjqoDhEQRO+Z7PzIeUVIfm6g+nPMlBVLWHw=; b=u0SJenaL0JVnH53YPhKnvSgYCoodITUuJvCyhz/fTM9Djgtms6dWWM7e+kHSP3kCSS BQriWqvBY0HVVUSNS7EdXLCvIcMH1cqLvXz4UTJZHzEllElL7aG8XbeMWrg6e5KY2gIN xRoJ0GHnIWPZgqD0T54jdSGz9JgWQH7V3OVcq5EpmX8dUXIBHHrPpZJq0iW2HA8KH3qk U3oJe7ROvmLn53TQOmu7SnQMIHU9o+Nhu4w+qFe8swoUVZr59wqxB626WubKnFGL6tMB FPeP6/64I7YlB5RaVgAcyMpEwomsvg+uQk0cauQ9THn1NER/3wIPpxhZuc0/kXibmOKX w3yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UJoes0EszjqoDhEQRO+Z7PzIeUVIfm6g+nPMlBVLWHw=; b=GVLPj3PDmmf+NzQgmwG/hOVmIacPcoPia+xDwOSh5Ej2aOsBQFCp7oe3LaxZFtjulN weJBV3NPbU4ZCnyOxcSLoabfjh3xrZKaq1EpsmlUNWJUmQaejJS1NBZwaeQ/Y9R25FUK CB20cDX6Ic9Apu4E8oqOrawEesatkiRY8tLA2YHuFFjziHleR0d25QFZ4BcYkcNBxwh8 57FWyxkL/G5pb35e6Fdl3WlZ0peOLwp8irfyO8jEaURVrvE0QVAJywB82DjYYlWzW1Fw OkEi1L+wKUUI6UEhcVSzjK+c7Zt/wY3ysJ3H0Xh0vgi8sqQYkKiPgnmYw18h+lckRgvn gaog== X-Gm-Message-State: APt69E0JRcZe6Voin3zlBoxfv8aAvl/HSwibmaMpL34g8KFNtJZaB64K LacZnMmdCEWq/GsC5x1NFvQolcBZ X-Google-Smtp-Source: ADUXVKIJBx4ktb50K3C72jYvL8qXMTBp2YfBcJX/zab2CgUK6JVtNZqVlKa4fBA+mC39o7/+FI61Zg== X-Received: by 2002:a17:902:2864:: with SMTP id e91-v6mr27789690plb.240.1529585747870; Thu, 21 Jun 2018 05:55:47 -0700 (PDT) Received: from [192.168.86.235] (c-67-180-167-114.hsd1.ca.comcast.net. [67.180.167.114]) by smtp.gmail.com with ESMTPSA id m5-v6sm6344567pgn.45.2018.06.21.05.55.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jun 2018 05:55:46 -0700 (PDT) To: bloat@lists.bufferbloat.net References: <8736xgsdcp.fsf@toke.dk> From: Eric Dumazet Message-ID: <838b212e-7a8c-6139-1306-9e60bfda926b@gmail.com> Date: Thu, 21 Jun 2018 05:55:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <8736xgsdcp.fsf@toke.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Bloat] lwn.net's tcp small queues vs wifi aggregation solved X-BeenThere: bloat@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: General list for discussing Bufferbloat List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 12:55:49 -0000 On 06/21/2018 02:22 AM, Toke Høiland-Jørgensen wrote: > Dave Taht writes: > >> Nice war story. I'm glad this last problem with the fq_codel wifi code >> is solved > > This wasn't specific to the fq_codel wifi code, but hit all WiFi devices > that were running TCP on the local stack. Which would be mostly laptops, > I guess... Yes. Also switching TCP stack to always GSO has been a major gain for wifi in my tests. (TSQ budget is based on sk_wmem_alloc, tracking truesize of skbs, and not having GSO is considerably inflating the truesize/payload ratio) https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0a6b2a1dc2a2105f178255fe495eb914b09cb37a tcp: switch to GSO being always on I expect SACK compression to also give a nice boost to wifi. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5d9f4262b7ea41ca9981cc790e37cca6e37c789e tcp: add SACK compression Lastly I am working on adding ACK compression in TCP stack itself.