[Bloat] Adding CAKE "tc qdisc" options to NetworkManager

[Bloat] Adding CAKE "tc qdisc" options to NetworkManager

[David Collier-Brown]

[-- Attachment #1.1: Type: text/plain, Size: 1486 bytes --]

By pure luck, I ended up chatting with one of the NetworkManager chaps, 
who invited a merge request with the proper parameters for CAKE.

He wrote

Currently NM doesn't support configuring CAKE parameters. IOW, if you
set "root cake bandwidth 100Mbit", you will see in the tc output that
cake was set but with default parameters.

Yes, I think it will be useful to have CAKE support in NM, but I can't
say when it will be implemented. Of course, patches are always
welcome; if anybody is interested in contributing it, please have a
look at the work that was done to support SFQ:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b22b4f9101b1cbfde49b65d9e2107e4ae0d817c0

Sounds like a good job for next weekend, can I get some reviewers for 
the week after?

--dave


-------- Forwarded Message --------
Subject: 	Re: New "tc qdisc" options
Date: 	Mon, 5 Oct 2020 17:56:44 +0200
From: 	Beniamino Galvani <bgalvani@redhat.com>
To: 	Dave Collier-Brown <dave.collier-brown@indexexchange.com>
CC: 	Thomas Haller <thaller@redhat.com>, davecb@spamcop.net 
<davecb@spamcop.net>, NetworkManager-list@gnome.org



On Mon, Oct 05, 2020 at 11:52:32AM -0400, Dave Collier-Brown wrote:
> I can absolutely propose a patch/MR based on that example, but I'm
> fallible (;-))
>
> Do you prefer an MR in github or a git-format-patch via email?

A MR on gitlab is the preferred way:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests

Thanks,
Beniamino


[-- Attachment #1.2: Type: text/html, Size: 3836 bytes --]

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 834 bytes --]

Re: [Bloat] Adding CAKE "tc qdisc" options to NetworkManager

[Jonathan Morton]

> On 5 Oct, 2020, at 7:13 pm, David Collier-Brown <davecb.42@gmail.com> wrote:
> 
> By pure luck, I ended up chatting with one of the NetworkManager chaps, who invited a merge request with the proper parameters for CAKE.
> 
> He wrote
> 
> Currently NM doesn't support configuring CAKE parameters. IOW, if you
> set "root cake bandwidth 100Mbit", you will see in the tc output that
> cake was set but with default parameters.
> 
> Yes, I think it will be useful to have CAKE support in NM, but I can't
> say when it will be implemented. Of course, patches are always
> welcome; if anybody is interested in contributing it, please have a
> look at the work that was done to support SFQ:
> 
> https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b22b4f9101b1cbfde49b65d9e2107e4ae0d817c0
> 
> Sounds like a good job for next weekend, can I get some reviewers for the week after?

I could probably at least glance at it.  How easy is it to set this up in, say, Linux Mint?

 - Jonathan Morton

Re: [Bloat] Adding CAKE "tc qdisc" options to NetworkManager

[Dave Collier-Brown]

[-- Attachment #1: Type: text/plain, Size: 2536 bytes --]

This appears to be adding a tree of static data structures so nmcli can understand what the options are, including what the defaults are.

If so, I can probably stop it after the command parser runs, and not have a huge build-and-test-everything task.

--dave

On 2020-10-05 1:33 p.m., Jonathan Morton wrote:

On 5 Oct, 2020, at 7:13 pm, David Collier-Brown <davecb.42@gmail.com><mailto:davecb.42@gmail.com> wrote:

By pure luck, I ended up chatting with one of the NetworkManager chaps, who invited a merge request with the proper parameters for CAKE.

He wrote

Currently NM doesn't support configuring CAKE parameters. IOW, if you
set "root cake bandwidth 100Mbit", you will see in the tc output that
cake was set but with default parameters.

Yes, I think it will be useful to have CAKE support in NM, but I can't
say when it will be implemented. Of course, patches are always
welcome; if anybody is interested in contributing it, please have a
look at the work that was done to support SFQ:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b22b4f9101b1cbfde49b65d9e2107e4ae0d817c0

Sounds like a good job for next weekend, can I get some reviewers for the week after?



I could probably at least glance at it.  How easy is it to set this up in, say, Linux Mint?

 - Jonathan Morton

--
David Collier-Brown,         | Always do right. This will gratify
System Programmer and Author | some people and astonish the rest
dave.collier-brown@indexexchange.com<mailto:dave.collier-brown@indexexchange.com> |              -- Mark Twain



CONFIDENTIALITY NOTICE AND DISCLAIMER : This telecommunication, including any and all attachments, contains confidential information intended only for the person(s) to whom it is addressed. Any dissemination, distribution, copying or disclosure is strictly prohibited and is not a waiver of confidentiality. If you have received this telecommunication in error, please notify the sender immediately by return electronic mail and delete the message from your inbox and deleted items folders. This telecommunication does not constitute an express or implied agreement to conduct transactions by electronic means, nor does it constitute a contract offer, a contract amendment or an acceptance of a contract offer. Contract terms contained in this telecommunication are subject to legal review and the completion of formal documentation and are not binding until same is confirmed in writing and has been signed by an authorized signatory.

[-- Attachment #2: Type: text/html, Size: 3457 bytes --]

Re: [Bloat] Adding CAKE "tc qdisc" options to NetworkManager

[Dave Collier-Brown]

Alas, once I looked under the covers, it doesn't look easy at all.
Definitely not a weekend project.

I used to use QEF, and this reminds me of it.

--dave

On 2020-10-05 1:33 p.m., Jonathan Morton wrote:
>> On 5 Oct, 2020, at 7:13 pm, David Collier-Brown <davecb.42@gmail.com> wrote:
>>
>> By pure luck, I ended up chatting with one of the NetworkManager chaps, who invited a merge request with the proper parameters for CAKE.
>>
>> He wrote
>>
>> Currently NM doesn't support configuring CAKE parameters. IOW, if you
>> set "root cake bandwidth 100Mbit", you will see in the tc output that
>> cake was set but with default parameters.
>>
>> Yes, I think it will be useful to have CAKE support in NM, but I can't
>> say when it will be implemented. Of course, patches are always
>> welcome; if anybody is interested in contributing it, please have a
>> look at the work that was done to support SFQ:
>>
>> https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b22b4f9101b1cbfde49b65d9e2107e4ae0d817c0
>>
>> Sounds like a good job for next weekend, can I get some reviewers for the week after?
> I could probably at least glance at it.  How easy is it to set this up in, say, Linux Mint?
>
>   - Jonathan Morton

--
David Collier-Brown,         | Always do right. This will gratify
System Programmer and Author | some people and astonish the rest
dave.collier-brown@indexexchange.com |              -- Mark Twain


CONFIDENTIALITY NOTICE AND DISCLAIMER : This telecommunication, including any and all attachments, contains confidential information intended only for the person(s) to whom it is addressed. Any dissemination, distribution, copying or disclosure is strictly prohibited and is not a waiver of confidentiality. If you have received this telecommunication in error, please notify the sender immediately by return electronic mail and delete the message from your inbox and deleted items folders. This telecommunication does not constitute an express or implied agreement to conduct transactions by electronic means, nor does it constitute a contract offer, a contract amendment or an acceptance of a contract offer. Contract terms contained in this telecommunication are subject to legal review and the completion of formal documentation and are not binding until same is confirmed in writing and has been signed by an authorized signatory.

Re: [Bloat] Adding CAKE "tc qdisc" options to NetworkManager

[Toke Høiland-Jørgensen]

Dave Collier-Brown <dave.collier-brown@indexexchange.com> writes:

> Alas, once I looked under the covers, it doesn't look easy at all.
> Definitely not a weekend project.
>
> I used to use QEF, and this reminds me of it.

Looks eminently copy-paste'able from that sfq commit you linked, though :)

-Toke