General list for discussing Bufferbloat
 help / color / mirror / Atom feed
From: David Collier-Brown <davecb.42@gmail.com>
To: bloat <bloat@lists.bufferbloat.net>
Subject: [Bloat] Adding CAKE "tc qdisc" options to NetworkManager
Date: Mon, 5 Oct 2020 12:13:38 -0400	[thread overview]
Message-ID: <9927dd42-2a57-9101-bf19-9371355e82e0@rogers.com> (raw)
In-Reply-To: <20201005155644.GA1072516@tp>


[-- Attachment #1.1: Type: text/plain, Size: 1486 bytes --]

By pure luck, I ended up chatting with one of the NetworkManager chaps, 
who invited a merge request with the proper parameters for CAKE.

He wrote

Currently NM doesn't support configuring CAKE parameters. IOW, if you
set "root cake bandwidth 100Mbit", you will see in the tc output that
cake was set but with default parameters.

Yes, I think it will be useful to have CAKE support in NM, but I can't
say when it will be implemented. Of course, patches are always
welcome; if anybody is interested in contributing it, please have a
look at the work that was done to support SFQ:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b22b4f9101b1cbfde49b65d9e2107e4ae0d817c0

Sounds like a good job for next weekend, can I get some reviewers for 
the week after?

--dave


-------- Forwarded Message --------
Subject: 	Re: New "tc qdisc" options
Date: 	Mon, 5 Oct 2020 17:56:44 +0200
From: 	Beniamino Galvani <bgalvani@redhat.com>
To: 	Dave Collier-Brown <dave.collier-brown@indexexchange.com>
CC: 	Thomas Haller <thaller@redhat.com>, davecb@spamcop.net 
<davecb@spamcop.net>, NetworkManager-list@gnome.org



On Mon, Oct 05, 2020 at 11:52:32AM -0400, Dave Collier-Brown wrote:
> I can absolutely propose a patch/MR based on that example, but I'm
> fallible (;-))
>
> Do you prefer an MR in github or a git-format-patch via email?

A MR on gitlab is the preferred way:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests

Thanks,
Beniamino


[-- Attachment #1.2: Type: text/html, Size: 3836 bytes --]

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 834 bytes --]

       reply	other threads:[~2020-10-05 16:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201005155644.GA1072516@tp>
2020-10-05 16:13 ` David Collier-Brown [this message]
2020-10-05 17:33   ` Jonathan Morton
2020-10-05 18:28     ` Dave Collier-Brown
2020-10-05 18:54     ` Dave Collier-Brown
2020-10-05 21:10       ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/bloat.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9927dd42-2a57-9101-bf19-9371355e82e0@rogers.com \
    --to=davecb.42@gmail.com \
    --cc=bloat@lists.bufferbloat.net \
    --cc=davecb@spamcop.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox