From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 0A1D13CB35 for ; Mon, 5 Oct 2020 12:13:41 -0400 (EDT) Received: by mail-qt1-x832.google.com with SMTP id d1so10071769qtr.6 for ; Mon, 05 Oct 2020 09:13:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:reply-to:references:to:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=G2Jcgp4k78FHNtTpk6JYwq2/1GR1aoeNbVV7Y15knUk=; b=mm0pZq9Y462S2GFPLfrz3YOCGQIMa4FkySPwnWvL6FEh0vd82k0kcMFwO/LzsEHkRO D27rTM7wrOWlKptSxpidXZGM4vz5W7RiOZGgLzguUDvja0VbD/SqW+17sTol9lYx2GUy 23Anl8u1TbtFTbGGTxU5aD/jgOrqKu53YTiA0m/RiZhTlvTdQBNOdvPsdoyvsiDpzPnE fQZy2gQyhSlIQ0wQ5Jl+roeCpXfzcmorhNw/WFett9hzgYzB0SU8mEhKacEfFLzkOZdz SUr8COhqCzaQkjTGkQczNlrjZHCK59diYuAaV1ZgmE51aDUxv7gqengBTJcmaDC3Lmyh MrSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:reply-to:references:to:message-id :date:user-agent:mime-version:in-reply-to:content-language; bh=G2Jcgp4k78FHNtTpk6JYwq2/1GR1aoeNbVV7Y15knUk=; b=ZKliN+vQRPScfORbWKiqsB1191UMqJEDBZk3YtYhJTAneQ+268UZ/ym8JxYxfe5AzO MkhAPb+c14eWpLvVCe0wdNnPYcw8jdK8d5vYnp8817ranhdk1FNa9g5+ohiHM85ZGLA1 bxSRxTneDVvL+ynwKnwF2pvs8PDp53ImRyo45aFTVw0aUjyxBoHU+svOFYDD24FjxDy8 Bl/nBIJKThCV5DhX7utgvSo9Ua3lQCYUI1LP93q3dpM80EcJ65zYUV8c59m0xAoBUxgV mAlsjkgOSgLL0fDFgIgGkjylVmFMvxoIhZjIn6VYAu2bPX248zPkM0bUG/7rBcEGcOEA eYUg== X-Gm-Message-State: AOAM530+tFCbM0ahLOV3es34rUCeCckndJqAn0qdFlCEQLRSfNQpE6lc g9DpYstHSZoIlGreeVjRGEglP1ohUd8= X-Google-Smtp-Source: ABdhPJx/wcJ940+VOK70aRO4Brcl4Y3lMAR7uiXVFj0OGnGPYJYTLMD8QheMeIgx10QkYANvgRgUEQ== X-Received: by 2002:ac8:5992:: with SMTP id e18mr572556qte.245.1601914421499; Mon, 05 Oct 2020 09:13:41 -0700 (PDT) Received: from [192.168.7.123] (CPE5896306dfa2e-CM5896306dfa2c.cpe.net.cable.rogers.com. [99.240.238.19]) by smtp.gmail.com with ESMTPSA id u10sm347886qkk.14.2020.10.05.09.13.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Oct 2020 09:13:39 -0700 (PDT) From: David Collier-Brown X-Google-Original-From: David Collier-Brown Reply-To: davecb@spamcop.net References: <20201005155644.GA1072516@tp> To: bloat X-Forwarded-Message-Id: <20201005155644.GA1072516@tp> Message-ID: <9927dd42-2a57-9101-bf19-9371355e82e0@rogers.com> Date: Mon, 5 Oct 2020 12:13:38 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20201005155644.GA1072516@tp> Content-Type: multipart/mixed; boundary="------------9FB3FC120DEAA32235061C6D" Content-Language: en-US Subject: [Bloat] Adding CAKE "tc qdisc" options to NetworkManager X-BeenThere: bloat@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: General list for discussing Bufferbloat List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2020 16:13:42 -0000 This is a multi-part message in MIME format. --------------9FB3FC120DEAA32235061C6D Content-Type: multipart/alternative; boundary="------------4D9F5ABB97AE6C060D3CFB98" --------------4D9F5ABB97AE6C060D3CFB98 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit By pure luck, I ended up chatting with one of the NetworkManager chaps, who invited a merge request with the proper parameters for CAKE. He wrote Currently NM doesn't support configuring CAKE parameters. IOW, if you set "root cake bandwidth 100Mbit", you will see in the tc output that cake was set but with default parameters. Yes, I think it will be useful to have CAKE support in NM, but I can't say when it will be implemented. Of course, patches are always welcome; if anybody is interested in contributing it, please have a look at the work that was done to support SFQ: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b22b4f9101b1cbfde49b65d9e2107e4ae0d817c0 Sounds like a good job for next weekend, can I get some reviewers for the week after? --dave -------- Forwarded Message -------- Subject: Re: New "tc qdisc" options Date: Mon, 5 Oct 2020 17:56:44 +0200 From: Beniamino Galvani To: Dave Collier-Brown CC: Thomas Haller , davecb@spamcop.net , NetworkManager-list@gnome.org On Mon, Oct 05, 2020 at 11:52:32AM -0400, Dave Collier-Brown wrote: > I can absolutely propose a patch/MR based on that example, but I'm > fallible (;-)) > > Do you prefer an MR in github or a git-format-patch via email? A MR on gitlab is the preferred way: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests Thanks, Beniamino --------------4D9F5ABB97AE6C060D3CFB98 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: 7bit

By pure luck, I ended up chatting with one of the NetworkManager chaps, who invited a merge request with the proper parameters for CAKE.

He wrote

Currently NM doesn't support configuring CAKE parameters. IOW, if you
set "root cake bandwidth 100Mbit", you will see in the tc output that
cake was set but with default parameters.

Yes, I think it will be useful to have CAKE support in NM, but I can't
say when it will be implemented. Of course, patches are always
welcome; if anybody is interested in contributing it, please have a
look at the work that was done to support SFQ:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b22b4f9101b1cbfde49b65d9e2107e4ae0d817c0

Sounds like a good job for next weekend, can I get some reviewers for the week after?

--dave


-------- Forwarded Message --------
Subject: Re: New "tc qdisc" options
Date: Mon, 5 Oct 2020 17:56:44 +0200
From: Beniamino Galvani <bgalvani@redhat.com>
To: Dave Collier-Brown <dave.collier-brown@indexexchange.com>
CC: Thomas Haller <thaller@redhat.com>, davecb@spamcop.net <davecb@spamcop.net>, NetworkManager-list@gnome.org


On Mon, Oct 05, 2020 at 11:52:32AM -0400, Dave Collier-Brown wrote:
I can absolutely propose a patch/MR based on that example, but I'm
fallible (;-))

Do you prefer an MR in github or a git-format-patch via email?

A MR on gitlab is the preferred way:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests

Thanks,
Beniamino

--------------4D9F5ABB97AE6C060D3CFB98-- --------------9FB3FC120DEAA32235061C6D Content-Type: application/pgp-signature; name="signature.asc" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUU4SDk4SHF2 VGd2Z2N2N283bVkxSUtNMStGbFlGQWw5N1Fqd0FDZ2tRbVkxSUtNMSsKRmxhd2NoQUFpbUpV NThGaStuQVVUbzJPNVFrQmZWZ3FsNENHMndJY0tOaHBxZzRVTkFuQm8rUlNiRjNDdXNkdwpK Y1VkeHdHVWpQUFpOMUdUekkrUnRYZjlvanNDT2JEU1JMRDZEWjUyMlJBYW0zYnFFMHg4dXF3 VHhrQ3lDakVlClBvUWF5L2MzeS9TZlFTVkpJYnMwazFGOXI5MHFuVUhJZUNuZlBlbWVrZUFR N3ZGRXBTamlicWFMM1VaNklodDQKcmJKZHdpWnhDOFAyWkFGK21sUmVvaVZDdW1VaXBuZjAz eEM1Rit1Y3d6SU1MY0IwcmRmRzdkWUFYSm93Z3dqVQoxeGU1TG1xYjJvdVl6U2JpYy82RWQz SUxaZlllSjZPN28rOWZFWlZzcmRhNDBHd2VkbXlYdE1NdUJWcTRWM0NHCmJFQk1iSGRIcmFu cDJVWndQd2h4ZHZwbkxhMnRMQUREbDliclQzS2xxRTEvYUVvaEVKMUJTVXZmQjBPWjJHY3AK eTFTMVQySjNhNVhqMHJJUGRhZDFwRzRSRUlaSTJuSWV1QzNTNHNjeDhIOXBQbEd0ZUZidzJu RVNPdjcrVDRQawpQTTFuMzRnN1J0V1BKN3B3M3lxNHlWdDJhakprQzRkNEt0aHgyaEtUTDdl SGZadDJrM1EzKzlscW1OWFpWdE1UCmV4eVJoVG1tbWZCdXRCVnVMQXYyOFlRRUdoREw1bEh2 Qko0QU9VUmhudVl1WlVDblVZdlpXK3VhdFRUd0ZCcXQKQW9LenI0ZVF6MUZQS3loUWx2M3dJ M0hpNHdxdjQzKytrZm5OdHFTWjA5TXJITXdLL094eHhOeFFBYXhYbzVvUAowSDJzVUFyaTlU bVhRenk4eEdWVURGT09XYm81YUcvSGNvRkpBK0kzRTNDQytsV3VzdWc9Cj1XNXZsCi0tLS0t RU5EIFBHUCBTSUdOQVRVUkUtLS0tLQoK --------------9FB3FC120DEAA32235061C6D--