From: "De Schepper, Koen (Nokia - BE)" <koen.de_schepper@nokia-bell-labs.com>
To: Dave Taht <dave.taht@gmail.com>, "aqm@ietf.org" <aqm@ietf.org>,
"tcpprague@ietf.org" <tcpprague@ietf.org>,
bloat <bloat@lists.bufferbloat.net>
Subject: Re: [Bloat] [aqm] what is the correct linux tc u32 match to ignore ecn but preserve tos?
Date: Wed, 3 Aug 2016 09:56:53 +0000 [thread overview]
Message-ID: <BF6B00CC65FD2D45A326E74492B2C19FB76E4967@FR711WXCHMBA05.zeu.alcatel-lucent.com> (raw)
In-Reply-To: <CAA93jw48xb7g-q839iixUadRG9GH9e_W5KvjPtpKKij=UmOJvg@mail.gmail.com>
See inline:
> -----Original Message-----
> From: aqm [mailto:aqm-bounces@ietf.org] On Behalf Of Dave Taht
> Sent: donderdag 28 juli 2016 19:27
> To: aqm@ietf.org; tcpprague@ietf.org; bloat
> Subject: [aqm] what is the correct linux tc u32 match to ignore ecn but
> preserve tos?
>
> I can't ever get my endianess straight, and I figure that someone here
> might "just know"
>
> Do I use match u8 0xfc or 0xcf?
>
> tc filter add dev $DEV parent 1:0 protocol ip prio 10 u32 \
> match ip tos 0x10 0xff flowid 1:10
>
> (am trying to revise this from in front of a mac:
> https://www.bufferbloat.net/projects/cerowrt/wiki/Wondershaper_Must_Die/
> )
>
> Bonus points if you can come up with the right tc filter line for ipv6.
>
> What I would probably do is have a filter chain to then classify the
> thing further for L4s, but I don't understand how or where I'd direct
> CE markings correctly. (?)
>
> How does it happen in the pi2 code? is that on github somewhere?
Pi2 code is in https://github.com/olgabo/dualpi2
We don't use tc filters to classify, the classification and dualq is part of the aqm. From a tc point of view, it is a single qdisc.
The L4S classifier is only one bit: the least significant one in the ecn (and also tos) field. This way both ect(1) and ce are treated as L4S. Default the current pi2 will classify also ect(0), to work with DCTCP. You can use the option "ect1_scal" to treat only ect1 as a scalable CC (so to support classic ecn). Also per default no DualQ is enabled. For DCTCP with DualQ, specify the "dualq" option, which puts also ect(0) in the L4S queue. The option dualq_ect1 puts only ect(1) and ce in the L4S queue and ect(0) in the classic queue.
Koen.
>
> --
> Dave Täht
> Let's go make home routers and wifi faster! With better software!
> http://blog.cerowrt.org㯝㯟
>
> _______________________________________________
> aqm mailing list
> aqm@ietf.org
> https://www.ietf.org/mailman/listinfo/aqm
prev parent reply other threads:[~2016-08-03 9:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 17:27 [Bloat] " Dave Taht
2016-08-03 9:56 ` De Schepper, Koen (Nokia - BE) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/bloat.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BF6B00CC65FD2D45A326E74492B2C19FB76E4967@FR711WXCHMBA05.zeu.alcatel-lucent.com \
--to=koen.de_schepper@nokia-bell-labs.com \
--cc=aqm@ietf.org \
--cc=bloat@lists.bufferbloat.net \
--cc=dave.taht@gmail.com \
--cc=tcpprague@ietf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox