From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id A5B853CB37; Sat, 14 Oct 2023 15:01:30 -0400 (EDT) Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-27d18475ed4so2511398a91.0; Sat, 14 Oct 2023 12:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697310089; x=1697914889; darn=lists.bufferbloat.net; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uG3PqlHkh4gSyCDlKVjagqd9FdbqXFbFsRS2KkKuybo=; b=GSfqpKwZirxqc6EuJOgxVUCxXbpHJ9REah8/MGvIPSCOW22D8Cx7Dpblqp+QAvmwzN lSVlX497//pyyyU3TMZ9+1jRaet/0Zhns2JvqVRs+WcW5S8w80nw9fsdN0Uosu8HWG+L sBrPZfO6nfo9FLXK4ql7c/u/nDs2Zjy0KEfI6b/hepSENNCforlMbysO93OMDs/gOYaJ cgAwytcat21tbpq21Q6DfZoswS4hc0xjJ5Vlj9Hr1Mk8O9z18HkVItvHPGJ/wfDLhBXE 7A4quCFSifw2VyUfb0Fdvju4qV9qoXn96s5334sxX7Zy+aCudSc1MZ1liKQIWflgdtk9 Fsaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697310089; x=1697914889; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uG3PqlHkh4gSyCDlKVjagqd9FdbqXFbFsRS2KkKuybo=; b=T7do9ACudVBsCSEkbVdwYIj8FI8WFB/XNWf8qil/AKG0jUdkUcbGDQnD1HcQ5iaDoC 5SDd7zCMdwkaQyR+gVeuaMPrOhKqpaH3LVyYwz6HYFjKf0RDXr0YwkZDKBC9wxOv5tm1 wLACvUaaEWZOuId/+vaEGfAXvFX3Si5J1p+5VvPPDk7YRybCxR3WWZdzmmh3Ex3bsDhn 2Hyhs5rj9ipPZB/CFNoNmqDCAoCzuiPGk8kj0U5Av2qHK66jSsWMZanO9zBB1pWuIFeI OEmyv3C1CCEUs75NzBJiVf3ebddPz4P0uqJjkBtZYcxtV6dbjNXpisJQIio1cNt1gY6T 4tuw== X-Gm-Message-State: AOJu0YxjycXx9bulkYs47Le6TxKSzIGW/s8UZxpIovoNxskIpVbhObEn 9PXphaO997wq2jeXMqbOZYZkXKi42LPC9TL+NRI= X-Google-Smtp-Source: AGHT+IFo/ZJyJ0xyFDtO7VD84gSS5aAiNAbhjySQdCcUnaDuWwWcblHaHDrRE1rdmQeFIor4lWCJg+smQpYp2GuLtvQ= X-Received: by 2002:a17:90a:18f:b0:27d:12e1:94e0 with SMTP id 15-20020a17090a018f00b0027d12e194e0mr8679900pjc.36.1697310089492; Sat, 14 Oct 2023 12:01:29 -0700 (PDT) MIME-Version: 1.0 References: <3E02B7F5-D0C6-4C33-AFA9-30A2E54B155F@gmail.com> In-Reply-To: From: Dave Taht Date: Sat, 14 Oct 2023 12:01:18 -0700 Message-ID: To: Jonathan Morton , bloat Cc: codel@lists.bufferbloat.net Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Bloat] [Codel] fq_"codel" in apple's gear X-BeenThere: bloat@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: General list for discussing Bufferbloat List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Oct 2023 19:01:30 -0000 I would be curious if fq_"codel" was still in use on the current apple products. On an OSX box, the magic command to look at the stats was: netstat -I en0 -qq # or whatever the right interface is And you can just poll that while slamming traffic through it. On Sat, Oct 14, 2023 at 11:50=E2=80=AFAM Dave Taht wr= ote: > > On Sat, Oct 14, 2023 at 11:17=E2=80=AFAM Jonathan Morton wrote: > > > > > On 14 Oct, 2023, at 8:23 pm, Dave Taht wrote: > > > > > > I would really like someone with a fresh set of eyeballs to review th= e > > > "codel" portion of apple's latest code drop here: > > > > > > https://www.linkedin.com/feed/update/urn:li:activity:7118969694987935= 744/ > > > > So far as I can tell, it still implements DRR++ (with a comment referen= cing RFC-8290), but not Codel (there's also no comment referencing RFC-8289= ). There's at least one function for handling ECN which is simply not call= ed, at least not in that source file. > > Thank you for summoning the gumption to look again. I was having blood > pressure problems. > > > In fact, I looked in the header to see where an ECN mark counter was de= fined. It is referenced in essentially three places: the definition, an e= xtraction for reporting to userspace, and an increment - in a function impl= ementing L4S marking, not Codel. > > > > A similar counter for "early dropped" packets is incremented only when = packets have to be dropped in an emergency because the queue is *full*. Th= at's the other counter I would expect to be touched by an AQM implementatio= n. > > Yep. I had run some tests then and saw the rtts climbing alarmingly, > while polling their stack and only seeing drops in big bursty batches, > total resets of the tcp flow, and so on. > > > So, no tangible improvement that I can find easily. > > > > - Jonathan Morton > > > > -- > Oct 30: https://netdevconf.info/0x17/news/the-maestro-and-the-music-bof.h= tml > Dave T=C3=A4ht CSO, LibreQos --=20 Oct 30: https://netdevconf.info/0x17/news/the-maestro-and-the-music-bof.htm= l Dave T=C3=A4ht CSO, LibreQos