From: Dave Taht <dave.taht@gmail.com>
To: Naeem Khademi <naeem.khademi@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>, bloat <bloat@lists.bufferbloat.net>
Subject: Re: [Bloat] SFQRED or SFQARED?
Date: Tue, 27 Aug 2013 13:58:09 -0700 [thread overview]
Message-ID: <CAA93jw7rRSQmqiq7xumkdpytZLs-LbsSF6stGJGT=vj1s7KyYQ@mail.gmail.com> (raw)
In-Reply-To: <CAA93jw5mHL-9ubCvXwBj8sWZ+K1=JoRiVwxOG+TyG5wPyz4ByQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2827 bytes --]
On Tue, Aug 27, 2013 at 1:44 PM, Dave Taht <dave.taht@gmail.com> wrote:
>
>
>
> On Tue, Aug 27, 2013 at 9:29 AM, Naeem Khademi <naeem.khademi@gmail.com>wrote:
>
>> Hi
>>
>> Slide 37 of below link mentions that SFQRED implemented in Linux 3.4
>> upwards, "Utilized a better version of RED (“ARED”) from Sally Floyd
>> in 2002". However I'm unable to find the "adaptive" bit of SFQRED in
>> the kernel and iproute code. Can anyone (Dave or Eric) confirm that
>> the mentioned statement is correct?
>>
>> http://netseminar.stanford.edu/seminars/Inside_Codel_and_Fq_Codel.pdf
>>
>>
> I think you are correct in that the adaptive RED code never formally made
> it into SFQRED. SFQRED was a brief blip in time before codel showed up...
> I'd talked about it in that talk as a steppingstone in hybrid fq+aqm
> history. (prior to that we were working with qfq + red as entirely
> separate, modular qdiscs). So... oops.
>
While I'm correcting slides and trying to keep history straight, after that
talk it was pointed out that head drop from the biggest flow had been
proposed as early as 1999, and possibly as early as the mid-late 1980s...
https://lists.bufferbloat.net/pipermail/bloat/2013-February/001345.html
I enjoyed the literature search around that thread a lot. What was new was
old again.
> I think the work was interesting and valuable, and if you want to play
> with the ARED variant probably all you have to do is OR in the
> TC_ADAPTATIVE value into the flags on the red setup in sch_sfq.c
>
> Eric added ARED support to sch_red in kernel commit:
> 8af2a218de38f51ea4b4fa48cac1273319ae260c
>
>
> https://android.googlesource.com/kernel/exynos/+/8af2a218de38f51ea4b4fa48cac1273319ae260c
>
> and some ip route version later corrected "adaptive" to be the user-facing
> syntax. I just ran a quick, dirty and (nonsensical*) rrul test with this:
>
> tc qdisc add dev eth0 root red limit 40000 min 30000 max 90000 avpkt 1000
> burst 55 ecn adaptive bandwidth 10Mbit
>
> tc -s qdisc show dev eth0
> qdisc red 8005: root refcnt 2 limit 40000b min 30000b max 90000b ecn
> adaptive
> Sent 858913226 bytes 823269 pkt (dropped 4866, overlimits 123 requeues 0)
> backlog 0b 0p requeues 0
> marked 0 early 123 pdrop 4743 other 0
>
> which "just worked" with ubuntu 13.4.
>
> The ARED option could be enabled with GRED/SFQRED with adding the right
> knob to iproute2.
>
>
> Regards,
>> Naeem
>>
>
>
> * I have thankfully managed to completely forget how to configure RED or
> ARED to what little extent I understood it in the first place
> --
> Dave Täht
>
> Fixing bufferbloat with cerowrt:
> http://www.teklibre.com/cerowrt/subscribe.html
>
--
Dave Täht
Fixing bufferbloat with cerowrt:
http://www.teklibre.com/cerowrt/subscribe.html
[-- Attachment #2: Type: text/html, Size: 4712 bytes --]
next prev parent reply other threads:[~2013-08-27 20:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 16:29 Naeem Khademi
2013-08-27 20:44 ` Dave Taht
2013-08-27 20:58 ` Dave Taht [this message]
2013-09-03 18:31 ` Dave Taht
2013-09-03 17:39 ` Naeem Khademi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/bloat.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA93jw7rRSQmqiq7xumkdpytZLs-LbsSF6stGJGT=vj1s7KyYQ@mail.gmail.com' \
--to=dave.taht@gmail.com \
--cc=bloat@lists.bufferbloat.net \
--cc=edumazet@google.com \
--cc=naeem.khademi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox