General list for discussing Bufferbloat
 help / color / mirror / Atom feed
From: Neal Cardwell <ncardwell@google.com>
To: Bob McMahon <bob.mcmahon@broadcom.com>
Cc: Dave Taht <dave.taht@gmail.com>,
	 Make-Wifi-fast <make-wifi-fast@lists.bufferbloat.net>,
	bloat <bloat@lists.bufferbloat.net>,
	 BBR Development <bbr-dev@googlegroups.com>
Subject: Re: [Bloat] [bbr-dev] Aggregating without bloating - hard times for tcp and wifi
Date: Tue, 22 Nov 2022 15:10:23 -0500	[thread overview]
Message-ID: <CADVnQyn9OSxPcF2JsUHdiWLTvAAdN5vs1uyiRBL0AS8yH8niYw@mail.gmail.com> (raw)
In-Reply-To: <CAHb6LvrK_exkt_rbukYkF4_hwPXyy9T+ZNGzdK79x91RrK49Mg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 4293 bytes --]

On Tue, Nov 22, 2022 at 2:43 PM 'Bob McMahon' via BBR Development <
bbr-dev@googlegroups.com> wrote:

> Thanks for sharing this. Curious about how the xTSQ value can be set? Can
> it be done with sysctl?
>
> *We continue our analysis by using the ms-version of TSQ patch, which
> enables the tune of the TSQ size allowing each TCP variant to enqueue more
> than 1 ms of data at the current TCP rate. In particular, we allow to
> enqueue the equivalent of x ms of data, naming each test xTSQ, with x being
> an integer value. It is important to notice that this patch has been
> included in the Linux kernel mainline, and each Wi-Fi driver can now set
> the desired xTSQ value**.*
>

I believe they are setting the xTSQ value using the sk_pacing_shift field,
which was added here:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3a9b76fd0db9f0d426533f96a68a62a58753a51e

AFAIK the intent is only for drivers to set that, and there's no sysctl for
that, but of course you could add a sysctl for testing if you wanted. :-)

cheers,
neal




> Another thing that could be interesting is the WiFi aggregation stop
> reasons, e.g. how many times agg stopped per hitting the max mpdu per ampdu
> vs the software fifo going empty (i.e. no more packets available to the
> driver from the TCP stack) per that TXOP.
>
> Finally, many (most?) APs are forwarding and feeding packets at at the
> hardware level so not sure that the linux stack matters as much for an AP
> based analysis, particularly when considering multi user transmissions,
> i.e. multiple WiFi clients are active and sharing TXOPs.
>
> Bob
> On Mon, Nov 21, 2022 at 10:04 PM Dave Taht <dave.taht@gmail.com> wrote:
>
>> This paper came out last month. Good work, really exhaustive look at
>> two chipsets, multiple congestion controls and the interactions with
>> TSQ, with
>> lots and lots of flent.
>>
>> https://ieeexplore.ieee.org/stamp/stamp.jsp?arnumber=9772053
>>
>> as for wifi6... don't make me start talking about wifi6... but some of
>> these tests look like a good baseline to start comparing the ath11k,
>> mt79, etc..
>>
>> Paper kind of misses the negative impact of AQL in the ath10k (and
>> most likely also the mt76 and mt79 chips)
>>
>> --
>> This song goes out to all the folk that thought Stadia would work:
>>
>> https://www.linkedin.com/posts/dtaht_the-mushroom-song-activity-6981366665607352320-FXtz
>> Dave Täht CEO, TekLibre, LLC
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "BBR Development" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to bbr-dev+unsubscribe@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/bbr-dev/CAA93jw6yJU10wh9ajqX4yW2AvnJPStyWAAcV4%2BoQ8wSGsJgKZA%40mail.gmail.com
>> .
>>
>
> This electronic communication and the information and any files
> transmitted with it, or attached to it, are confidential and are intended
> solely for the use of the individual or entity to whom it is addressed and
> may contain information that is confidential, legally privileged, protected
> by privacy laws, or otherwise restricted from disclosure to anyone else. If
> you are not the intended recipient or the person responsible for delivering
> the e-mail to the intended recipient, you are hereby notified that any use,
> copying, distributing, dissemination, forwarding, printing, or copying of
> this e-mail is strictly prohibited. If you received this e-mail in error,
> please return the e-mail to the sender, delete it from your computer, and
> destroy any printed copy of it.
>
> --
> You received this message because you are subscribed to the Google Groups
> "BBR Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to bbr-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/bbr-dev/CAHb6LvrK_exkt_rbukYkF4_hwPXyy9T%2BZNGzdK79x91RrK49Mg%40mail.gmail.com
> <https://groups.google.com/d/msgid/bbr-dev/CAHb6LvrK_exkt_rbukYkF4_hwPXyy9T%2BZNGzdK79x91RrK49Mg%40mail.gmail.com?utm_medium=email&utm_source=footer>
> .
>

[-- Attachment #2: Type: text/html, Size: 6010 bytes --]

  parent reply	other threads:[~2022-11-22 20:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22  6:04 [Bloat] " Dave Taht
2022-11-22 19:42 ` [Bloat] [bbr-dev] " Bob McMahon
2022-11-22 20:03   ` [Bloat] [Make-wifi-fast] " David Lang
2022-11-22 20:13     ` Bob McMahon
2022-11-22 20:16       ` David Lang
2022-11-22 20:28         ` Bob McMahon
2022-11-22 20:48           ` Bob McMahon
2022-11-22 20:10   ` Neal Cardwell [this message]
2022-11-22 20:53     ` [Bloat] " Toke Høiland-Jørgensen
2022-11-22 21:00       ` Bob McMahon
2022-11-23 13:50         ` Toke Høiland-Jørgensen
2022-11-23 20:36           ` Bob McMahon
     [not found]     ` <003d01d8ffc5$2ace1a20$806a4e60$@umt.edu.pk>
2022-11-24 16:23       ` Dave Taht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/bloat.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADVnQyn9OSxPcF2JsUHdiWLTvAAdN5vs1uyiRBL0AS8yH8niYw@mail.gmail.com \
    --to=ncardwell@google.com \
    --cc=bbr-dev@googlegroups.com \
    --cc=bloat@lists.bufferbloat.net \
    --cc=bob.mcmahon@broadcom.com \
    --cc=dave.taht@gmail.com \
    --cc=make-wifi-fast@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox