Re: [Bloat] [bbr-dev] Aggregating without bloating - hard times for tcp and wifi

[Bob McMahon <bob.mcmahon@broadcom.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2816 bytes --]

Does the TSQ code honor no-aggregation per voice access class or
TCP_NODELAY where the app making the socket write calls knows that the WiFi
aggregation isn't likely helpful? Sorry, my Linux stack expertise is quite
limited.

Bob

On Tue, Nov 22, 2022 at 12:53 PM Toke Høiland-Jørgensen <toke@toke.dk>
wrote:

> Neal Cardwell via Bloat <bloat@lists.bufferbloat.net> writes:
>
> > On Tue, Nov 22, 2022 at 2:43 PM 'Bob McMahon' via BBR Development <
> > bbr-dev@googlegroups.com> wrote:
> >
> >> Thanks for sharing this. Curious about how the xTSQ value can be set?
> Can
> >> it be done with sysctl?
> >>
> >> *We continue our analysis by using the ms-version of TSQ patch, which
> >> enables the tune of the TSQ size allowing each TCP variant to enqueue
> more
> >> than 1 ms of data at the current TCP rate. In particular, we allow to
> >> enqueue the equivalent of x ms of data, naming each test xTSQ, with x
> being
> >> an integer value. It is important to notice that this patch has been
> >> included in the Linux kernel mainline, and each Wi-Fi driver can now set
> >> the desired xTSQ value**.*
> >>
> >
> > I believe they are setting the xTSQ value using the sk_pacing_shift
> field,
> > which was added here:
> >
> >
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3a9b76fd0db9f0d426533f96a68a62a58753a51e
> >
> > AFAIK the intent is only for drivers to set that, and there's no sysctl
> for
> > that, but of course you could add a sysctl for testing if you wanted.
> > :-)
>
> Yup, indeed this is what mac80211 fiddles with:
> https://elixir.bootlin.com/linux/latest/source/net/mac80211/main.c#L739
> https://elixir.bootlin.com/linux/latest/source/net/mac80211/tx.c#L4156
>
> AFAICT, no in-tree drivers override the value set by mac80211.
>
> I believe the tests in that paper were conducted with this series
> applied:
>
> https://lore.kernel.org/all/20180105113256.14835-1-natale.patriciello@gmail.com/
>
> -Toke
>

-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.

[-- Attachment #1.2: Type: text/html, Size: 3984 bytes --]

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4206 bytes --]