From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 638143CB37 for ; Tue, 22 Nov 2022 16:00:27 -0500 (EST) Received: by mail-lf1-x12d.google.com with SMTP id f13so3833087lfa.6 for ; Tue, 22 Nov 2022 13:00:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1bhHWRu9HpO7xbUDNvsnJVmgk2GvGOitGdTxNrlgUO0=; b=T4ro8EDEKTQmkwEB3A+96B2w8U4OlYmLOKDOuGXCK30zyOrcVni5yeOJOkBh6J9pbk b2OvaYw+ownEbS4dQr9P8vYnsc9di/5lN3ym1sKwr7R/z1Hfvzj3nv/2vEL15BBnvk4Z ny7y7vaWfkn5tpbtPtXGgYWX0EIkXlqX8cBzE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1bhHWRu9HpO7xbUDNvsnJVmgk2GvGOitGdTxNrlgUO0=; b=m2IqC7uf/BE5Pd6D/46hR7YfvybVRFHegVHJ9sPpKBbJDubO+C0QfEnp4KMy8TJ4Ig V8jDA/wraBRacdqbDnYoW61xBEBbo+H6sTjfyaeRp5YDcRk1QVYMt+5Lymmpt9KYOJqy P4HEUl3KOuHAMoO5R4xRWdg7lZkM6LbnY9bjyzasC3GMTNC20tmD02hEh10Y3VYGx9To TXQy+NxcDLCsgXhhwZiGnUpBtFkMvyJUg7GCYocZDxwj2QX2Tf+n9vBHPejrfUh64XDT p+XhpBtJdAd/ohOfkUTzJ4UZbdW7cj1PKX6Y3AMUnKizKp78mpsXEPAvg3mvJQwvFGJ1 5/DQ== X-Gm-Message-State: ANoB5plE7kAeCBPhbqT4dc1xyvw2/wY70TDM4qig6rbxdNrvo3Jjgy9b ioYst2BT9m+9SaiMLh7Ux26XrE6IIj5IiISJo3Jjc7xvGeZEMrWNbk38w6VdOlbBWJH171+waO/ pbrmr+Cu1KR5KFBpy510kya0wzRoFHw== X-Google-Smtp-Source: AA0mqf7VhT2MHc3qn9HiLF3Q7dYCbVPn3vtGC9fID8Ghib9HD8FZjlXvavj3nysQc9JGQUFPEj6Cb5jm7mSY9Lrt0JU= X-Received: by 2002:a19:7416:0:b0:4a2:98f2:8324 with SMTP id v22-20020a197416000000b004a298f28324mr9182986lfe.134.1669150825859; Tue, 22 Nov 2022 13:00:25 -0800 (PST) MIME-Version: 1.0 References: <87r0xuvhgp.fsf@toke.dk> In-Reply-To: <87r0xuvhgp.fsf@toke.dk> From: Bob McMahon Date: Tue, 22 Nov 2022 13:00:14 -0800 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Neal Cardwell , Make-Wifi-fast , BBR Development , bloat Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000014367505ee157613" Subject: Re: [Bloat] [bbr-dev] Aggregating without bloating - hard times for tcp and wifi X-BeenThere: bloat@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: General list for discussing Bufferbloat List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Nov 2022 21:00:27 -0000 --00000000000014367505ee157613 Content-Type: multipart/alternative; boundary="0000000000000dbc0305ee1576eb" --0000000000000dbc0305ee1576eb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Does the TSQ code honor no-aggregation per voice access class or TCP_NODELAY where the app making the socket write calls knows that the WiFi aggregation isn't likely helpful? Sorry, my Linux stack expertise is quite limited. Bob On Tue, Nov 22, 2022 at 12:53 PM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > Neal Cardwell via Bloat writes: > > > On Tue, Nov 22, 2022 at 2:43 PM 'Bob McMahon' via BBR Development < > > bbr-dev@googlegroups.com> wrote: > > > >> Thanks for sharing this. Curious about how the xTSQ value can be set? > Can > >> it be done with sysctl? > >> > >> *We continue our analysis by using the ms-version of TSQ patch, which > >> enables the tune of the TSQ size allowing each TCP variant to enqueue > more > >> than 1 ms of data at the current TCP rate. In particular, we allow to > >> enqueue the equivalent of x ms of data, naming each test xTSQ, with x > being > >> an integer value. It is important to notice that this patch has been > >> included in the Linux kernel mainline, and each Wi-Fi driver can now s= et > >> the desired xTSQ value**.* > >> > > > > I believe they are setting the xTSQ value using the sk_pacing_shift > field, > > which was added here: > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit= /?id=3D3a9b76fd0db9f0d426533f96a68a62a58753a51e > > > > AFAIK the intent is only for drivers to set that, and there's no sysctl > for > > that, but of course you could add a sysctl for testing if you wanted. > > :-) > > Yup, indeed this is what mac80211 fiddles with: > https://elixir.bootlin.com/linux/latest/source/net/mac80211/main.c#L739 > https://elixir.bootlin.com/linux/latest/source/net/mac80211/tx.c#L4156 > > AFAICT, no in-tree drivers override the value set by mac80211. > > I believe the tests in that paper were conducted with this series > applied: > > https://lore.kernel.org/all/20180105113256.14835-1-natale.patriciello@gma= il.com/ > > -Toke > --=20 This electronic communication and the information and any files transmitted= =20 with it, or attached to it, are confidential and are intended solely for=20 the use of the individual or entity to whom it is addressed and may contain= =20 information that is confidential, legally privileged, protected by privacy= =20 laws, or otherwise restricted from disclosure to anyone else. If you are=20 not the intended recipient or the person responsible for delivering the=20 e-mail to the intended recipient, you are hereby notified that any use,=20 copying, distributing, dissemination, forwarding, printing, or copying of= =20 this e-mail is strictly prohibited. If you received this e-mail in error,= =20 please return the e-mail to the sender, delete it from your computer, and= =20 destroy any printed copy of it. --0000000000000dbc0305ee1576eb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Does the TSQ code honor no-aggregation per voice access cl= ass or TCP_NODELAY where the app making=C2=A0the socket write calls knows t= hat the WiFi aggregation isn't likely helpful? Sorry, my Linux stack ex= pertise is quite limited.

Bob

On Tue, Nov 22, 2022 at 12:53 PM Toke H= =C3=B8iland-J=C3=B8rgensen <toke@toke.dk= > wrote:
= Neal Cardwell via Bloat <bloat@lists.bufferbloat.net> writes:

> On Tue, Nov 22, 2022 at 2:43 PM 'Bob McMahon' via BBR Developm= ent <
> bbr-dev@= googlegroups.com> wrote:
>
>> Thanks for sharing this. Curious about how the xTSQ value can be s= et? Can
>> it be done with sysctl?
>>
>> *We continue our analysis by using the ms-version of TSQ patch, wh= ich
>> enables the tune of the TSQ size allowing each TCP variant to enqu= eue more
>> than 1 ms of data at the current TCP rate. In particular, we allow= to
>> enqueue the equivalent of x ms of data, naming each test xTSQ, wit= h x being
>> an integer value. It is important to notice that this patch has be= en
>> included in the Linux kernel mainline, and each Wi-Fi driver can n= ow set
>> the desired xTSQ value**.*
>>
>
> I believe they are setting the xTSQ value using the sk_pacing_shift fi= eld,
> which was added here:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/to= rvalds/linux.git/commit/?id=3D3a9b76fd0db9f0d426533f96a68a62a58753a51e<= br> >
> AFAIK the intent is only for drivers to set that, and there's no s= ysctl for
> that, but of course you could add a sysctl for testing if you wanted.<= br> > :-)

Yup, indeed this is what mac80211 fiddles with:
https://elixir.bootlin.com/li= nux/latest/source/net/mac80211/main.c#L739
https://elixir.bootlin.com/lin= ux/latest/source/net/mac80211/tx.c#L4156

AFAICT, no in-tree drivers override the value set by mac80211.

I believe the tests in that paper were conducted with this series
applied:
https://lore.kernel.= org/all/20180105113256.14835-1-natale.patriciello@gmail.com/

-Toke

This ele= ctronic communication and the information and any files transmitted with it= , or attached to it, are confidential and are intended solely for the use o= f the individual or entity to whom it is addressed and may contain informat= ion that is confidential, legally privileged, protected by privacy laws, or= otherwise restricted from disclosure to anyone else. If you are not the in= tended recipient or the person responsible for delivering the e-mail to the= intended recipient, you are hereby notified that any use, copying, distrib= uting, dissemination, forwarding, printing, or copying of this e-mail is st= rictly prohibited. If you received this e-mail in error, please return the = e-mail to the sender, delete it from your computer, and destroy any printed= copy of it. --0000000000000dbc0305ee1576eb-- --00000000000014367505ee157613 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQagYJKoZIhvcNAQcCoIIQWzCCEFcCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3BMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBUkwggQxoAMCAQICDDGs4Qlq5OZK9mcDzTANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAxMzMzNDFaFw0yNTA5MTAxMzMzNDFaMIGM MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xFDASBgNVBAMTC0JvYiBNY01haG9uMScwJQYJKoZIhvcNAQkB Fhhib2IubWNtYWhvbkBicm9hZGNvbS5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIB AQDBfX3nsBFRdO26im8lhOadVadRmV/YWK+U9OoGlTE+2MDsjJwO5p/Q6iaTUropqMRH1E+EIuhe /OU6a3/btrqzARE77RaVSdz5swXt7M4ciN+z44nIEx36UQIlFLsBFa3is/J/QLFhTUFFf0wLJsUO wyja+KvygH/E5TyfeXf5T2Y2wjGZx8jQXZMDmNpfANlEBYDfzCNYcAIQNox8FuPpEpuxWvv7jvxV X5dfkSef9T/DbsDM0PeTVMVyYIQoRSMBIGxVkaqp0MJglvQ2mU4CXcoOGgm6XC8LoLoEvYojXFKC fRgCOT5xeMR10UPSBQIljKwt7fPhpYVY+jTtOclpAgMBAAGjggHZMIIB1TAOBgNVHQ8BAf8EBAMC BaAwgaMGCCsGAQUFBwEBBIGWMIGTME4GCCsGAQUFBzAChkJodHRwOi8vc2VjdXJlLmdsb2JhbHNp Z24uY29tL2NhY2VydC9nc2djY3IzcGVyc29uYWxzaWduMmNhMjAyMC5jcnQwQQYIKwYBBQUHMAGG NWh0dHA6Ly9vY3NwLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwME0G A1UdIARGMEQwQgYKKwYBBAGgMgEoCjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxz aWduLmNvbS9yZXBvc2l0b3J5LzAJBgNVHRMEAjAAMEkGA1UdHwRCMEAwPqA8oDqGOGh0dHA6Ly9j cmwuZ2xvYmFsc2lnbi5jb20vZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3JsMCMGA1UdEQQc MBqBGGJvYi5tY21haG9uQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEFBQcDBDAfBgNVHSME GDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUpG/4RP1YQA/iXGens9pIRe7CQxMw DQYJKoZIhvcNAQELBQADggEBACfWLy4qJyCnOa3sl4LEDAMU/gmJ6LbclGE5iR4KanAmlAt92gzN 5lSy/iE+wsRrXiHI7YKFgXX1kVK/RqMiPRrw4hq2j8nxoSi/VFiyS3CsfVMGkbY7HBTlBvla/tH+ +2nJprlXbJyz1GdvoJAeam5RvTWotcCGAjZmMa3U3zMkszgXN849xe3dUK1DauUGiInXEwEdXDcA /0CVjL3EEMj+kNWcLhrSZKwFtxggUyMW3XWRaAeAL9wOtEaXYqlgbtnV0n9FuoV2TNm3h7Mh7rjV I2zM+IZ3DE+XFK7dcPwte33u75QyySNJ3UMZqi25CO85yl8Bmo7aWRm99N7HGnkxggJtMIICaQIB ATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhH bG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwxrOEJauTmSvZnA80wDQYJ YIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIJ2cZuDUgCBf6kMv4yg4BFF/rfbYAq6n5HJO XqvYnU7AMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTIyMTEyMjIx MDAyNlowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUDBAEWMAsGCWCGSAFl AwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsGCWCGSAFlAwQCATAN BgkqhkiG9w0BAQEFAASCAQALYLZxrg5M6tUMaj/lmekTylcupHNdjwCdbO6KESwTiJjBqYn3cg9L Nj2japcYiFM1UmCfObONLG7v1LuaPBgZ1NZCWji9xyxk4pjEu0yQJdPzkqgyFC3OCfPodvALKF4o pF2/UT2LNbvSKfRPtrK2hwmUaD9i2AciIFpOY9UV1c4lOOzsqGIjRaYBl5jmj+F844LeURwEOlfO xQ3gKzR1Upr1OzyKTKCkensRwmvEZB7vC7aitPyraknM07qn1Jv89NP3MlSfrNOLIDOMaXMoQY2c ORumZj3GyFY037sF4Eo8wCj7QyhTwXa5SwDS/9GH1a8kzEMAVndmiQtwiSfm --00000000000014367505ee157613--