General list for discussing Bufferbloat
 help / color / mirror / Atom feed
From: Jonathan Foulkes <jf@jonathanfoulkes.com>
To: Sebastian Moeller <moeller0@gmx.de>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
	cerowrt-devel@lists.bufferbloat.net,
	"Y via Bloat" <bloat@lists.bufferbloat.net>
Subject: Re: [Bloat] New OpenWrt release fixing several dnsmasq CVEs
Date: Sat, 23 Jan 2021 11:29:45 -0500	[thread overview]
Message-ID: <D61BE9D1-4E1C-4D67-BAD7-C34FC2AC4CA7@jonathanfoulkes.com> (raw)
In-Reply-To: <626C02F8-C761-44B1-A5B0-0B55B564BC94@gmx.de>

Hi Seb, someone did just that and even better, compared two builds with the dnsmasq being the only variable, and did not see any differences:
https://forum.openwrt.org/t/security-advisory-2021-01-19-1-dnsmasq-multiple-vulnerabilities/85903/85

From other comments, looks like they found the bug and are testing the fix.
https://git.openwrt.org/?p=openwrt/staging/ldir.git;a=commitdiff;h=9a18346676850646764072ffcfd32ad9396d95c3

Jonathan

> On Jan 22, 2021, at 4:40 PM, Sebastian Moeller <moeller0@gmx.de> wrote:
> 
> Could you try to run top or htop and look at the CPU load? I could imagine that the fixes dnsmasq might have some CPU spikes that simply leave not enough cycles for the traffic shaper?
> 
> Best Regards
> 	Sebastian
> 
>> On Jan 22, 2021, at 22:25, Jonathan Foulkes <jf@jonathanfoulkes.com> wrote:
>> 
>> I figure there should be no inter-dependencies there, but the side-effect of the new dnsmasq is pretty serious.
>> 
>> I did not install .6, I only performed an opkg update of the dnamasq package itself. So kernal is the same in my case.
>> 
>> But others running a full .6 build report similar QoS issues.
>> 
>> I regressed back to .4 and all is good on the QoS front, waiting until a new drop of dnsmasq before trying again.
>> 
>> - Jonathan
>> 
>>> On Jan 22, 2021, at 4:15 PM, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>>> 
>>> Jonathan Foulkes <jf@jonathanfoulkes.com> writes:
>>> 
>>>> I installed the updated package on a 19.07.4 box running cake, and QoS performance went down the tubes.
>>>> Last night it locked up completely while attempting to stream.
>>>> 
>>>> See the PingPlots others have posted to this forum thread, mine look similar, went from constant sub 50ms to very spiky, then some loss, loss increasing, and if high traffic, lock-up.
>>>> https://forum.openwrt.org/t/security-advisory-2021-01-19-1-dnsmasq-multiple-vulnerabilities/85903/39
>>>> 
>>>> load is low, sirq is low, so box does not seem stressed.
>>>> 
>>>> Any reason Cake would be sensitive to a dnsmasq bug?
>>> 
>>> No, not really. I mean, dnsmasq could be sending some traffic that
>>> interferes with stuff? Or it could be a kernel regression - the release
>>> did bump the kernel version as well...
>>> 
>>> -Toke
>> 
>> _______________________________________________
>> Bloat mailing list
>> Bloat@lists.bufferbloat.net
>> https://lists.bufferbloat.net/listinfo/bloat
> 


  reply	other threads:[~2021-01-23 16:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 23:20 Toke Høiland-Jørgensen
2021-01-22 19:33 ` Jonathan Foulkes
2021-01-22 21:15   ` Toke Høiland-Jørgensen
2021-01-22 21:25     ` Jonathan Foulkes
2021-01-22 21:27       ` Daniel Sterling
2021-01-22 21:40         ` Toke Høiland-Jørgensen
2021-01-22 21:40       ` Sebastian Moeller
2021-01-23 16:29         ` Jonathan Foulkes [this message]
2021-01-23 16:33           ` Daniel Sterling
2021-01-23 20:04           ` [Bloat] [Cerowrt-devel] " Etienne Champetier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/bloat.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D61BE9D1-4E1C-4D67-BAD7-C34FC2AC4CA7@jonathanfoulkes.com \
    --to=jf@jonathanfoulkes.com \
    --cc=bloat@lists.bufferbloat.net \
    --cc=cerowrt-devel@lists.bufferbloat.net \
    --cc=moeller0@gmx.de \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox