From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-x241.google.com (mail-pg0-x241.google.com [IPv6:2607:f8b0:400e:c05::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 430F13CB35 for ; Sat, 31 Mar 2018 20:50:35 -0400 (EDT) Received: by mail-pg0-x241.google.com with SMTP id i194so7174012pgd.0 for ; Sat, 31 Mar 2018 17:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=F00Gf4NS0MQxRS0E0wzgE83qqDQEd9qW1XkKIMsBmDs=; b=Rdc/OcuqMBPUqHAP/zbc9AriPvA9atKA3tcX5wJ8V9P3JCPvBpZp10lfJ/p18nrXIw CNqvbLsY5c4ndCs7HiSI9o0lP2+jFig7MNbPMkNwbAmd2E4DrUsytbp0snbBiMm57MRE grUw0kfLHX9OiHLnJk8HUGBcEYRB6QhN5MHQiNq0Hb34WE33VgWkGP9+XBkZ4WTkOhwS jl5/jD43qtN5x7YDhG5X6Hx/e84CSlfNuMYVsAgSYZWS+8IC6fWW7/ZhM3fOwTsp/lo3 PmXcMh1KKlwLIZJwGZ8sIsy95fvKcnfZpDaxrKTn/2yWBqANTF3aKST5VgfOeUN2stPw lEsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=F00Gf4NS0MQxRS0E0wzgE83qqDQEd9qW1XkKIMsBmDs=; b=cWkZD80ygwE8gB3Sl5Hp5YugA27WI7brT2rKdvWqgEAslUwMRf2Y7YZLEjf/GkrQYg tRl5ZlXR9HRlOChFN1JrYjGhQfm9naPaeJlzmfMToH1BNnxhV6dKf6Uc/ZZwPW0NXsHm Srv6wi5yj779rVL4WZubOerasOWy+X40jwkvWIoouHTcyFcQadlAHRUUyUL40guOyf92 DHYt0dNYsiNowwDe/mQXwLM2yk6S/b/vgFHXltvhiXJWD3WtAt7yxSxHZCyqFECjVRmH fcuJ3zEUfrIkmEEKgsww0Bz10haKHnClIOzza6FQ3/SOs+ca98i3W/bPoavnxGokroqr 683w== X-Gm-Message-State: AElRT7FFU1zbCI3OtazotcMxu+71v59QuDmUnTu+aKMNB9nQAnqcrAXS FRbepcRfwXco1ullHzLxf0S63UAz X-Google-Smtp-Source: AIpwx4++NVqdog14TagCaKbN6gL2CiVpOhSE6PzTDE84z4LPONzrwGNmLZmgk0Yiknn/Sy4WDc/x7g== X-Received: by 10.99.120.138 with SMTP id t132mr2926868pgc.280.1522543834196; Sat, 31 Mar 2018 17:50:34 -0700 (PDT) Received: from [192.168.86.235] (c-67-180-167-114.hsd1.ca.comcast.net. [67.180.167.114]) by smtp.gmail.com with ESMTPSA id e21sm20953246pfi.68.2018.03.31.17.50.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 31 Mar 2018 17:50:32 -0700 (PDT) To: bloat@lists.bufferbloat.net References: <87y3i8hvmy.fsf@toke.dk> <3DCC1B31-2A54-4306-A355-7DBD15184C5F@gmail.com> From: Eric Dumazet Message-ID: Date: Sat, 31 Mar 2018 17:50:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <3DCC1B31-2A54-4306-A355-7DBD15184C5F@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Bloat] bufferbloat.net server having troubles? X-BeenThere: bloat@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: General list for discussing Bufferbloat List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Apr 2018 00:50:35 -0000 On 03/31/2018 12:54 PM, Jonathan Morton wrote: >> On 31 Mar, 2018, at 10:50 pm, Toke Høiland-Jørgensen wrote: >> >> Yeah, the box running the web server is having some issues with NULL >> pointer dereferences in tcp_push() in the kernel crashing processes >> running TCP. Haven't been able to figure out why :/ > > Maybe build/install a new kernel and reboot? > > Possibility exists of hardware failure, too. Less likely, perhaps, but if you don't have ECC... > Nope, known bug on stable kernels. Please upgrade or downgrade. $ git log --oneline v4.14.31..v4.14.32 -- net/ipv4/tcp.c e44c1733059c tcp: purge write queue upon aborting the connection commit e44c1733059c69868e81f82eb09fcb6bbc492050 Author: Soheil Hassas Yeganeh Date: Tue Mar 6 17:15:12 2018 -0500 tcp: purge write queue upon aborting the connection [ Upstream commit e05836ac07c77dd90377f8c8140bce2a44af5fe7 ] When the connection is aborted, there is no point in keeping the packets on the write queue until the connection is closed. Similar to a27fd7a8ed38 ('tcp: purge write queue upon RST'), this is essential for a correct MSG_ZEROCOPY implementation, because userspace cannot call close(fd) before receiving zerocopy signals even when the connection is aborted. Fixes: f214f915e7db ("tcp: enable MSG_ZEROCOPY") Signed-off-by: Soheil Hassas Yeganeh Signed-off-by: Neal Cardwell Reviewed-by: Eric Dumazet Signed-off-by: Yuchung Cheng Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman