From: <gamanakis@gmail.com>
To: "'Pete Heist'" <pete@heistp.net>,
"'Jonathan Morton'" <chromatix99@gmail.com>
Cc: "'Sebastian Moeller'" <moeller0@gmx.de>,
"'Toke Høiland-Jørgensen via Cake'" <cake@lists.bufferbloat.net>
Subject: Re: [Cake] Upstream submission of dual-mode fairness patch
Date: Sun, 3 Mar 2019 14:03:20 -0500 [thread overview]
Message-ID: <000001d4d1f3$c5599eb0$500cdc10$@gmail.com> (raw)
In-Reply-To: <9746402E-41EA-43F9-AAE6-53C038EABFFF@heistp.net>
For the record, I can replicate it now. I also think that this behavior is expected.
There is a work-around but it seems like an awful hack:
----------8<----------
diff --git a/sch_cake.c b/sch_cake.c
index 733b897..08e08f4 100644
--- a/sch_cake.c
+++ b/sch_cake.c
@@ -2216,7 +2216,6 @@ retry:
if (q->rate_flags & CAKE_FLAG_INGRESS) {
len = cake_advance_shaper(q, b, skb,
now, true);
- flow->deficit -= len;
b->tin_deficit -= len;
}
flow->dropped++;
----------8<----------
Then the results are:
IP1, 1 up: 47.18 mbit/s
IP2, 32 up: 46.99
IP1, 32 down: 40.98
IP2, 1 down: 41.34
next prev parent reply other threads:[~2019-03-03 19:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.1788.1551352661.3538.cake@lists.bufferbloat.net>
2019-03-01 10:52 ` Pete Heist
2019-03-01 11:01 ` Toke Høiland-Jørgensen
2019-03-01 11:55 ` Pete Heist
2019-03-01 14:40 ` Georgios Amanakis
2019-03-01 16:43 ` Pete Heist
2019-03-02 3:02 ` George Amanakis
2019-03-02 4:47 ` George Amanakis
2019-03-02 10:20 ` Pete Heist
2019-03-03 7:19 ` Pete Heist
2019-03-03 9:53 ` Sebastian Moeller
2019-03-03 9:58 ` Jonathan Morton
2019-03-03 11:26 ` Sebastian Moeller
2019-03-03 12:13 ` Jonathan Morton
2019-03-03 12:53 ` Sebastian Moeller
2019-03-03 16:07 ` Pete Heist
2019-03-03 16:10 ` Jonathan Morton
2019-03-03 16:35 ` Pete Heist
2019-03-03 16:40 ` Jonathan Morton
2019-03-03 18:48 ` Pete Heist
2019-03-03 19:03 ` gamanakis [this message]
2019-03-03 19:49 ` Pete Heist
2019-03-04 2:55 ` Georgios Amanakis
2019-03-04 3:17 ` Jonathan Morton
2019-03-04 4:22 ` Ryan Mounce
2019-03-04 8:27 ` Pete Heist
2019-03-04 13:17 ` Pete Heist
2019-03-04 14:36 ` Georgios Amanakis
2019-03-03 12:06 ` Pete Heist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d4d1f3$c5599eb0$500cdc10$@gmail.com' \
--to=gamanakis@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=chromatix99@gmail.com \
--cc=moeller0@gmx.de \
--cc=pete@heistp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox