Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Jonathan Morton <chromatix99@gmail.com>
To: cake@lists.bufferbloat.net, codel@lists.bufferbloat.net,
	bloat <bloat@lists.bufferbloat.net>
Subject: [Cake] Today's cake
Date: Wed, 17 Jun 2015 08:49:14 +0300	[thread overview]
Message-ID: <00270BE3-4932-4294-8917-8A9C2B462FCF@gmail.com> (raw)

I just put in three quite small tweaks to cake:

1) Codel now has a saturating increment for count, rather than a wrapping one.

2) The active flow counter is now an atomic-access variable.  This is really just an abundance of caution.

3) The overload drop routine should now be somewhat more efficient in most cases, since it iterates over the active flows rather than the entire array.  I haven’t measured how much of a difference it makes in practice, but it should be positive.

Point 1 turns out to matter rather a lot under unresponsive loads, given that count is only 16 bits.

The “50 up 1 down asymmetric” test now produces the desired results for the download stream *without* the need to prioritise the acks; Codel now reaches a steady-ish state where it drops enough of them to keep everything moving, and this leaves more bandwidth in the up direction for the 50 streams.

The version of that test with a prioritised download stream reveals that quite a lot of drops (as well as marks) are still occurring in the 50 streams.  This, to my mind, is a sign of too much aggression in the switch from marking to dropping, but I need to work out the numbers to be more confident about adjusting that.

 - Jonathan Morton


             reply	other threads:[~2015-06-17  5:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17  5:49 Jonathan Morton [this message]
2015-06-17  6:16 ` Dave Taht
2015-06-17  6:25   ` Jonathan Morton
2015-06-18 14:31 ` [Cake] [Bloat] " Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00270BE3-4932-4294-8917-8A9C2B462FCF@gmail.com \
    --to=chromatix99@gmail.com \
    --cc=bloat@lists.bufferbloat.net \
    --cc=cake@lists.bufferbloat.net \
    --cc=codel@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox