Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: "cake@lists.bufferbloat.net" <cake@lists.bufferbloat.net>
Subject: Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure
Date: Thu, 8 Mar 2018 11:14:58 +0000	[thread overview]
Message-ID: <04044BF0-504A-41DC-8F1B-A9528B4E887A@darbyshire-bryant.me.uk> (raw)
In-Reply-To: <8B3F5A39-852D-41CE-B623-C65FCBA037FF@darbyshire-bryant.me.uk>

[-- Attachment #1: Type: text/plain, Size: 5218 bytes --]



> On 8 Mar 2018, at 11:09, Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> wrote:
> 
> 
> 
>> On 8 Mar 2018, at 10:57, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>> 
>> Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:
>> 
>>> Archer c7 v2. master branch of openwrt
>> 
>> Ah, great; I actually have one of those sitting on my desk that I could
>> potentially reflash without breaking anything too important.
>> 
>> In the meantime; do you get the same weird output on the
>> dropped/overlimit/requeues fields if you install a different qdisc than
>> cake?
> 
> From previous email this morning:
> 
>> Definitely dubious and I’m no longer convinced it’s a cake only issue.  Looked at my AP which is running an older version of openwrt, so older cake, older kernel etc etc and all qdiscs are returning odd impossibly high values in a variety of fields.
> 
> 
> 
> tc -s qdisc
> qdisc noqueue 0: dev lo root refcnt 4485644
> Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
> qdisc fq_codel 0: dev eth1 root refcnt 4485644 limit 4497776p flows 4535164 quantum 4536072 target 5.0ms interval 100.0ms memory_limit 4Mb ecn
> Sent 74281480509 bytes 91321865 pkts (dropped 0, overlimits 0)
>  maxpacket 1514 drop_overlimit 0 new_flow_count 7549 ecn_mark 0
>  new_flows_len 0 old_flows_len 0
> qdisc noqueue 0: dev br-lan root refcnt 4485644
> Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
> qdisc noqueue 0: dev eth1.2 root refcnt 4485644
> Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
> qdisc noqueue 0: dev br-wifi_guest root refcnt 4485644
> Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
> qdisc noqueue 0: dev eth1.15 root refcnt 4485644
> Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
> qdisc noqueue 0: dev wlan1 root refcnt 4485644
> Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
> qdisc noqueue 0: dev wlan0 root refcnt 4485644
> Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
> qdisc noqueue 0: dev wlan1-1 root refcnt 4485644
> Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
> qdisc noqueue 0: dev wlan0-1 root refcnt 4485644
> Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
> 
> And that’s on an openwrt system from commit f5b4f5f8e33624f27af9fb3f86e09084181c08ed
> Author: Alif M. Ahmad <alive4ever@live.com>
> Date:   Sun Feb 25 03:18:41 2018 +0000
> 
> So actually this problem has been around a little while, pre recent cake changes.

Oh and curiously the bad values go away if you ask for json output it’s much better.  Which rather points at a ‘feature’ of the ‘print_string’ behaviour.

tc -s -j qdisc
[{
        "kind": "noqueue",
        "handle": "0:",
        "dev": "lo",
        "root": true,
        "refcnt": 2,
        "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
    },{
        "kind": "fq_codel",
        "handle": "0:",
        "dev": "eth1",
        "root": true,
        "refcnt": 2,
        "options": {
            "limit": 10240,
            "flows": 1024,
            "quantum": 1514,
            "target": 4999,
            "interval": 99999,
            "memory_limit": 4194304,
            "ecn": true
        } Sent 74283705614 bytes 91330210 pkts (dropped 0, overlimits 0)   maxpacket 1514 drop_overlimit 0 new_flow_count 7549 ecn_mark 0
  new_flows_len 0 old_flows_len 0
    },{
        "kind": "noqueue",
        "handle": "0:",
        "dev": "br-lan",
        "root": true,
        "refcnt": 2,
        "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
    },{
        "kind": "noqueue",
        "handle": "0:",
        "dev": "eth1.2",
        "root": true,
        "refcnt": 2,
        "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
    },{
        "kind": "noqueue",
        "handle": "0:",
        "dev": "br-wifi_guest",
        "root": true,
        "refcnt": 2,
        "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
    },{
        "kind": "noqueue",
        "handle": "0:",
        "dev": "eth1.15",
        "root": true,
        "refcnt": 2,
        "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
    },{
        "kind": "noqueue",
        "handle": "0:",
        "dev": "wlan1",
        "root": true,
        "refcnt": 2,
        "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
    },{
        "kind": "noqueue",
        "handle": "0:",
        "dev": "wlan0",
        "root": true,
        "refcnt": 2,
        "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
    },{
        "kind": "noqueue",
        "handle": "0:",
        "dev": "wlan1-1",
        "root": true,
        "refcnt": 2,
        "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
    },{
        "kind": "noqueue",
        "handle": "0:",
        "dev": "wlan0-1",
        "root": true,
        "refcnt": 2,
        "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
    }
]


> 
> 
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake


Cheers,

Kevin D-B

012C ACB2 28C6 C53E 9775  9123 B3A2 389B 9DE2 334A


[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-03-08 11:15 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-26 15:08 [Cake] [PATCH] Split tin stats to its own structure to decrease size of tc_cake_xstats Toke Høiland-Jørgensen
2017-12-26 16:28 ` Dave Taht
2017-12-26 16:32   ` Toke Høiland-Jørgensen
2018-01-27 13:05 ` [Cake] [PATCH v2] " Toke Høiland-Jørgensen
2018-02-09 12:58   ` Jonathan Morton
2018-02-09 13:08     ` Toke Høiland-Jørgensen
2018-02-11 17:26   ` [Cake] [PATCH v3] " Toke Høiland-Jørgensen
2018-02-11 17:26     ` [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure Toke Høiland-Jørgensen
2018-03-01 11:02       ` Jonathan Morton
2018-03-01 11:06         ` Sebastian Moeller
2018-03-01 13:59           ` Toke Høiland-Jørgensen
2018-03-05 23:08           ` Jonathan Morton
2018-03-06 11:17             ` Toke Høiland-Jørgensen
2018-03-06 11:46               ` Jonathan Morton
2018-03-06 12:10                 ` Sebastian Moeller
2018-03-06 13:08                   ` Jonathan Morton
2018-03-06 13:18                     ` Sebastian Moeller
2018-03-01 13:59         ` Toke Høiland-Jørgensen
2018-03-04 11:14           ` Toke Høiland-Jørgensen
2018-03-06 15:56       ` Stephen Hemminger
2018-03-06 18:33         ` Toke Høiland-Jørgensen
2018-03-06 21:06           ` Toke Høiland-Jørgensen
2018-03-06 22:31             ` Jonathan Morton
2018-03-07  8:50               ` Toke Høiland-Jørgensen
2018-03-07 10:08                 ` Kevin Darbyshire-Bryant
2018-03-07 10:31                   ` Toke Høiland-Jørgensen
2018-03-07 10:36                     ` Toke Høiland-Jørgensen
2018-03-07 11:08                       ` Kevin Darbyshire-Bryant
2018-03-07 11:28                         ` Toke Høiland-Jørgensen
2018-03-07 11:59                           ` Kevin Darbyshire-Bryant
2018-03-07 12:59                             ` Toke Høiland-Jørgensen
2018-03-07 14:21                               ` Sebastian Moeller
2018-03-07 14:30                                 ` Toke Høiland-Jørgensen
2018-03-07 15:25                                   ` Dave Taht
2018-03-07 15:52                                     ` Toke Høiland-Jørgensen
2018-03-07 17:26                                       ` Dave Taht
2018-03-08 22:29                                         ` Pete Heist
2018-03-07 18:27                               ` Kevin Darbyshire-Bryant
2018-03-07 18:35                                 ` Kevin Darbyshire-Bryant
2018-03-07 18:37                                 ` Jonathan Morton
2018-03-07 21:34                                 ` Toke Høiland-Jørgensen
2018-03-08  0:49                                   ` Jonathan Morton
2018-03-08  7:59                                     ` Kevin Darbyshire-Bryant
2018-03-08  9:21                                       ` Kevin Darbyshire-Bryant
2018-03-08 10:32                                         ` Toke Høiland-Jørgensen
     [not found]                                           ` <D8A90884-6DAE-42A6-A680-CD11599DDD97@darbyshire-bryant.me.uk>
2018-03-08 10:57                                             ` Toke Høiland-Jørgensen
2018-03-08 11:09                                               ` Kevin Darbyshire-Bryant
2018-03-08 11:14                                                 ` Kevin Darbyshire-Bryant [this message]
2018-03-08 11:21                                                   ` Toke Høiland-Jørgensen
2018-03-08 18:32                                                     ` Georgios Amanakis
2018-03-10 15:56                                                     ` Kevin Darbyshire-Bryant
2018-03-10 16:30                                                       ` Luis E. Garcia
2018-03-07 11:07                     ` Kevin Darbyshire-Bryant
2018-03-07 11:19                       ` Sebastian Moeller
2018-03-07 11:31                       ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04044BF0-504A-41DC-8F1B-A9528B4E887A@darbyshire-bryant.me.uk \
    --to=kevin@darbyshire-bryant.me.uk \
    --cc=cake@lists.bufferbloat.net \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox