From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0047.outbound.protection.outlook.com [104.47.2.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 647FC3CB3C for ; Thu, 8 Mar 2018 06:15:08 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darbyshire-bryant.me.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1kw+3Vy3bKA+2hTC7R+oZ0G3ORTKWb4tWwXoRO/JAjE=; b=oXfDdgaqSm7WBXRFm5C95UdrlTly1+FIC6Vp53YsH3QLbEERYeRfGyr44GAisn4hPkmBYW+ikRAD3jheKzY11h/tAS74ethI2UtKh20EHgR/MW+ai4XyGSAAak/s70wMD+kpied4yc4vD3cmDieDlvckIwiaynLYtzaaYp71h/0= Received: from AM0PR0702MB3730.eurprd07.prod.outlook.com (52.133.51.23) by AM0PR0702MB3601.eurprd07.prod.outlook.com (52.133.50.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.6; Thu, 8 Mar 2018 11:14:58 +0000 Received: from AM0PR0702MB3730.eurprd07.prod.outlook.com ([fe80::a95a:1cfd:7299:5172]) by AM0PR0702MB3730.eurprd07.prod.outlook.com ([fe80::a95a:1cfd:7299:5172%3]) with mapi id 15.20.0588.001; Thu, 8 Mar 2018 11:14:58 +0000 From: Kevin Darbyshire-Bryant To: =?utf-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= CC: "cake@lists.bufferbloat.net" Thread-Topic: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure Thread-Index: AQHTtf92ZAagU2vDn02WdO/2XvDtbKPElDwAgAAI7YCAAAWrAIAACK4AgAAQ4oCAAFtzAIAANGmAgAA2UYCAAHgrgIAAFtAAgAAT6ICAAAGnAIAABVyAgAADTgCAAAGeAA== Date: Thu, 8 Mar 2018 11:14:58 +0000 Message-ID: <04044BF0-504A-41DC-8F1B-A9528B4E887A@darbyshire-bryant.me.uk> References: <20180127130542.25817-1-toke@toke.dk> <20180211172618.13297-2-toke@toke.dk> <20180306075616.380a533c@xeon-e3> <87ina9m4up.fsf@toke.dk> <876068nccm.fsf@toke.dk> <0A156FD3-4816-462C-952B-7938EF8C0EA3@gmail.com> <87sh9cl15n.fsf@toke.dk> <879005B6-2334-4F46-9922-4BC2CACBF107@darbyshire-bryant.me.uk> <87vae8yy68.fsf@toke.dk> <87sh9cyxy9.fsf@toke.dk> <340269AF-2325-4657-8939-5E3195D1C0DC@darbyshire-bryant.me.uk> <87muzkyvj7.fsf@toke.dk> <11DDD9A0-BBD7-4DAA-ACE1-EB88CDC26E7C@darbyshire-bryant.me.uk> <87h8psyraq.fsf@toke.dk> <6F0B516E-3244-4A93-8762-3EAF3BD71BF2@darbyshire-bryant.me.uk> <87k1unlgck.fsf@toke.dk> <4654DB0C-74E6-46FB-9F62-119076D0A20B@darbyshire-bryant.me.uk> <87371a3ljk.fsf@toke.dk> <87sh9a25ta.fsf@toke.dk> <8B3F5A39-852D-41CE-B623-C65FCBA037FF@darbyshire-bryant.me.uk> In-Reply-To: <8B3F5A39-852D-41CE-B623-C65FCBA037FF@darbyshire-bryant.me.uk> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [2a02:c7f:1232:22b::dc83] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR0702MB3601; 7:K7TBlMgodxI0B3jPNDIiTcEviFWhQWBUlYsrO1waM0QMEZxC1kBY9QKWYQid2c/moFwFZsMhRuC4A7lCHwOIo4wZgkd4ttwj6TItYE6CTtfPkjUaY39Tjgpd+GqLV8c8PpJb1korRDshyg1DOLLSM19utBKdU8yvEMXrPr7G4hnCeACQLmyWfNRUEBOPaDcEQllFcypEQ+iBLU0gjwgeJAOdBDZY1b/C0m/FLiMG43WBR6nssg8oAvy6xQlQared x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: fecfc08b-9069-4f02-1e8d-08d584e5d44e x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(7021125)(5600026)(4604075)(3008032)(4534165)(7022125)(4603075)(4627221)(201702281549075)(7048125)(7024125)(7027125)(7028125)(7023125)(2017052603328)(7153060)(49563074)(7193020); SRVR:AM0PR0702MB3601; x-ms-traffictypediagnostic: AM0PR0702MB3601: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(37052965297144)(226747003789276); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(102415395)(6040501)(2401047)(8121501046)(5005006)(3002001)(3231220)(944501244)(52105095)(93006095)(93001095)(10201501046)(6041288)(2016111802025)(20161123564045)(20161123562045)(20161123560045)(20161123558120)(6042181)(6043046)(6072148)(201708071742011); SRVR:AM0PR0702MB3601; BCL:0; PCL:0; RULEID:; SRVR:AM0PR0702MB3601; x-forefront-prvs: 060503E79B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39380400002)(366004)(396003)(39830400003)(199004)(189003)(55674003)(4326008)(5660300001)(6306002)(6512007)(106356001)(6246003)(53936002)(6116002)(99936001)(5250100002)(81156014)(81166006)(8936002)(305945005)(7736002)(2906002)(6486002)(25786009)(93886005)(105586002)(3280700002)(8676002)(2900100001)(6436002)(82746002)(6916009)(2950100002)(86362001)(36756003)(229853002)(76176011)(59450400001)(46003)(68736007)(478600001)(316002)(53546011)(6346003)(966005)(83716003)(3660700001)(6506007)(97736004)(102836004)(74482002)(14454004)(33656002)(99286004)(186003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0702MB3601; H:AM0PR0702MB3730.eurprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: darbyshire-bryant.me.uk does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=kevin@darbyshire-bryant.me.uk; x-microsoft-antispam-message-info: KbWoiGiUdzZS9L2+GmiXKFXGjEQpvLFYoryppI2xxs1K6zHX4vbEwrXFZmExSbhpllTYFSdbWRJkTwGt+j95O9OwPkkC+nCOdLXcQIspJYCnIGCHjeZBNA2YXIVA1ZVW+WavfYguoYiKEQ8d+0clTVUWA5jKGwXtGdS78gxuxa77dGQaRPjSwjYCeS4K9LTqot1DY49/cyDK9JOs0vGmYb5W1geMUsR6JA4gPG35rOCowZeoh9+ty/fsf+tKoycZIRgDawtNkib4xgUydYX+QHT2rw2NVt71j86Awli1BrfbZhEQkm6jLnub4W/oJtg/y/dtyObYnGT6O0pgXXOrGw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/signed; boundary="Apple-Mail=_843FEC4B-17F3-487B-8582-79852B759B96"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 X-OriginatorOrg: darbyshire-bryant.me.uk X-MS-Exchange-CrossTenant-Network-Message-Id: fecfc08b-9069-4f02-1e8d-08d584e5d44e X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2018 11:14:58.6278 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 9151708b-c553-406f-8e56-694f435154a4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0702MB3601 Subject: Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2018 11:15:08 -0000 --Apple-Mail=_843FEC4B-17F3-487B-8582-79852B759B96 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 8 Mar 2018, at 11:09, Kevin Darbyshire-Bryant = wrote: >=20 >=20 >=20 >> On 8 Mar 2018, at 10:57, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >>=20 >> Kevin Darbyshire-Bryant writes: >>=20 >>> Archer c7 v2. master branch of openwrt >>=20 >> Ah, great; I actually have one of those sitting on my desk that I = could >> potentially reflash without breaking anything too important. >>=20 >> In the meantime; do you get the same weird output on the >> dropped/overlimit/requeues fields if you install a different qdisc = than >> cake? >=20 > =46rom previous email this morning: >=20 >> Definitely dubious and I=E2=80=99m no longer convinced it=E2=80=99s a = cake only issue. Looked at my AP which is running an older version of = openwrt, so older cake, older kernel etc etc and all qdiscs are = returning odd impossibly high values in a variety of fields. >=20 >=20 >=20 > tc -s qdisc > qdisc noqueue 0: dev lo root refcnt 4485644 > Sent 0 bytes 0 pkts (dropped 0, overlimits 0) > qdisc fq_codel 0: dev eth1 root refcnt 4485644 limit 4497776p flows = 4535164 quantum 4536072 target 5.0ms interval 100.0ms memory_limit 4Mb = ecn > Sent 74281480509 bytes 91321865 pkts (dropped 0, overlimits 0) > maxpacket 1514 drop_overlimit 0 new_flow_count 7549 ecn_mark 0 > new_flows_len 0 old_flows_len 0 > qdisc noqueue 0: dev br-lan root refcnt 4485644 > Sent 0 bytes 0 pkts (dropped 0, overlimits 0) > qdisc noqueue 0: dev eth1.2 root refcnt 4485644 > Sent 0 bytes 0 pkts (dropped 0, overlimits 0) > qdisc noqueue 0: dev br-wifi_guest root refcnt 4485644 > Sent 0 bytes 0 pkts (dropped 0, overlimits 0) > qdisc noqueue 0: dev eth1.15 root refcnt 4485644 > Sent 0 bytes 0 pkts (dropped 0, overlimits 0) > qdisc noqueue 0: dev wlan1 root refcnt 4485644 > Sent 0 bytes 0 pkts (dropped 0, overlimits 0) > qdisc noqueue 0: dev wlan0 root refcnt 4485644 > Sent 0 bytes 0 pkts (dropped 0, overlimits 0) > qdisc noqueue 0: dev wlan1-1 root refcnt 4485644 > Sent 0 bytes 0 pkts (dropped 0, overlimits 0) > qdisc noqueue 0: dev wlan0-1 root refcnt 4485644 > Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >=20 > And that=E2=80=99s on an openwrt system from commit = f5b4f5f8e33624f27af9fb3f86e09084181c08ed > Author: Alif M. Ahmad > Date: Sun Feb 25 03:18:41 2018 +0000 >=20 > So actually this problem has been around a little while, pre recent = cake changes. Oh and curiously the bad values go away if you ask for json output = it=E2=80=99s much better. Which rather points at a =E2=80=98feature=E2=80= =99 of the =E2=80=98print_string=E2=80=99 behaviour. tc -s -j qdisc [{ "kind": "noqueue", "handle": "0:", "dev": "lo", "root": true, "refcnt": 2, "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) },{ "kind": "fq_codel", "handle": "0:", "dev": "eth1", "root": true, "refcnt": 2, "options": { "limit": 10240, "flows": 1024, "quantum": 1514, "target": 4999, "interval": 99999, "memory_limit": 4194304, "ecn": true } Sent 74283705614 bytes 91330210 pkts (dropped 0, overlimits 0) = maxpacket 1514 drop_overlimit 0 new_flow_count 7549 ecn_mark 0 new_flows_len 0 old_flows_len 0 },{ "kind": "noqueue", "handle": "0:", "dev": "br-lan", "root": true, "refcnt": 2, "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) },{ "kind": "noqueue", "handle": "0:", "dev": "eth1.2", "root": true, "refcnt": 2, "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) },{ "kind": "noqueue", "handle": "0:", "dev": "br-wifi_guest", "root": true, "refcnt": 2, "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) },{ "kind": "noqueue", "handle": "0:", "dev": "eth1.15", "root": true, "refcnt": 2, "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) },{ "kind": "noqueue", "handle": "0:", "dev": "wlan1", "root": true, "refcnt": 2, "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) },{ "kind": "noqueue", "handle": "0:", "dev": "wlan0", "root": true, "refcnt": 2, "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) },{ "kind": "noqueue", "handle": "0:", "dev": "wlan1-1", "root": true, "refcnt": 2, "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) },{ "kind": "noqueue", "handle": "0:", "dev": "wlan0-1", "root": true, "refcnt": 2, "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) } ] >=20 >=20 > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake Cheers, Kevin D-B 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A --Apple-Mail=_843FEC4B-17F3-487B-8582-79852B759B96 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEASyssijGxT6XdZEjs6I4m53iM0oFAlqhGzIACgkQs6I4m53i M0pm3BAAoibiXszGrA15NWAGsussvl/2KlD8zUN1Lp/ysUY6gj1KqNamj2e+myRN 0L90+Jgd6KPshqt3AJXBML7vZiYL0/suFI0LgQ6OhD3fwvhdNcpZxVw6pWFs987D V8Kv4Sdg3y6X+7uIHfF3ML9HSWJgaCwuje73wfxJKjZGIM2xoqkE5YtdXdGkSleG DD7l/LLyiinOmYNiB5jZK57sKKpSWmEZ+bDDJ2GRFBECge+VeRMJgQxNp+JrvpX3 caQZw5vHNE5lHvHe4cETQo/NqdhMy/pYRR/6QSzJv2xMwc96VhRnFomKwgIFJCoH i9XW7u1B3z+v4Nm5qTUatMJboYpHp+c3gGnMY13Kuuv8bk0dDpVx8HzxiE6nw6kp 5A4hmOBTKyUZwrfA+FG0ST9+ss3FKiE8qcOWvzMYzEmtJd8+Sr02fdOtx16Wj80N lVwcFx+bcjhZq4uxXqieGijOeO4UtH08f0WVbb0uaD+Db01O5VrZQmJQMQOCo43u p+BMb4EAFcQ5X5Bq8SdZM38Ron+6W/t724Zwz4gatFbF9CCVcnPt7W9fO3hHXwoe i6MiWEjVKjna54477FPG4TFYNge/tTQDSRWeGBnKp6ylfg25M6wN+sqyx4ILXxWJ dGs8k7Ls97BfPpau5C/DEcAkWmEphEfO7Nf6fEQyGaQ8/6oM6LQ= =w96I -----END PGP SIGNATURE----- --Apple-Mail=_843FEC4B-17F3-487B-8582-79852B759B96--