From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x234.google.com (mail-lf0-x234.google.com [IPv6:2a00:1450:4010:c07::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 0223B3CB5D for ; Mon, 5 Mar 2018 18:08:26 -0500 (EST) Received: by mail-lf0-x234.google.com with SMTP id l191so25652128lfe.1 for ; Mon, 05 Mar 2018 15:08:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Frv/lyJmXUZeOPi7yYmbafb7CrQRmekmIOBFEmqhbtY=; b=W/S+k+PdLbcI4e5NTqFiUUg0lreGrnh6dbYlc7fWKzlH5Ie4fjgZTQsMwRB6lt3GLm 1AXa97rQR+K3z5GRbjOFATd3VGl/7G3nyRczT9i4LN/Z4tHtcMjhqmW4apPWI3YtNuTk rQlAFyOBghda3mjc2POaWhWa3B3mYv7oaQfkJDtGu/wMXkcxLRs4UVmpsprGLHK4skZZ QeAoEt/Brbf7y2OAHB+7YCKDgo8WTeJ3nf0blDQeNlYAJzSUqpigGsho27wbkq2u6Ibl DWwvN3Y4Z+/QWsWt9f+T+ZFmyek9cpn9HULn1GSYfjvJdGWedRlVq8lJDGUxuYEn/wGe /iMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Frv/lyJmXUZeOPi7yYmbafb7CrQRmekmIOBFEmqhbtY=; b=U8aaBEjJmirFsrBWLMujJOWZXBHwR/0WGepKe4yOR5L37DB0ledKZ4GQqTUREsGAXJ SU++j1yjAiS5/sN/M04jHXTwbBz45K/4WviOM78vSfaHiqnICQO2r8ssKcqoV1H0uJFj SZvGxrsHnYQVoTXaPXkwDNUw4raKGtk+YEaO4MNkMSY40f9Rbz5a1bgkC9ckWsccATiF kdvaF1ZWeviPGPJnlx1/6pad5tuwQ3O8U+vuENyF6DK9CviALChkPsZjQ1ii4Uf8Y5ez MhPOWtIcgDHLtoXrrRFnAMydiBS4R58dfm/W3RgitOLeHrHmPyUPVxYrRffr8TVPP57H bnxQ== X-Gm-Message-State: AElRT7GfXsWDd/e1neCzSrY2jGOkauTDNKhKSUPGzv0kBDDomNuxEUXU TXh9iHrr0yz5qo4c1qmDF9M= X-Google-Smtp-Source: AG47ELvqRf+kYDw9ESu0G/6/BAPkG0FopVYIk2YiD0FWfBSqAqntTcCxxVw3RWBlcR9Mn/x1D3cdPA== X-Received: by 10.46.92.7 with SMTP id q7mr11061021ljb.21.1520291305857; Mon, 05 Mar 2018 15:08:25 -0800 (PST) Received: from [192.168.239.216] (83-245-237-207-nat-p.elisa-mobile.fi. [83.245.237.207]) by smtp.gmail.com with ESMTPSA id q24sm2884815lff.32.2018.03.05.15.08.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Mar 2018 15:08:25 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) From: Jonathan Morton In-Reply-To: <12C7E818-E440-40A9-AE67-C6EDD7F87FB6@gmx.de> Date: Tue, 6 Mar 2018 01:08:22 +0200 Cc: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , cake@lists.bufferbloat.net Content-Transfer-Encoding: quoted-printable Message-Id: <08E2549E-769F-4AF3-8D34-22A149432463@gmail.com> References: <20180127130542.25817-1-toke@toke.dk> <20180211172618.13297-1-toke@toke.dk> <20180211172618.13297-2-toke@toke.dk> <12C7E818-E440-40A9-AE67-C6EDD7F87FB6@gmx.de> To: Sebastian Moeller X-Mailer: Apple Mail (2.3445.5.20) Subject: Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2018 23:08:27 -0000 > On 1 Mar, 2018, at 1:06 pm, Sebastian Moeller wrote: >=20 > BTW, my testing so far with the latest tc-adv did not result in any = crashes, but I also did not research whether the overhead account = behaves like expected... I've just added the relevant stats output. This breaks the stats struct = again (better to do that just after breaking it once, I suppose), but I = left in some padding to reduce the need for that in future. These stats = are kept globally, so are only reported as if for one tin. So far it looks like everything is working fine and behaving as it = should (on a plain Ethernet interface). The one wrinkle is that it = takes a few thousand packets for the avg_off value to converge on the = true value, but that should easily be tolerable in most cases. - Jonathan Morton