Re: [Cake] allocate_src allocate_dst

[Pete Heist <peteheist@gmail.com>]

> On Nov 25, 2017, at 3:08 PM, Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> wrote:
> 
>> On 25 Nov 2017, at 03:59, Dave Taht <dave.taht@gmail.com> wrote:
>> 
>> there is no place in the current code base where these are not both
>> true or both false. Thus redundant.
>> 
>> ?
> 
> Yes, interesting that.  Been there since introduced in 5a6da2ba Add triple-isolation support.  *EXPERIMENTAL*
> 
> Have done a PR https://github.com/dtaht/sch_cake/pull/72 with a minor cleanup for that - been running on my router with no explosions :-)

Woah, nice find. I’d been working through that function (looking at setting srchost_hash and dsthost_hash to a packet mark value for custom isolation) and between the gotos and ifdefs for kernel version support, it takes some work to look at it.

Could this function be refactored a bit for readability? I’d offer to do it, but this is an important piece of code with little room for error and more ways to plant hard to find problems, better played with by someone who’s more familiar with it...