From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22d.google.com (mail-wm0-x22d.google.com [IPv6:2a00:1450:400c:c09::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 50E8E3B29E for ; Sat, 25 Nov 2017 11:28:28 -0500 (EST) Received: by mail-wm0-x22d.google.com with SMTP id g130so23416246wme.0 for ; Sat, 25 Nov 2017 08:28:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=wFogF2nSnxqwEqx0/2Ta9A21txAUZcEGbNltBOKvVWg=; b=FDsKgtejaR8bHZOQTu5rL3r5HccxYZx/XTX8fXR0HpxiNyZahfGLcl7CtjsgNQm++/ oVlCM3Ged8EuY/3K4Mqupnhr0pAv4uqWAdo7TDDSf5ioI7UiGzC+5NlrMpVivTBAxk69 N7aLWyMbM5Cpr/+vAmgREqoLrvZyP+lEqfIHjDUBTnx2Yz3MuIRn7dk9NUq0scErxVVL q9koUB5MLYEa2Ww5fRujF5Edo39mJC/ZVvkWJStlPzlttLs4k6JKRfTrpjcnLpwnee03 DD1pkPku0SLD4ynkOwZwQn1hCXLcjY/wvF7OZHRJI7TREgyvADAbCTDCY4VcL/f6rMMm UB1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=wFogF2nSnxqwEqx0/2Ta9A21txAUZcEGbNltBOKvVWg=; b=k4xT7vOyBMJRaHzgszTAoP52s0L8D+J6VwZzo2bSWOQmPmemPIpZPT0mu7O/yeLnFG viyrMQZ2lP+o3seon20d/vxeY4PFoM58ZpVy17NIqR1L++NBXIs4ZBlejFRHFIn6K60S XWSyrkhDO6gdJbwDdN62qaiFcbGJ1HQyn2Hwv6W0EgzS4gBmcHdEQxxYKLCfBJLFxTqN SX3742ryqzXYaYSR0vbWXvBiC1UM9Sip7f1frsJNZ4auQPpU0W6NYsyq7yuPW5IIzurr tyyElQVNXKSuxrcUqMVh5YDJyT2e+EimM8deYxM3JjLPP5fs4lK0Uj3KNxFWt3BSU4mZ wiqw== X-Gm-Message-State: AJaThX5NPtT9TExmd9pOuQmBwDzlRXRPB1mrWsrJuyLG71PeAnENLaro aRqeMwrWko9NVnZ0to6l5kw= X-Google-Smtp-Source: AGs4zMaoG5NZ3KcvGxSAlUi1J30MmjHwjHmEABPGWqcxbcEit42D9XnNHkWxgwF8vRe8D49V1n+vMg== X-Received: by 10.28.191.80 with SMTP id p77mr14075052wmf.85.1511627307386; Sat, 25 Nov 2017 08:28:27 -0800 (PST) Received: from [10.72.0.130] (h-1169.lbcfree.net. [185.99.119.68]) by smtp.gmail.com with ESMTPSA id w76sm48980619wrc.79.2017.11.25.08.28.25 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 25 Nov 2017 08:28:26 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: Pete Heist In-Reply-To: <840D255A-5723-4D95-BEF3-50B411A7D0E8@darbyshire-bryant.me.uk> Date: Sat, 25 Nov 2017 17:28:29 +0100 Cc: Kevin Darbyshire-Bryant , Cake List Content-Transfer-Encoding: quoted-printable Message-Id: <0D923D70-F9A2-4CB9-A516-B6B80FF4967B@gmail.com> References: <840D255A-5723-4D95-BEF3-50B411A7D0E8@darbyshire-bryant.me.uk> To: Dave Taht X-Mailer: Apple Mail (2.3124) Subject: Re: [Cake] allocate_src allocate_dst X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Nov 2017 16:28:28 -0000 > On Nov 25, 2017, at 3:08 PM, Kevin Darbyshire-Bryant = wrote: >=20 >> On 25 Nov 2017, at 03:59, Dave Taht wrote: >>=20 >> there is no place in the current code base where these are not both >> true or both false. Thus redundant. >>=20 >> ? >=20 > Yes, interesting that. Been there since introduced in 5a6da2ba Add = triple-isolation support. *EXPERIMENTAL* >=20 > Have done a PR https://github.com/dtaht/sch_cake/pull/72 with a minor = cleanup for that - been running on my router with no explosions :-) Woah, nice find. I=E2=80=99d been working through that function (looking = at setting srchost_hash and dsthost_hash to a packet mark value for = custom isolation) and between the gotos and ifdefs for kernel version = support, it takes some work to look at it. Could this function be refactored a bit for readability? I=E2=80=99d = offer to do it, but this is an important piece of code with little room = for error and more ways to plant hard to find problems, better played = with by someone who=E2=80=99s more familiar with it...=