From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id E80383B29E for ; Sat, 5 Jan 2019 17:41:46 -0500 (EST) Received: by mail-wr1-x442.google.com with SMTP id j2so39824140wrw.1 for ; Sat, 05 Jan 2019 14:41:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heistp.net; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=v6s2W0spRyYRzc4mZ5fjJV2DvVzfsrAgJc5XLca8BUs=; b=jrLHWPbhpaeKKfB9wuMwuBoKi9U4U+LIFAlMdOcu0R3wozBGfPB9sV8d52P1gT58ag q9f4SZ6OfMQltlOUykvorht31QefGYCJldQ5L9I0rj2kTXA172CUub4h2PHJHBl0rYqb 6mpR4IZlDfB9mvjrjKnNALhUbOeLIApjnFjH+NJalRdiEoLSZoQL+0Jn/V8VNcorpdFj 5tRdJ5HiDOkTcxcuQ+JgPseQ0Jrf/1jFCWdJgR6ifLMz5pgbN1rGSmKsrX9R72p1Rl18 NRkye00gc1dxaztk6BVb8yWByXzdjdgg1D1KuHyOwMK0nNAyGr/WCo2UWURCqatB0o4e 0xHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=v6s2W0spRyYRzc4mZ5fjJV2DvVzfsrAgJc5XLca8BUs=; b=MP/mzDir856Zm1PHqjhZimNUcQlYOYIk25TmLhOJtUZfLxwVWkhf6slyHA8f4QXrKC grGReVzK01WPcZZ1fuHIKlguJhP3jwOk8bUKybZ8Qr3wJg4NsLIeX/Famd9xpFSqwuVf sAq54jCUvmUZxXxTBjFtyaeklh25geo9LnAJuK3x2hPs3hGw8nVs8Qa7YQZEtNDkYLWS S0eUqU8UqrWnxnCqL3wdXtHb4NPglBp05VtVPjU34bmZBC3NUv5LjuAsx3Yfx9h9L/Ie rnTN6YnBy/AOSTzj3GgLTHHY1Gu1rusiMW2s3L6GsXwb2EQNz+gRrMRRqWFCSQv42DAU MWRA== X-Gm-Message-State: AJcUukdPrUE0BI+LVD4HcP5SVEelAGue3tc3dvKKs9rSUxUElP6s87ut O9CZN/6lt3AgpUvUpCC5PcNxIg== X-Google-Smtp-Source: ALg8bN5OgIwVySkVuLy5FS5l4Jri5IK3vxuSFZs5fnBmwPC66NuloofeL8l2VqRwv0zIxMQ6oZsYSw== X-Received: by 2002:adf:9382:: with SMTP id 2mr46638933wrp.269.1546728106000; Sat, 05 Jan 2019 14:41:46 -0800 (PST) Received: from tron.luk.heistp.net (h-1169.lbcfree.net. [185.193.85.130]) by smtp.gmail.com with ESMTPSA id l20sm105135377wrb.93.2019.01.05.14.41.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Jan 2019 14:41:45 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) From: Pete Heist In-Reply-To: <87ftu6yc2y.fsf@toke.dk> Date: Sat, 5 Jan 2019 23:41:43 +0100 Cc: Sebastian Moeller , Cake List Content-Transfer-Encoding: quoted-printable Message-Id: <11DD478A-E61D-4D62-92B3-30B9A9A9572E@heistp.net> References: <5482A3CA-9C36-4DDE-A858-24D8467F70C7@heistp.net> <8736q8yumt.fsf@toke.dk> <4C422792-7E51-4DBA-A229-FA7D3F987FB6@heistp.net> <87zhsgxdao.fsf@toke.dk> <87wonjxvss.fsf@toke.dk> <0077CC34-490F-4D76-82D3-BE37B27F2E1C@heistp.net> <49A6DCF8-BE98-47F4-9C66-6B4288390A58@heistp.net> <87tvinxos7.fsf@toke.dk> <87r2drxnal.fsf@toke.dk> <45D43135-318B-48AD-B09B-69BBB034CE12@heistp.net> <87o98vxm57.fsf@toke.dk> <797FCC60-0048-4EF6-80BC-19707E9173FB@heistp.net> <87lg3zxdyr.fsf@toke.dk> <87imz2yiet.fsf@toke.dk> <252DC221-7024-4834-9757-96335372A5A7@heistp.net> <87ftu6yc2y.fsf@toke.dk> To: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Mailer: Apple Mail (2.3445.9.1) Subject: Re: [Cake] cake infinite loop(?) with hfsc on one-armed router X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jan 2019 22:41:47 -0000 > On Jan 5, 2019, at 11:27 PM, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >=20 > Pete Heist writes: >=20 >>> On Jan 5, 2019, at 9:10 PM, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >>>=20 >>> Well, it's the same WARN_ON(), and if that patch had been applied, >>> debugging our issue would have been a lot harder, I think. >>=20 >> Yikes, this is what I mean. I=E2=80=99d rather suffer the warning = than be >> troubleshooting flaky behavior. That patch is applied in the latest >> kernel, so hopefully it=E2=80=99s the right thing. >=20 > Well, if it causes false positives, getting rid of it is probably = worth > it just to avoid spurious bug reports :) If it helps finds bugs, I=E2=80=99d rather know about it. But, a warning once in a while might have been better than a repeated = one that sometimes makes a hard reboot necessary, causing need for a = manual, offline fsck in order to boot again. Just sayin=E2=80=99=E2=80=A6 = ;)