From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eric.dumazet@gmail.com>
Received: from mail-wg0-x22b.google.com (mail-wg0-x22b.google.com
	[IPv6:2a00:1450:400c:c00::22b])
	(using TLSv1 with cipher RC4-SHA (128/128 bits))
	(Client CN "smtp.gmail.com",
	Issuer "Google Internet Authority G2" (verified OK))
	by huchra.bufferbloat.net (Postfix) with ESMTPS id D4B9D21F5B2;
	Thu, 18 Jun 2015 07:31:11 -0700 (PDT)
Received: by wgzl5 with SMTP id l5so65575574wgz.3;
	Thu, 18 Jun 2015 07:31:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:subject:from:to:cc:date:in-reply-to:references
	:content-type:mime-version:content-transfer-encoding;
	bh=kxHvI53W1A/E+QJtqqHQYpmU1B+Qq8kyIbjOJkKOyu0=;
	b=gfcJm8RmsRo/ZxsnNo4RKMfyLb9eQp7t5hwN1XM1+ymzMHPp+mGL6neAm5sQHXzsP7
	cHGZokWD6zf0ytzWYn7bM15iHKPyoOceZJaGJAcuUThggrTLk0xJIFuLAEb8jUhZcWed
	XbBLXjpT/gevhisMOqj+NFgKRy17gHlucqDbO9xT/wIAnAzpx0+EVFXtr3uhxrpmS9pF
	hEruHk6Basl0JHj5S269vl6CVo0vpCQgydmWD498pRHLjYGOnDOca62/lRBuFomRdKIA
	MGpxWmBJ2IjxetgmijPkaxSMo+nBFXPYRyIuwAuvc7OnNM/lCUwic2PjmEBOAcG1BijM
	JyDg==
X-Received: by 10.180.23.8 with SMTP id i8mr56556977wif.39.1434637869433;
	Thu, 18 Jun 2015 07:31:09 -0700 (PDT)
Received: from [172.28.89.249] ([172.28.89.249])
	by mx.google.com with ESMTPSA id
	be3sm13393238wib.21.2015.06.18.07.31.06
	(version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128/128);
	Thu, 18 Jun 2015 07:31:08 -0700 (PDT)
Message-ID: <1434637860.27504.209.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jonathan Morton <chromatix99@gmail.com>
Date: Thu, 18 Jun 2015 07:31:00 -0700
In-Reply-To: <00270BE3-4932-4294-8917-8A9C2B462FCF@gmail.com>
References: <00270BE3-4932-4294-8917-8A9C2B462FCF@gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Fri, 19 Jun 2015 03:52:39 -0700
Cc: cake@lists.bufferbloat.net, codel@lists.bufferbloat.net,
	bloat <bloat@lists.bufferbloat.net>
Subject: Re: [Cake] [Bloat] Today's cake
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
	<mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
	<mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Thu, 18 Jun 2015 14:31:40 -0000

On Wed, 2015-06-17 at 08:49 +0300, Jonathan Morton wrote:
> 2) The active flow counter is now an atomic-access variable.  This is really just an abundance of caution.

Certainly not needed.

Qdisc enqueue() & dequeue() are done under qdisc spinlock protection.