Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Jonathan Morton <chromatix99@gmail.com>
To: George Amanakis <gamanakis@gmail.com>
Cc: kevin@darbyshire-bryant.me.uk, cake@lists.bufferbloat.net
Subject: Re: [Cake] progress? dual-src/dsthost unfairness
Date: Wed, 13 Feb 2019 20:41:47 +0200	[thread overview]
Message-ID: <144BF042-D64B-45D2-BF48-16FD7AE67411@gmail.com> (raw)
In-Reply-To: <20190213183132.11019-1-gamanakis@gmail.com>

> On 13 Feb, 2019, at 8:31 pm, George Amanakis <gamanakis@gmail.com> wrote:
> 
> I recently rewrote the patch (out-of-tree cake) so as to keep track of the 
> bulk/sparse flow-count per host. I have been testing it for about a month
> on a WRT1900ACS and it runs fine.
> 
> Would love to hear if Jonathan or anybody else has thought of
> implementing something different.

This does actually look more reasonable.  However:

1: Why is host_load calculated using host_sparse_flow_count instead of host_bulk_flow_count in cake_enqueue()?

2: Do we actually need to maintain host_sparse_flow_count at all, or only the bulk one?  If the above is corrected, I don't think there are any uses left.

 - Jonathan Morton


  reply	other threads:[~2019-02-13 18:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13 17:33 Kevin Darbyshire-Bryant
2019-02-13 18:31 ` George Amanakis
2019-02-13 18:41   ` Jonathan Morton [this message]
2019-02-13 19:26     ` gamanakis
2019-02-13 19:31       ` Jonathan Morton
2019-02-13 19:35         ` gamanakis
2019-02-13 20:55           ` George Amanakis
2019-02-14 11:15           ` Toke Høiland-Jørgensen
2019-02-14 18:02             ` George Amanakis
2019-02-14 18:14               ` Toke Høiland-Jørgensen
2019-02-14 18:45                 ` [Cake] Make the dual modes fairer George Amanakis
2019-02-14 19:07                 ` [Cake] progress? dual-src/dsthost unfairness Jonathan Morton
2019-02-14 20:27                   ` gamanakis
2019-02-14 21:22                     ` [Cake] Make the dual modes fairer George Amanakis
2019-02-14 21:59                       ` Toke Høiland-Jørgensen
2019-02-14 19:00               ` [Cake] progress? dual-src/dsthost unfairness Pete Heist

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=144BF042-D64B-45D2-BF48-16FD7AE67411@gmail.com \
    --to=chromatix99@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=gamanakis@gmail.com \
    --cc=kevin@darbyshire-bryant.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox