From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id D55203CB37 for ; Wed, 13 Feb 2019 13:42:05 -0500 (EST) Received: by mail-lj1-x232.google.com with SMTP id z25-v6so2918249ljk.7 for ; Wed, 13 Feb 2019 10:42:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=zNOZyXXUDttOAQ3LjLvF2Ki++RkD/8L1p0PMqqL9M5o=; b=MUFYDXsntImr1uvApj3+oURAwP75LGNLlBLWGXYAhrWA59z3SjQnj7u16oUbQoUtMF nw5g0BaSuSkbPLI7t2HhzgNBMYW2IJrcKZwJDfPgAT/jRhLouhMzvR2y+vwnckP8Vfag Sd3eTRNnaERJ+IlCCpC8ZvX7jfmyLVo5wMIW56IuyuqnYFOGwLJm/kgPnoVR1bH8q4e6 3NXlCzz2tnabncNnmj5CReSBP5aHXTwH4EjhxT9beEWzNpdO7baNWYPbVH/Gm2yiEsEq GAQT+xFgJTK60HZjgDHe3DjcbqafoikCcgSvydWQn+cWMTR5uhpchEkZDvE4vuiADRcw ztEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=zNOZyXXUDttOAQ3LjLvF2Ki++RkD/8L1p0PMqqL9M5o=; b=Pfg9gWnQ7L/c58xhB3Pu7cYbmA1WrvypxZBlkoSdGi3Y3V5dMJtOGWknQBuvZ8aZIA JEp9L4UKYmki92u8+Xbg+lE6FX/1jemBBwWglUFDhv+DHqe0Np3sHcxmtHPrAOdz+9Vi doW1pslQLhZwJavg/iVnjug1uRPB39hSy4YSfmhMOnirXeMRPrdNTm8AOT5Fv8zXjLnn 0J/UpUdqzKA2P1Q7dOk+Mf31oVcHDDoGFOL2b8yhg0U6sddDZOHkdL6xLBTUnM7JAFzb Oqnh2JBXZ9Lpo4K/ms/Ks/jRoZyLom+txV9AcKBABUT0jsD3MSf78zQicDmvyp0Setgp BYAA== X-Gm-Message-State: AHQUAublHjCyoNoriOICF2toWXcVixjzMDLbhOuMDiWj82LEbI+ydz1X Va7ITgZW/UUm7v4OgAQKMrA= X-Google-Smtp-Source: AHgI3IYQoYF7s6UjYTt+CatRBQWVbSNRx7wJratzX4pcjYyxGXKpQrrZWy5sNKCN+tFS2s0SXipz9Q== X-Received: by 2002:a2e:9209:: with SMTP id k9-v6mr1194154ljg.12.1550083324631; Wed, 13 Feb 2019 10:42:04 -0800 (PST) Received: from jonathartonsmbp.lan (83-245-234-39-nat-p.elisa-mobile.fi. [83.245.234.39]) by smtp.gmail.com with ESMTPSA id n14sm4214216lfl.90.2019.02.13.10.41.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 10:42:04 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) From: Jonathan Morton In-Reply-To: <20190213183132.11019-1-gamanakis@gmail.com> Date: Wed, 13 Feb 2019 20:41:47 +0200 Cc: kevin@darbyshire-bryant.me.uk, cake@lists.bufferbloat.net Content-Transfer-Encoding: quoted-printable Message-Id: <144BF042-D64B-45D2-BF48-16FD7AE67411@gmail.com> References: <20190213183132.11019-1-gamanakis@gmail.com> To: George Amanakis X-Mailer: Apple Mail (2.3445.9.1) Subject: Re: [Cake] progress? dual-src/dsthost unfairness X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 18:42:06 -0000 > On 13 Feb, 2019, at 8:31 pm, George Amanakis = wrote: >=20 > I recently rewrote the patch (out-of-tree cake) so as to keep track of = the=20 > bulk/sparse flow-count per host. I have been testing it for about a = month > on a WRT1900ACS and it runs fine. >=20 > Would love to hear if Jonathan or anybody else has thought of > implementing something different. This does actually look more reasonable. However: 1: Why is host_load calculated using host_sparse_flow_count instead of = host_bulk_flow_count in cake_enqueue()? 2: Do we actually need to maintain host_sparse_flow_count at all, or = only the bulk one? If the above is corrected, I don't think there are = any uses left. - Jonathan Morton