From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jonathan Morton <chromatix99@gmail.com>
Cc: Dave Taht <dave.taht@gmail.com>, cake@lists.bufferbloat.net
Subject: Re: [Cake] Possible BUG - parent backlog incorrectly updated in case of NET_XMIT_CN
Date: Sun, 12 Jun 2016 11:19:07 -0700 [thread overview]
Message-ID: <1465755547.7945.88.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <C82BE76D-1B9F-4842-8B54-E510BAFD8C2F@gmail.com>
On Sun, 2016-06-12 at 20:51 +0300, Jonathan Morton wrote:
> > On 12 Jun, 2016, at 20:48, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> >
> >> A) In my failing to make sense of all the dialog around these patches
> >> ( https://lwn.net/Articles/687617/ ), it sounds like this (inbound
> >> and outbound) processing are still locked to a single thread,
> >> essentially?
> >
> > Om a router, these discussions should not matter really, since the
> > workload is about receiving/sending packets without user space
> > intervention (well... I do hope this !)
>
> Dave’s point is that inbound and outbound processing could in
> principle be on *two* distinct threads, potentially doubling aggregate
> throughput in a CPU-limited environment.
Only if IRQ were not properly tuned (smp_affinity) on SMP host.
If you have one CPU, having two threads wont help, it will actually slow
down a bit things.
NAPI model already handles the 'one cpu, multiple queues/devices' quite
well.
next prev parent reply other threads:[~2016-06-12 18:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 11:20 Kevin Darbyshire-Bryant
2016-06-07 14:50 ` Jonathan Morton
2016-06-07 15:05 ` Kevin Darbyshire-Bryant
2016-06-11 9:11 ` Kevin Darbyshire-Bryant
2016-06-11 16:41 ` Jonathan Morton
2016-06-12 16:31 ` Eric Dumazet
2016-06-12 16:40 ` Dave Taht
2016-06-12 17:48 ` Eric Dumazet
2016-06-12 17:51 ` Jonathan Morton
2016-06-12 18:19 ` Eric Dumazet [this message]
2016-06-12 17:59 ` Jonathan Morton
2016-06-12 19:04 ` Eric Dumazet
2016-06-12 20:40 ` Benjamin Cronce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465755547.7945.88.camel@edumazet-glaptop3.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=chromatix99@gmail.com \
--cc=dave.taht@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox