From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic305-20.consmr.mail.gq1.yahoo.com (sonic305-20.consmr.mail.gq1.yahoo.com [98.137.64.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 9A3063CB38 for ; Sun, 18 Mar 2018 15:59:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1521403166; bh=DegAhuCien5hU5IeuwtwtWY0ZZH4fbRsAm0D4W4Lz7k=; h=Subject:From:To:Date:References:From:Subject; b=FKrxo0gUmMPOvgzRMOdyz1ea7fDWUYZJGoMEuTurLnnA8mhJrqY2OGZHb75K+j+A66VYHeMlDbEVHQQlm7yAqEYTSyIaW7FjvFVv1lKvx5wqubzV4apSeSEAMhTAfU0I5X/7u7s8e/BYd9Q1eD45/eDCRSf0Bb3XTJfGgBSi3ppmohTsCIjVL3Bk7l7c2h2Yb/XT4b63sb1z5mHckvov/7/n3fPGu74JJLwKxCMEyoxXeNE7xWB6RefNcGazBbp4wbh3bvVr0wUbRMmN1LiCfPctpIqdCoWpJvW5JqSZwGxp5nXDewcILzlh520zPZD/PDPMaTsrsRY4Wc4LuVDjxQ== X-YMail-OSG: 2FmezyAVM1nNQgQEGphEgcjGXr9u1f7fzxFv2yuME4KewfMCWq6GEC3D8ECdlCv rY_VgkoyHG4xmKzsYyaANgpWajyMFDB9Mk1L4neMGY9wA5AhZislw_tT7PmGauBsXeAG9En6Upmc T6Rs3RUbWfhyB7BNz0m_R_j8hxu5iBQKmbwGwbhpiG7S5lsxXF4pVs0ZlY.M8sY9GpWHySaw8xoX wu1SUD9Ey7FqXovtbNoDkJ8O49t4shAW7EnSmJufkkdsMKVhjkaqKY8BSThHYkOo6ehUJxu2cDZV Df_2yR4VEbKaCDs8zzSsRVQc2rHInWwlvMzIXxPOb2I77eOL.x1vtzKE38T5ejAVqqQ.6kInhnmX d1PNVuadDSOyl.qQN_oLVFxaztVssCa7kq6DYXMpydyCKoqXLWvZnv00rlw9P6ukqkI2_m4aNslJ GaAle617ZFFFNkCerTN4SXWNN_XDUnlii2pNeaD_nR32R6ihiDwi66fYq3K2We.FjlliisdbOK7X i78AazMXcE4N53RQoxopf_yduDrXmvJBHHXBfQiiwu2oHHhTxNmLH8v9VAJoSKFnlSr6RJxZL Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.gq1.yahoo.com with HTTP; Sun, 18 Mar 2018 19:59:26 +0000 Received: from c-76-111-113-146.hsd1.md.comcast.net (EHLO x3200.lan) ([76.111.113.146]) by smtp415.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 7dc102fad04ac5c42e71252205cac90f for ; Sun, 18 Mar 2018 19:59:25 +0000 (UTC) Message-ID: <1521403163.24047.6.camel@yahoo.com> Subject: Compiling under net-next From: Georgios Amanakis To: George Amanakis via Cake Date: Sun, 18 Mar 2018 15:59:23 -0400 References: <1521401118.10826.3.camel.ref@yahoo.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.5 Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Sun, 18 Mar 2018 18:00:06 -0400 X-List-Received-Date: Sun, 18 Mar 2018 19:59:27 -0000 Hello All, I just received a notice that in archlinux running 4.16-rc1 cake fails to build (https://aur.archlinux.org/packages/sch_cake-dkms). I can also confirm the same error with net-next and the cobalt tree:=20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D8<=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D DKMS make.log for sch_cake-r427.d2d6780 for kernel 4.16.0-rc1- 61deb7d0dddd (x86_64) Sun Mar 18 10:08:24 IST 2018 make: Entering directory '/usr/lib/modules/4.16.0-rc1- 61deb7d0dddd/build' CC [M] /var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.o /var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.c:2708:11: error: initialization from incompatible pointer type [-Werror=3Dincompatible- pointer-types] .init =3D cake_init, ^~~~~~~~~ /var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.c:2708:11: note: (near initialization for =E2=80=98cake_qdisc_ops.init=E2=80=99) /var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.c:2711:13: error: initialization from incompatible pointer type [-Werror=3Dincompatible- pointer-types] .change =3D cake_change, ^~~~~~~~~~~ /var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.c:2711:13: note: (near initialization for =E2=80=98cake_qdisc_ops.change=E2=80=99) cc1: some warnings being treated as errors make[1]: *** [scripts/Makefile.build:323: /var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.o] Error 1 make: *** [Makefile:1549: _module_/var/lib/dkms/sch_cake/r427.d2d6780/build] Error 2 make: Leaving directory '/usr/lib/modules/4.16.0-rc1- 61deb7d0dddd/build' =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D8<=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D I see that the init function type changed from (eg tbf_init): static int tbf_init(struct Qdisc *sch, struct nlattr *opt) to: static int tbf_init(struct Qdisc *sch, struct nlattr *opt, =20 struct netlink_ext_ack *extack) The same applies for the change function type (eg tbf_change), from: static int tbf_change(struct Qdisc *sch, struct nlattr *opt) to: static int tbf_change(struct Qdisc *sch, struct nlattr *opt, struct netlink_ext_ack *extack) George