From: Georgios Amanakis <gamanakis@gmail.com>
To: cake@lists.bufferbloat.net
Subject: [Cake] Compiling under net-next
Date: Sun, 18 Mar 2018 16:00:35 -0400 [thread overview]
Message-ID: <1521403235.24047.7.camel@gmail.com> (raw)
Hello All,
I just received a notice that in archlinux running 4.16-rc1 cake fails
to build (https://aur.archlinux.org/packages/sch_cake-dkms). I can also
confirm the same error with net-next and the cobalt tree:
============8<============
DKMS make.log for sch_cake-r427.d2d6780 for kernel 4.16.0-rc1-
61deb7d0dddd (x86_64)
Sun Mar 18 10:08:24 IST 2018
make: Entering directory '/usr/lib/modules/4.16.0-rc1-
61deb7d0dddd/build'
CC [M] /var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.o
/var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.c:2708:11: error:
initialization from incompatible pointer type [-Werror=incompatible-
pointer-types]
.init = cake_init,
^~~~~~~~~
/var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.c:2708:11: note:
(near initialization for ‘cake_qdisc_ops.init’)
/var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.c:2711:13: error:
initialization from incompatible pointer type [-Werror=incompatible-
pointer-types]
.change = cake_change,
^~~~~~~~~~~
/var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.c:2711:13: note:
(near initialization for ‘cake_qdisc_ops.change’)
cc1: some warnings being treated as errors
make[1]: *** [scripts/Makefile.build:323:
/var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.o] Error 1
make: *** [Makefile:1549:
_module_/var/lib/dkms/sch_cake/r427.d2d6780/build] Error 2
make: Leaving directory '/usr/lib/modules/4.16.0-rc1-
61deb7d0dddd/build'
============8<============
I see that the init function type changed from (eg tbf_init):
static int tbf_init(struct Qdisc *sch, struct nlattr *opt)
to:
static int tbf_init(struct Qdisc *sch, struct nlattr *opt,
struct netlink_ext_ack *extack)
The same applies for the change function type (eg tbf_change), from:
static int tbf_change(struct Qdisc *sch, struct nlattr *opt)
to:
static int tbf_change(struct Qdisc *sch, struct nlattr *opt,
struct netlink_ext_ack *extack)
George
next reply other threads:[~2018-03-18 20:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-18 20:00 Georgios Amanakis [this message]
2018-03-19 2:29 ` George Amanakis
2018-03-19 10:16 ` Toke Høiland-Jørgensen
2018-03-19 10:40 ` Toke Høiland-Jørgensen
[not found] ` <CACvFP_ijNbkUU8mRCyAwe16qZ=SYMStq=9QiyTBizNhLx-vZtw@mail.gmail.com>
2018-03-19 16:09 ` [Cake] Fwd: " Georgios Amanakis
2018-03-19 16:52 ` Toke Høiland-Jørgensen
2018-03-19 17:11 ` [Cake] [PATCH] Fixes for 4.16 George Amanakis
2018-03-20 9:33 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521403235.24047.7.camel@gmail.com \
--to=gamanakis@gmail.com \
--cc=cake@lists.bufferbloat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox