From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x230.google.com (mail-qk0-x230.google.com [IPv6:2607:f8b0:400d:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 275DC3CB3F for ; Sun, 18 Mar 2018 16:00:39 -0400 (EDT) Received: by mail-qk0-x230.google.com with SMTP id d206so16268939qkb.3 for ; Sun, 18 Mar 2018 13:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:date:mime-version :content-transfer-encoding; bh=CM7t4H1vwA5pnhBj43vhO6let//yI2WDt9ZNK/nFV4s=; b=On+6LraCvkAbEkOGrG+RIDyEyuU10DlFecmxZ+Ys6RBN9tm+NugvTaD8Xk9snO6Ibd t8yEM08hejdk2h2B+eQbO2gk0+FMsIscIVLsPx31i3GD6961g5pB5We4TYEbeJocysWr qr+/EO+Cc0BE2TH6JPf6TGO04G42ePP44je7rS5aIeu5C/QAmvoVn3CuiMtvhVEkCGRm vljYzpLpzTJapLdNHPrf79xduY1W3tcK7oXWgnMmVO+PEOMRapK47GgpDrMLGl81eItE ebOa/ghTrbvefkMo2o94H8Vhy0m9BQPWSyAlQR14GSIY9dKiF6QKsGMpInLyIpQngA/P RoFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:mime-version :content-transfer-encoding; bh=CM7t4H1vwA5pnhBj43vhO6let//yI2WDt9ZNK/nFV4s=; b=mmHCDo0jKsrW5WHOoqY21gDHxp/a3luiQLvG2aJENT2LTXkfcfb6G74iERv71xS2t3 DMvqx0hk/Ux5ikw5jYKRZNYQgxIqpVgH4Yw5awCm/3OI+pURp1CF6ihQEaWr6+JjhExY Ox9r3NSrVuMK3c2XFB/kyZKyUVCBx1POOFGlfMY2JrCpycuTFTVTqgP7o3REl/OKQuPd OdP9Uo6rEwVYVuBvN5dkbLp91gPgvmSG4vVj3M5L2EQ2mrvE4C6LXWAvvBGPy0BqnGSX I6ewHgTGwWdrI2eZHaOUjxq0EHCi7SFAXMD9HdLW2Lqfwyr5xnQUEQn+QBZTThM1CpXl NJ6g== X-Gm-Message-State: AElRT7GOjolBYfOR+hf+Q3Sw2O4laLYVC+BgvKgvfAXhMPcnJA4gtI2W uaak4BVtLOcYG8kl1juCqvLKYBDa X-Google-Smtp-Source: AG47ELshyXuQtp7n4vKyBenFAGHxfh4C6czv1rncCOfA/jYuo760MHLtSMXzWkfUJzPlAeP1A+P4Ng== X-Received: by 10.55.77.77 with SMTP id a74mr13550861qkb.239.1521403237625; Sun, 18 Mar 2018 13:00:37 -0700 (PDT) Received: from x3200.lan ([2601:152:4303:1315:ea1a:64e5:db6:868d]) by smtp.googlemail.com with ESMTPSA id l1sm8235298qkk.27.2018.03.18.13.00.36 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Mar 2018 13:00:36 -0700 (PDT) Message-ID: <1521403235.24047.7.camel@gmail.com> From: Georgios Amanakis To: cake@lists.bufferbloat.net Date: Sun, 18 Mar 2018 16:00:35 -0400 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.5 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Cake] Compiling under net-next X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Mar 2018 20:00:39 -0000 Hello All, I just received a notice that in archlinux running 4.16-rc1 cake fails to build (https://aur.archlinux.org/packages/sch_cake-dkms). I can also confirm the same error with net-next and the cobalt tree: ============8<============ DKMS make.log for sch_cake-r427.d2d6780 for kernel 4.16.0-rc1- 61deb7d0dddd (x86_64) Sun Mar 18 10:08:24 IST 2018 make: Entering directory '/usr/lib/modules/4.16.0-rc1- 61deb7d0dddd/build' CC [M] /var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.o /var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.c:2708:11: error: initialization from incompatible pointer type [-Werror=incompatible- pointer-types] .init = cake_init, ^~~~~~~~~ /var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.c:2708:11: note: (near initialization for ‘cake_qdisc_ops.init’) /var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.c:2711:13: error: initialization from incompatible pointer type [-Werror=incompatible- pointer-types] .change = cake_change, ^~~~~~~~~~~ /var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.c:2711:13: note: (near initialization for ‘cake_qdisc_ops.change’) cc1: some warnings being treated as errors make[1]: *** [scripts/Makefile.build:323: /var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.o] Error 1 make: *** [Makefile:1549: _module_/var/lib/dkms/sch_cake/r427.d2d6780/build] Error 2 make: Leaving directory '/usr/lib/modules/4.16.0-rc1- 61deb7d0dddd/build' ============8<============ I see that the init function type changed from (eg tbf_init): static int tbf_init(struct Qdisc *sch, struct nlattr *opt) to: static int tbf_init(struct Qdisc *sch, struct nlattr *opt, struct netlink_ext_ack *extack) The same applies for the change function type (eg tbf_change), from: static int tbf_change(struct Qdisc *sch, struct nlattr *opt) to: static int tbf_change(struct Qdisc *sch, struct nlattr *opt, struct netlink_ext_ack *extack) George