From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 43BFC3B2A4 for ; Thu, 26 Jul 2018 22:45:23 -0400 (EDT) Received: by mail-pf1-x443.google.com with SMTP id a26-v6so1217613pfo.4 for ; Thu, 26 Jul 2018 19:45:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=zHAjXhMTpzQSLBnwIC3Z7h7gcG3ropNW92kudQei4mk=; b=TcHcUOxV0O9lXBVldq2mdNh9b7x+ZByVMqQGU8egjqsIRIvHIPTTqgzOvNbJnubfuP +/+0B0WIvSvIJKBJ7rNrEeJrYcQdW2IMNA4DX9dX8r4YJeQCB25udhwCdb57c1B4Mxf5 7cTD8dFes3tCOY+GutcQD02eUPOPjndddwaZubjHx11ShrFbhlBGeo9EZVCGBSOoEaID Tg3OfzaZOq1SDInoa0WGDYNVFI6nq/OSONnyyA4t7QUwxWJyL2VdCGES27oYY6sEGRYx iKhag5ZUlCm5iSEO81hYkHATjl75kA6GuHjl2p3i/zoWl4SxzYLu5ATwRmGL1sZx/c3w xGsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zHAjXhMTpzQSLBnwIC3Z7h7gcG3ropNW92kudQei4mk=; b=Y3cJWKvph3s/g/vbGwIIoM4Z+Tn8qykSKPcElkk2eC46E2wqtK0mxBb6NwaEYo/FoE 4v9Ohu3hFw1hFFQLnBBajktNvy9atAIRAXPqfilg0jst/U7fPT1r5nqGnkcRH2QAt8KY xh3FHZ+hc1hADIvElBlJmEfR5vOz3YXd4RSNZc6/70SiOX4qHXtClpaP8tuphWHAfeQx w8rPOJfQjbH2lycgrugaVHbfeLFZQiC11BKyiNcvocdYsRzpV6UuaeE+qyxiJBOLLXfr oC14pmxZscnzjmpmZLO9rn+fWBMqlVxrjii7kvXoQCMvq3Bm1+bAjPIoHlv6gvDf2+rN /3zw== X-Gm-Message-State: AOUpUlHhKJp6PvZILtKgXHx9q5SbXEwL85VRbr7kt79lLCoQYXJ6zqsN JIjfi6BXrVsMzSHycceGkEM= X-Google-Smtp-Source: AAOMgpfGq2iapn7xCXRU0AcmguHQE2dGHZ3XsZ2johv2JgsdG99SV0f+v4uM0eF+h3oUd/5EihlZmA== X-Received: by 2002:a63:b02:: with SMTP id 2-v6mr4085225pgl.301.1532659522410; Thu, 26 Jul 2018 19:45:22 -0700 (PDT) Received: from spaceheater.lab.teklibre.com ([2603:3024:1536:86f0:225:90ff:fec1:6252]) by smtp.gmail.com with ESMTPSA id i62-v6sm4442691pge.66.2018.07.26.19.45.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 26 Jul 2018 19:45:21 -0700 (PDT) From: Dave Taht To: netdev@vger.kernel.org, cake@lists.bufferbloat.net Date: Thu, 26 Jul 2018 19:45:09 -0700 Message-Id: <1532659510-17385-1-git-send-email-dave.taht@gmail.com> X-Mailer: git-send-email 2.7.4 Subject: [Cake] [PATCH net-next] sch_cake: Make gso-splitting configurable from userspace X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:45:23 -0000 I expect the first part of this patch to generate no controversy, as being able to enable configure gso-splitting on or off in all use cases of cake is a goodness. But: I expect the single line re-enabling cake's fielded default of always splitting gro and gso packets, in shaped or unshaped mode, back into packets, to reduce my email systems' hard disk inbox to a barren, burnt cylinder, even if it is made easy to override thusly: tc qdisc replace dev whatever root cake no-split-gso While I agree that gro/gso is needed at 10gigE+ speeds, I feel offering an option to disable splitting to those users trying to run cake at those speeds is better than the alternative of forcing users running at 1Gbit, 100mbit, 10mbit and below, with and without pause frames, shaped or unshaped, to remember to split-gso. While I have assembled tons of data in use cases ranging from nearly 0 to a gbit, the first, and most compelling argument I can make is made in the commit that follows, where allowing GSO/GRO superpackets triples the size of the underlying BQL when running at a gbit. Dave Taht (1): sch_cake: Make gso-splitting configurable net/sched/sch_cake.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) -- 2.7.4