From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 1F1B53B29D for ; Thu, 25 Jun 2020 16:12:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593115931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iBtEMSCqqwF2ous8/euoABiQZsWtPIJIzCTYf75JDC4=; b=c8Sz44VUfmJ5ShmcN7QsnBMiq6oIHyRAAhDMtK52MKxRisUAVzU1WKiqIEbqVEuvNofkUt iMHQyKRh8HiooH8Os2gth9lrbj8HiFJRhNPCXjKxdf1JEtk0GtSF6HMiigftJ+6dFNFWot eUqQZhuA19Sj0kIChhvQx3rCmWu7N2o= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-320-g3S10T_nNcKVtdt28x-ucw-1; Thu, 25 Jun 2020 16:12:09 -0400 X-MC-Unique: g3S10T_nNcKVtdt28x-ucw-1 Received: by mail-qt1-f197.google.com with SMTP id r25so4833904qtj.11 for ; Thu, 25 Jun 2020 13:12:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:date:message-id:user-agent :mime-version:content-transfer-encoding; bh=iBtEMSCqqwF2ous8/euoABiQZsWtPIJIzCTYf75JDC4=; b=SHWmmU5u7jXNoAo4r+UnJ3fdEXvXvfdxy3/sdjqt4HIggBCU5aQ2S0nWcS1D9vjd5G G/72/BbaEJk5nnAlpqzZKplhNXL2ix3HT2Q0Ejk806YLjQX6yFmSEwgs4C8MR0itIRiT +1omS2zQwGU46cEw/w9NDp+/Top7x6ieWFLVLsaSKYLTrh7UvuikodTIvJgBq/NwGejZ fERsIKrODF7SnoACZag7lw1g4SBV1eKtOj6Ilq8tXG6kY+A/oUxjCRqz+ABOa8iByytI Uq5/yyZkYRE85MuznipYRuNNyyvYdY0luno7YC/2DhLEArhrczqxBmNC28E9P58dgGew QPCw== X-Gm-Message-State: AOAM533vlwa8020m7jonSWmLsH0l2x9wKjndkFWuUAPLrVpyhjF59kHv e6rK5gJ5CtVCFHOVvyjHmuvHy5k07J74IjgI0TvuprNl9/uW/WChXLOG50NHKfBnSfnxObqpmfl Ow2ppyzACZ4WqyAv8Ve89Qw== X-Received: by 2002:aed:35d8:: with SMTP id d24mr23150761qte.246.1593115929546; Thu, 25 Jun 2020 13:12:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyxhLCgg5JPGhq1a2rfL0Ro5fph9NDD2W2NBFhMnORhzlyx7accvwmYxH1iKAGUHZ5C8I0bQ== X-Received: by 2002:aed:35d8:: with SMTP id d24mr23150748qte.246.1593115929331; Thu, 25 Jun 2020 13:12:09 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id q194sm2403456qke.90.2020.06.25.13.12.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 13:12:07 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 22C231814F9; Thu, 25 Jun 2020 22:12:06 +0200 (CEST) From: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: David Miller Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net Date: Thu, 25 Jun 2020 22:12:06 +0200 Message-ID: <159311592607.207748.5904268231642411759.stgit@toke.dk> User-Agent: StGit/0.23 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Subject: [Cake] [PATCH net 0/3] sched: A couple of fixes for sch_cake X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2020 20:12:12 -0000 Hi Dave This series contains a couple of fixes for diffserv handling in sch_cake that provide a nice speedup (with a somewhat pedantic nit fix tacked on to the end). Not quite sure about whether this should go to stable; it does provide a nice speedup, but it's not strictly a fix in the "correctness" sense. I lean towards including this in stable as well, since our most important consumer of that (OpenWrt) is likely to backport the series anyway. -Toke --- Ilya Ponetayev (1): sch_cake: don't try to reallocate or unshare skb unconditionally Toke Høiland-Jørgensen (2): sch_cake: don't call diffserv parsing code when it is not needed sch_cake: fix a few style nits net/sched/sch_cake.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-)