From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nm18.bullet.mail.ne1.yahoo.com (nm18.bullet.mail.ne1.yahoo.com [98.138.90.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id C79AB3B29E for ; Tue, 11 Apr 2017 10:01:49 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1491919309; bh=tvAxrDfnWCgWg1QoePPnj8sPS3molywQ21lswhDBGFE=; h=Date:From:To:Subject:References:From:Subject; b=U8JduYmpHTKJjf2oRgHWc2cMUdID/RrnfRKNvzhMBksb1fVvrSlJl4XIAaw3QrD4FDzTTRdTj6u9vdYI0FpIn8Hu0dPsWpjJm53xT+1jeFCItHYAoqmwOeOYX8AkH6NYhS5bS+SR6vwJkYQKWl4rwvHgiKbWcKd5dGPQ5IycBXgioTOpJycv9yHt3GRK8JEJvee1VYRAETHUTh3sRvhRevQjybYkPoO8uAYCPUz7K4BJfesUsY4UN+KEOP6c6ADWNPX/4yoD5KRTWTD0/sfsMSSlRVTsHqKiIumCdFkOlu+T1TAs7DiEe0PDJRGK3PnDipZvZo6UrctqnB3wPF/MRw== Received: from [98.138.101.129] by nm18.bullet.mail.ne1.yahoo.com with NNFMP; 11 Apr 2017 14:01:49 -0000 Received: from [98.138.89.251] by tm17.bullet.mail.ne1.yahoo.com with NNFMP; 11 Apr 2017 14:01:49 -0000 Received: from [127.0.0.1] by omp1043.mail.ne1.yahoo.com with NNFMP; 11 Apr 2017 14:01:49 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 101205.34866.bm@omp1043.mail.ne1.yahoo.com X-YMail-OSG: L7SfldgVM1m0hs3MqLj8fWM5985TQNjtXqgAo9R5ey7Y0kH2.8GGQxYMRDa2Nqw kyKuZb6mlTwSNf48UNbJDzyRR9JUTrRAaO.Jt9PmnmxGEdjisHgL2jrxupsporr3sXSP0scg.MhX gopD0Hy23iL79HfOIT0yqKjOGMX4MR7FbLCpcsXCjctpUmXmlyXxPhHDSX1cNZW.Hysxg_8fk_8q Qyf67twQuKi9VJltMBnqHw4onLuTZUAJWN7IFPLiK00zgUVpVhX8iZ3V_Dpkyw2KglWnUs2mXo2m VrwDKKELzljdEri4apQAiUnj0GhJPZ65aamkxySIg6fxIvkiCp2lEaig8NbjvrDaQWkdE.I99r9v 7khAku9Z1fX16a6woMTuIi0uodO3WZLsIGP_58DVgVxC7uifSijeQ8hlhNJjZ9rqRG5weeGm33iN A0HOwb44Z1nJbxxGCUZhXUMMVE0agIYqaxqYKIwpFBgJZuEhpotrXmBw15hNa.EEzamIQgbnhe24 HSHwKObUXk2AiYayGbK9XW8mzfpuVTTc- Received: from jws200198.mail.ne1.yahoo.com by sendmailws125.mail.ne1.yahoo.com; Tue, 11 Apr 2017 14:01:48 +0000; 1491919308.674 Date: Tue, 11 Apr 2017 13:59:55 +0000 (UTC) From: George Amanakis To: cake@lists.bufferbloat.net Message-ID: <1698783902.612018.1491919195146@mail.yahoo.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_612017_1311705484.1491919195145" References: <1698783902.612018.1491919195146.ref@mail.yahoo.com> X-Mailer: WebService/1.1.9374 YMailNorrin Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 Subject: [Cake] Choosing a tin to work on X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2017 14:01:50 -0000 ------=_Part_612017_1311705484.1491919195145 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Jonathan, I have some questions regarding the algorithm to choose a tin to dequeue fr= om in sch_cake.c:-----------8<------------=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 int oi, best_tin=3D0; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0s64 best_time =3D 0xFFFFFFF= FFFFFUL; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0for(oi=3D0; oi < q->tin_cnt= ; oi++) { =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0int= tin =3D q->tin_order[oi]; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0b = =3D q->tins + tin; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if(= (b->sparse_flow_count + b->bulk_flow_count) > 0) { =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0s64 tdiff =3D b->tin_time_next_packet - now; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0if(tdiff <=3D 0 || tdiff <=3D best_time) { =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0best_time =3D tdiff; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0best_tin =3D tin; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0} =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0}-----------8<------------ 1) best_time is defined as a positive signed integer, this equals to 78 hou= rs if I did the calculations right. Why did you choose this? Did you mean t= o define it as "-1"?2) If you meant to define it as "-1", the condition "td= iff <=3D best_time" would not matter. I can see no case where "tdiff > 0" a= nd "tdiff <=3D best_time". Could you shed some light into this? Thank you,George =20 ------=_Part_612017_1311705484.1491919195145 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Jonathan,

I have some questions regarding the algorithm to choose a tin to d= equeue from in sch_cake.c:
-----------8<------------
        int oi, best_tin=3D0;
 =        s64 best_time =3D 0xFFFFFFFFFFFFU= L;

        for(oi=3D0; oi &l= t; q->tin_cnt; oi++) {
       &nbs= p;    int tin =3D q->tin_order[oi];
  &= nbsp;         b =3D q->tins= + tin;
          &nbs= p; if((b->sparse_flow_count + b->bulk_flow_count) > 0) {
&= nbsp;           &nbs= p;   s64 tdiff =3D b->tin_time_next_packet - now;
&nbs= p;            &= nbsp;  if(tdiff <=3D 0 || tdiff <=3D best_time) {
 =             &nb= sp;      best_time =3D tdiff;
  =             &nb= sp;     best_tin =3D tin;
   &nb= sp;            = }
           &nbs= p;}
        }
---= --------8<------------

1) best_time is defined = as a positive signed integer, this equals to 78 hours if I did the calculat= ions right. Why did you choose this? Did you mean to define it as "-1"?
2) If you meant to define it as "-1", the condition "tdiff <=3D best_time" would not ma= tter. I can see no case where "tdiff > 0" and "tdiff <=3D best_time".

Could you = shed some light into this?

Thank you,
Ge= orge




=

------=_Part_612017_1311705484.1491919195145--