From: patchwork-bot+netdevbpf@kernel.org
To: =?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHJlZGhhdC5jb20+?=@aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org
Cc: toke@toke.dk, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
jiri@resnulli.us, gamanakis@gmail.com, davem@davemloft.net,
syzbot+7fe7b81d602cc1e6b94d@syzkaller.appspotmail.com,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
cake@lists.bufferbloat.net, netdev@vger.kernel.org
Subject: Re: [Cake] [PATCH net] sched: sch_cake: fix bulk flow accounting logic for host fairness
Date: Thu, 05 Sep 2024 10:00:30 -0000 [thread overview]
Message-ID: <172553042950.1338142.999328518611522439.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240903160846.20909-1-toke@redhat.com>
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Tue, 3 Sep 2024 18:08:45 +0200 you wrote:
> In sch_cake, we keep track of the count of active bulk flows per host,
> when running in dst/src host fairness mode, which is used as the
> round-robin weight when iterating through flows. The count of active
> bulk flows is updated whenever a flow changes state.
>
> This has a peculiar interaction with the hash collision handling: when a
> hash collision occurs (after the set-associative hashing), the state of
> the hash bucket is simply updated to match the new packet that collided,
> and if host fairness is enabled, that also means assigning new per-host
> state to the flow. For this reason, the bulk flow counters of the
> host(s) assigned to the flow are decremented, before new state is
> assigned (and the counters, which may not belong to the same host
> anymore, are incremented again).
>
> [...]
Here is the summary with links:
- [net] sched: sch_cake: fix bulk flow accounting logic for host fairness
https://git.kernel.org/netdev/net/c/546ea84d07e3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-09-05 10:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 16:08 Toke Høiland-Jørgensen
2024-09-05 10:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172553042950.1338142.999328518611522439.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc==?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHJlZGhhdC5jb20+?=@aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org \
--cc=cake@lists.bufferbloat.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gamanakis@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+7fe7b81d602cc1e6b94d@syzkaller.appspotmail.com \
--cc=toke@toke.dk \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox