From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id DDFC83B2A4 for ; Thu, 5 Sep 2024 06:00:29 -0400 (EDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C98745C5A06; Thu, 5 Sep 2024 10:00:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE59AC4CEC3; Thu, 5 Sep 2024 10:00:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725530429; bh=9gCioDgSjBVjN3SziroHvotCnSdJ/pfwWQnuSLnFG14=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=LNIyWuV9EbRZUq3aI25gIRfbNu84ZeoPygOKdQ65mtTmczb/MUvniinIeW6mtu1yn 5IgR5C7KyRNPkF6dhvDUV1ZIAa/dGyqUI1vMaFZ7aJh9fBw1K0Z/29T0khJUk0VoxQ WxLUZsJF8I0Cw+FQE72EpUIqnarO1zapEMkXhQWPK0EXeCyW+Ft2kJO2SQbRfaIY+K R5hICbloQd8r0VsP3QdAXL7zupdhN4W+kPv2+oTAn4jKQXth/3L3HLVmk1aHQPinJz rZdER4ZpodCMNawVaMHXVR2pOEn//6Zd3eA5P4X10MX+zRp6lLSGYMbW7cKWVaX4/+ Q4rnmQJQOLFdw== Received: from [10.30.226.235] (localhost [IPv6:::1]) by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id ECEB93806644; Thu, 5 Sep 2024 10:00:30 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: patchwork-bot+netdevbpf@kernel.org Message-Id: <172553042950.1338142.999328518611522439.git-patchwork-notify@kernel.org> References: <20240903160846.20909-1-toke@redhat.com> In-Reply-To: <20240903160846.20909-1-toke@redhat.com> To: =?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHJlZGhhdC5jb20+?=@aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org Cc: toke@toke.dk, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, gamanakis@gmail.com, davem@davemloft.net, syzbot+7fe7b81d602cc1e6b94d@syzkaller.appspotmail.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, cake@lists.bufferbloat.net, netdev@vger.kernel.org X-Mailman-Approved-At: Sat, 28 Dec 2024 08:25:46 -0500 Subject: Re: [Cake] [PATCH net] sched: sch_cake: fix bulk flow accounting logic for host fairness X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Thu, 05 Sep 2024 10:00:30 -0000 X-Original-Date: Thu, 05 Sep 2024 10:00:29 +0000 X-List-Received-Date: Thu, 05 Sep 2024 10:00:30 -0000 Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Tue, 3 Sep 2024 18:08:45 +0200 you wrote: > In sch_cake, we keep track of the count of active bulk flows per host, > when running in dst/src host fairness mode, which is used as the > round-robin weight when iterating through flows. The count of active > bulk flows is updated whenever a flow changes state. > > This has a peculiar interaction with the hash collision handling: when a > hash collision occurs (after the set-associative hashing), the state of > the hash bucket is simply updated to match the new packet that collided, > and if host fairness is enabled, that also means assigning new per-host > state to the flow. For this reason, the bulk flow counters of the > host(s) assigned to the flow are decremented, before new state is > assigned (and the counters, which may not belong to the same host > anymore, are incremented again). > > [...] Here is the summary with links: - [net] sched: sch_cake: fix bulk flow accounting logic for host fairness https://git.kernel.org/netdev/net/c/546ea84d07e3 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html