From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 5C31B3B29E for ; Tue, 10 Sep 2024 21:40:32 -0400 (EDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7B496A44250; Wed, 11 Sep 2024 01:40:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF42DC4CEC3; Wed, 11 Sep 2024 01:40:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726018831; bh=qld/VT1QyB2w9eoW1MzyzE30mUWIbUSfmL8OEc8q5uY=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=MzQLIYOtR/USoE2OnqLFFZekqqIO9U8UOwDk6ZIBsbA67DiAMr3UDnVIDYANZlhAs CgC1ieEc0pb0oKYsfxcqbDrCiiSRrwb642Qtc1r41moQsoUXA1SQ6NI75BrAdRVui9 SGqqHEYk1OsqESXZRxPcKk2T4AapiSeXmTRg4HE4WAIXmxEDL08hyBXmrrp64NgBV/ SRUGgOz2gUlHbUqlYdrmB71AL85xP14ZAvLqBXe3VExWwPl06r5K88limCRApLiVz0 JPTnFXEW6LgSHVMgM6ggZpo8GeF4lZC+/eazFbuFPuXLVBDVktqVJxQj/g5UzG2WQW pD8+sOTyfUDKg== Received: from [10.30.226.235] (localhost [IPv6:::1]) by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id EB23D3822FA4; Wed, 11 Sep 2024 01:40:33 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: patchwork-bot+netdevbpf@kernel.org Message-Id: <172601883250.456797.7178255147295116839.git-patchwork-notify@kernel.org> References: <20240909091630.22177-1-toke@redhat.com> In-Reply-To: <20240909091630.22177-1-toke@redhat.com> To: =?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHJlZGhhdC5jb20+?=@aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org Cc: toke@toke.dk, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, dave.taht@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, cake@lists.bufferbloat.net, netdev@vger.kernel.org X-Mailman-Approved-At: Sat, 28 Dec 2024 08:25:46 -0500 Subject: Re: [Cake] [PATCH net-next v2] sch_cake: constify inverse square root cache X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Wed, 11 Sep 2024 01:40:32 -0000 X-Original-Date: Wed, 11 Sep 2024 01:40:32 +0000 X-List-Received-Date: Wed, 11 Sep 2024 01:40:32 -0000 Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Mon, 9 Sep 2024 11:16:28 +0200 you wrote: > From: Dave Taht > > sch_cake uses a cache of the first 16 values of the inverse square root > calculation for the Cobalt AQM to save some cycles on the fast path. > This cache is populated when the qdisc is first loaded, but there's > really no reason why it can't just be pre-populated. So change it to be > pre-populated with constants, which also makes it possible to constify > it. > > [...] Here is the summary with links: - [net-next,v2] sch_cake: constify inverse square root cache https://git.kernel.org/netdev/net-next/c/c48994baefdc You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html