From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 276203B2A4 for ; Thu, 9 Jan 2025 11:30:09 -0500 (EST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 63D485C5C77; Thu, 9 Jan 2025 16:29:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 130D6C4CED2; Thu, 9 Jan 2025 16:30:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736440208; bh=gYF/unUCBqQTAlkI6WDQpkZg0bioihJSmIQeUyPyIGY=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=QsY5yZ+tAnwIxt93PZ22YbqvTkHYzW3cPoygIHS7ZQnBmWAvI1AuCPaswIDHLzKdq C/B/ygRRXbARukY3CPS0qteP0k1l7Wu44+pVTvaHhPSAqEQXBqzlQYAzcV9s1Ez5YE ccxzGm8guieFBaraTY70HXucEmlJFmlOA6fR/1qRItdFw360Z6p+/GgKAA4myGVJr/ bpEcUARqqOHT4EhoJABlzxOVHi8z+KL6mzqAVYDTwkq1dg1ptcJxvpAPlfE0nSZjZZ yxroaUI9kRp7t5PF8x0bx/BEuhSKmafRU/TICFzznfiNmEIISIkkM2/09NyX7QLKI2 N1uL+h0P2EO3g== Received: from [10.30.226.235] (localhost [IPv6:::1]) by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id EB2CF3805DB2; Thu, 9 Jan 2025 16:30:30 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: patchwork-bot+netdevbpf@kernel.org Message-Id: <173644022981.1439025.10283041006205138071.git-patchwork-notify@kernel.org> Date: Thu, 09 Jan 2025 16:30:29 +0000 References: <20250107120105.70685-1-toke@redhat.com> In-Reply-To: <20250107120105.70685-1-toke@redhat.com> To: =?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHJlZGhhdC5jb20+?=@aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org Cc: toke@toke.dk, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, pabeni@redhat.com, syzbot+f63600d288bfb7057424@syzkaller.appspotmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, horms@kernel.org, cake@lists.bufferbloat.net, netdev@vger.kernel.org Subject: Re: [Cake] [PATCH net v2] sched: sch_cake: add bounds checks to host bulk flow fairness counts X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jan 2025 16:30:09 -0000 Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Tue, 7 Jan 2025 13:01:05 +0100 you wrote: > Even though we fixed a logic error in the commit cited below, syzbot > still managed to trigger an underflow of the per-host bulk flow > counters, leading to an out of bounds memory access. > > To avoid any such logic errors causing out of bounds memory accesses, > this commit factors out all accesses to the per-host bulk flow counters > to a series of helpers that perform bounds-checking before any > increments and decrements. This also has the benefit of improving > readability by moving the conditional checks for the flow mode into > these helpers, instead of having them spread out throughout the > code (which was the cause of the original logic error). > > [...] Here is the summary with links: - [net,v2] sched: sch_cake: add bounds checks to host bulk flow fairness counts https://git.kernel.org/netdev/net/c/737d4d91d35b You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html