Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Xiang Mei <xmei5@asu.edu>
Cc: security@kernel.org, netdev@vger.kernel.org, toke@toke.dk,
	xiyou.wangcong@gmail.com, cake@lists.bufferbloat.net,
	bestswngs@gmail.com
Subject: [Cake] Re: [PATCH net v8 1/2] net/sched: sch_cake: Fix incorrect qlen reduction in cake_drop
Date: Tue, 02 Dec 2025 12:40:07 +0000	[thread overview]
Message-ID: <176467920730.3217664.13875625137012436727.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20251128001415.377823-1-xmei5@asu.edu>

Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Thu, 27 Nov 2025 17:14:14 -0700 you wrote:
> In cake_drop(), qdisc_tree_reduce_backlog() is used to update the qlen
> and backlog of the qdisc hierarchy. Its caller, cake_enqueue(), assumes
> that the parent qdisc will enqueue the current packet. However, this
> assumption breaks when cake_enqueue() returns NET_XMIT_CN: the parent
> qdisc stops enqueuing current packet, leaving the tree qlen/backlog
> accounting inconsistent. This mismatch can lead to a NULL dereference
> (e.g., when the parent Qdisc is qfq_qdisc).
> 
> [...]

Here is the summary with links:
  - [net,v8,1/2] net/sched: sch_cake: Fix incorrect qlen reduction in cake_drop
    https://git.kernel.org/netdev/net/c/9fefc78f7f02
  - [net,v8,2/2] selftests/tc-testing: Test CAKE scheduler when enqueue drops packets
    https://git.kernel.org/netdev/net/c/108f9405ce81

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2025-12-02 12:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-28  0:14 [Cake] [PATCH net v8 1/2] net/sched: sch_cake: Fix incorrect qlen reduction in cake_drop Xiang Mei
2025-11-28  0:14 ` [Cake] [PATCH net v8 2/2] selftests/tc-testing: Test CAKE scheduler when enqueue drops packets Xiang Mei
2025-11-28  9:16   ` [Cake] " Toke Høiland-Jørgensen
2025-11-28  9:15 ` [Cake] Re: [PATCH net v8 1/2] net/sched: sch_cake: Fix incorrect qlen reduction in cake_drop Toke Høiland-Jørgensen
2025-11-28 18:49   ` Xiang Mei
2025-12-02  1:05   ` Jakub Kicinski
2025-12-02 10:13     ` Toke Høiland-Jørgensen
2025-12-02 12:40 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176467920730.3217664.13875625137012436727.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=bestswngs@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=netdev@vger.kernel.org \
    --cc=security@kernel.org \
    --cc=toke@toke.dk \
    --cc=xiyou.wangcong@gmail.com \
    --cc=xmei5@asu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox