From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; spf=pass smtp.mailfrom=; dkim=pass header.d=kernel.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by mail.toke.dk (Postfix) with ESMTPS id BC4F0A1F780 for ; Tue, 02 Dec 2025 13:43:09 +0100 (CET) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 198C7600B0; Tue, 2 Dec 2025 12:43:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7251C116D0; Tue, 2 Dec 2025 12:43:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764679387; bh=aw3nZTvPz3Ho4XxxGAvYd5yHZRyDxEc2M1vfQsO+02Q=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=qcA7L4PX7XAxay0QB6MpvHYcIxhqqUEB8Au1aXD9ibowQEpyv3qGDMk6JcHEbSIFK d4fyzrQbS2ZOd8o0QJg26gJIMTGMMw6fSUiBkuS2XsyFqJs4/5xGz3JVcg90T5x15o ZGa+zkYmSRykAIxvQqEfwsl7nZTZE8e20ZFMmJuXHLsXQx60i+H8+G5CB6O6/OYjF6 9LDMiAyDmNOkzE+xidXv1UHJdHcYufD5LO1LM0zYxj5P5x9lNppVNPnLsg9EULBVDG xKgOkXg43y2S4s/lEoqGPwy8i/QGsrsmsyqPfgQmlWwoF4PpS7uEO23kxHhie33fBo UBwI4oL9BjWRQ== Received: from [10.30.226.235] (localhost [IPv6:::1]) by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id 78AA73A54A15; Tue, 2 Dec 2025 12:40:08 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: patchwork-bot+netdevbpf@kernel.org Message-Id: <176467920730.3217664.13875625137012436727.git-patchwork-notify@kernel.org> Date: Tue, 02 Dec 2025 12:40:07 +0000 References: <20251128001415.377823-1-xmei5@asu.edu> In-Reply-To: <20251128001415.377823-1-xmei5@asu.edu> To: Xiang Mei Cc: security@kernel.org, netdev@vger.kernel.org, toke@toke.dk, xiyou.wangcong@gmail.com, cake@lists.bufferbloat.net, bestswngs@gmail.com Message-ID-Hash: RAEIIGMS4IQSSH5O56IPL2SGY2XPUB7F X-Message-ID-Hash: RAEIIGMS4IQSSH5O56IPL2SGY2XPUB7F X-MailFrom: patchwork-bot+netdevbpf@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net v8 1/2] net/sched: sch_cake: Fix incorrect qlen reduction in cake_drop List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hello: This series was applied to netdev/net.git (main) by Paolo Abeni : On Thu, 27 Nov 2025 17:14:14 -0700 you wrote: > In cake_drop(), qdisc_tree_reduce_backlog() is used to update the qlen > and backlog of the qdisc hierarchy. Its caller, cake_enqueue(), assumes > that the parent qdisc will enqueue the current packet. However, this > assumption breaks when cake_enqueue() returns NET_XMIT_CN: the parent > qdisc stops enqueuing current packet, leaving the tree qlen/backlog > accounting inconsistent. This mismatch can lead to a NULL dereference > (e.g., when the parent Qdisc is qfq_qdisc). > > [...] Here is the summary with links: - [net,v8,1/2] net/sched: sch_cake: Fix incorrect qlen reduction in cake_drop https://git.kernel.org/netdev/net/c/9fefc78f7f02 - [net,v8,2/2] selftests/tc-testing: Test CAKE scheduler when enqueue drops packets https://git.kernel.org/netdev/net/c/108f9405ce81 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html